Merge master to features/static-lambdas#39153
Merged
dibarbet merged 1 commit intofeatures/static-lambdasfrom Oct 9, 2019
Merged
Merge master to features/static-lambdas#39153dibarbet merged 1 commit intofeatures/static-lambdasfrom
dibarbet merged 1 commit intofeatures/static-lambdasfrom
Conversation
This has shown up as a significant source of allocations. The design here is that when an analyzer reports a diagnostic we may need to filter or alter it based on some configuration. Previously we stored the configuration information by closing over captured variables, but that could be very expensive if it's being done for every analyzer invocation. Since we can only really execute one analyzer per running thread on the machine, the actual number of concurrent objects we need to create is approximately the number of running threads. Pooling is a good solution to this problem.
|
Hello @dotnet-bot! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 12 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from master into features/static-lambdas.
git fetch --all git checkout merges/master-to-features/static-lambdas git reset --hard upstream/features/static-lambdas git merge upstream/master # Fix merge conflicts git commit git push upstream merges/master-to-features/static-lambdas --forceOnce all conflicts are resolved and all the tests pass, you are free to merge the pull request.