Skip to content

Merge 16.8 back into master#45544

Merged
dibarbet merged 156 commits intomasterfrom
dev/dibarbet/merge_168
Jun 30, 2020
Merged

Merge 16.8 back into master#45544
dibarbet merged 156 commits intomasterfrom
dev/dibarbet/merge_168

Conversation

@dibarbet
Copy link
Member

No description provided.

333fred and others added 16 commits June 23, 2020 09:59
…s are an rvalue context). Add testing to everywhere we're currently testing GetTypeInfo with nullable enabled. Enable digging through nullable suppression operators like we do for GetTypeInfo.
* Split debug verification out into AnalyzeWithoutRewrite to simplify code.
* Add additional GetPublicTypeSymbol calls in OperationFactory with changes in master.
* Add a few NullableWalker.DebugVerifier cases for bugs.
…ssions when validating IOperation nullability.
…8-preview1

Merge master to release/dev16.8-preview1
Enable Nullability Information in IOperation.Type
…8-preview1

Merge master to release/dev16.8-preview1
Call AsyncXMethodBuilder.Create prior to storing fields to elide double zeroing
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

…e_168

* upstream/master: (102 commits)
  Change contrast ratio to get close to 1.5:1 (#45526)
  Revert "Move SymbolSearch down to EditorFeatures (#45505)"
  Delay accessibility checks to avoid cycles (#45441)
  Prevent trying to convert metadata references into circular project references
  Remove unnecessary Clone() (#45469)
  Align addition of a synthesized override of object.Equals(object? obj) in records with the latest design. (#45475)
  Move SymbolSearch down to EditorFeatures (#45505)
  VisitType in MethodToClassRewriter for function pointers.
  Fix up nondeterminism in serializing naming style preferences
  Update dependencies from https://github.com/dotnet/arcade build 20200626.2 (#45482)
  Fix typo
  Move to vnext
  Add constant inerpolated strings to the test plan, update status for records.
  Don't emit ldftn when the result is unused.
  PR Feedback: * Additional tests for nested function contexts. * Override VisitFunctionPointerLoad in MethodToClassRewriter. * Adjust debug asserts.
  Add records to compiler test plan (#45434)
  Expand comment in CreateRecoverableText
  Replace binary serialization of encoding with a custom serializer. (#45374)
  LangVersion 9 (#44911)
  Avoid loading document text in AbstractObjectBrowserLibraryManager.DocumentChangedAsync
  ...
@ghost
Copy link

ghost commented Jun 30, 2020

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

  1. DotNet Maestro - Int
  2. DotNet Maestro

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this
From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

@dibarbet dibarbet merged commit 8601701 into master Jun 30, 2020
@ghost ghost added this to the Next milestone Jun 30, 2020
@dibarbet dibarbet deleted the dev/dibarbet/merge_168 branch June 30, 2020 01:47
@JoeRobich JoeRobich modified the milestones: Next, 16.8.P1 Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.