Delay accessibility checks to avoid cycles#45441
Conversation
|
#45424 may also solve this, let's wait for it to merge first before moving forward with this PR. |
|
@dotnet/roslyn-compiler Could I please get a review on a test-only change? |
|
|
||
| class B : A | ||
| { | ||
| public override void M1<T>(System.Nullable<T?> x) |
There was a problem hiding this comment.
The syntax error was a necessary part of the original bug. This test doesn't have the same syntax error but is still labeled as being for that bug. Is this just another sub-case that was fixed?
There was a problem hiding this comment.
The bug reproduces whether or not the closing angle bracket is missing.
There was a problem hiding this comment.
Basically these were added to try and understand which conditions trigger the bug or not-- and for instance the Hide test below never triggered the bug. Since they don't serve a distinct purpose in ensuring we don't regress this bug I could just delete all but one of the tests.
…e_168 * upstream/master: (102 commits) Change contrast ratio to get close to 1.5:1 (#45526) Revert "Move SymbolSearch down to EditorFeatures (#45505)" Delay accessibility checks to avoid cycles (#45441) Prevent trying to convert metadata references into circular project references Remove unnecessary Clone() (#45469) Align addition of a synthesized override of object.Equals(object? obj) in records with the latest design. (#45475) Move SymbolSearch down to EditorFeatures (#45505) VisitType in MethodToClassRewriter for function pointers. Fix up nondeterminism in serializing naming style preferences Update dependencies from https://github.com/dotnet/arcade build 20200626.2 (#45482) Fix typo Move to vnext Add constant inerpolated strings to the test plan, update status for records. Don't emit ldftn when the result is unused. PR Feedback: * Additional tests for nested function contexts. * Override VisitFunctionPointerLoad in MethodToClassRewriter. * Adjust debug asserts. Add records to compiler test plan (#45434) Expand comment in CreateRecoverableText Replace binary serialization of encoding with a custom serializer. (#45374) LangVersion 9 (#44911) Avoid loading document text in AbstractObjectBrowserLibraryManager.DocumentChangedAsync ...
Closes #44438