Replace binary serialization of encoding with a custom serializer.#45374
Merged
tmat merged 1 commit intodotnet:masterfrom Jun 26, 2020
Merged
Replace binary serialization of encoding with a custom serializer.#45374tmat merged 1 commit intodotnet:masterfrom
tmat merged 1 commit intodotnet:masterfrom
Conversation
Member
|
The referenced bug says that we need to either use a well known safe serialization library or essentially get buy off from the security team on the implementation. Has the latter been done here as this is a custom serializer? |
Member
Author
|
I don't think we need a buy off on this. It only requires one if built-in .NET serializers or third party libraries are used, which is not the case here. We simply serialize the name of the encoding or a well-known id. |
Member
Author
|
@dotnet/roslyn-compiler @dotnet/roslyn-ide PTAL |
jaredpar
approved these changes
Jun 26, 2020
Member
jaredpar
left a comment
There was a problem hiding this comment.
I think we need explicit sign off from security but changes look okay
GrabYourPitchforks
approved these changes
Jun 26, 2020
sharwell
reviewed
Jun 26, 2020
| [Fact] | ||
| public void EncodingSerialization_AllAvailable() | ||
| { | ||
| foreach (var info in Encoding.GetEncodings()) |
Contributor
There was a problem hiding this comment.
💡 It would be nice to have this as a Theory that uses MemberData to provide each encoding by name.
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Jun 29, 2020
* upstream/master: (1226 commits) Remove unnecessary Clone() (dotnet#45469) Align addition of a synthesized override of object.Equals(object? obj) in records with the latest design. (dotnet#45475) Move SymbolSearch down to EditorFeatures (dotnet#45505) VisitType in MethodToClassRewriter for function pointers. Fix up nondeterminism in serializing naming style preferences Update dependencies from https://github.com/dotnet/arcade build 20200626.2 (dotnet#45482) Fix typo Move to vnext Add constant inerpolated strings to the test plan, update status for records. Don't emit ldftn when the result is unused. PR Feedback: * Additional tests for nested function contexts. * Override VisitFunctionPointerLoad in MethodToClassRewriter. * Adjust debug asserts. Add records to compiler test plan (dotnet#45434) Expand comment in CreateRecoverableText Replace binary serialization of encoding with a custom serializer. (dotnet#45374) LangVersion 9 (dotnet#44911) Avoid loading document text in AbstractObjectBrowserLibraryManager.DocumentChangedAsync Allow TryGetTextVersion to pass through to the initial source Ensure recoverable text is in temporary storage Fix test Updates the option page type GUID to match the one in pkgdef ...
333fred
added a commit
that referenced
this pull request
Jun 30, 2020
…e_168 * upstream/master: (102 commits) Change contrast ratio to get close to 1.5:1 (#45526) Revert "Move SymbolSearch down to EditorFeatures (#45505)" Delay accessibility checks to avoid cycles (#45441) Prevent trying to convert metadata references into circular project references Remove unnecessary Clone() (#45469) Align addition of a synthesized override of object.Equals(object? obj) in records with the latest design. (#45475) Move SymbolSearch down to EditorFeatures (#45505) VisitType in MethodToClassRewriter for function pointers. Fix up nondeterminism in serializing naming style preferences Update dependencies from https://github.com/dotnet/arcade build 20200626.2 (#45482) Fix typo Move to vnext Add constant inerpolated strings to the test plan, update status for records. Don't emit ldftn when the result is unused. PR Feedback: * Additional tests for nested function contexts. * Override VisitFunctionPointerLoad in MethodToClassRewriter. * Adjust debug asserts. Add records to compiler test plan (#45434) Expand comment in CreateRecoverableText Replace binary serialization of encoding with a custom serializer. (#45374) LangVersion 9 (#44911) Avoid loading document text in AbstractObjectBrowserLibraryManager.DocumentChangedAsync ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1120089