Skip to content

Remove unnecessary Clone()#45469

Merged
RikkiGibson merged 1 commit intomasterfrom
remove-unnecessary-clone
Jun 29, 2020
Merged

Remove unnecessary Clone()#45469
RikkiGibson merged 1 commit intomasterfrom
remove-unnecessary-clone

Conversation

@RikkiGibson
Copy link
Member

@RikkiGibson RikkiGibson commented Jun 26, 2020

Looking at the implementation of NullableWalker.TopState() I do not believe Clone is necessary here.

Making this change independently to simplify review of later PRs.

@RikkiGibson RikkiGibson marked this pull request as ready for review June 26, 2020 17:42
@RikkiGibson RikkiGibson requested a review from a team as a code owner June 26, 2020 17:42
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (iteration 1)

@RikkiGibson RikkiGibson merged commit 7ddc52b into master Jun 29, 2020
@ghost ghost added this to the Next milestone Jun 29, 2020
@RikkiGibson RikkiGibson deleted the remove-unnecessary-clone branch June 29, 2020 16:47
333fred added a commit to 333fred/roslyn that referenced this pull request Jun 29, 2020
* upstream/master: (1226 commits)
  Remove unnecessary Clone() (dotnet#45469)
  Align addition of a synthesized override of object.Equals(object? obj) in records with the latest design. (dotnet#45475)
  Move SymbolSearch down to EditorFeatures (dotnet#45505)
  VisitType in MethodToClassRewriter for function pointers.
  Fix up nondeterminism in serializing naming style preferences
  Update dependencies from https://github.com/dotnet/arcade build 20200626.2 (dotnet#45482)
  Fix typo
  Move to vnext
  Add constant inerpolated strings to the test plan, update status for records.
  Don't emit ldftn when the result is unused.
  PR Feedback: * Additional tests for nested function contexts. * Override VisitFunctionPointerLoad in MethodToClassRewriter. * Adjust debug asserts.
  Add records to compiler test plan (dotnet#45434)
  Expand comment in CreateRecoverableText
  Replace binary serialization of encoding with a custom serializer. (dotnet#45374)
  LangVersion 9 (dotnet#44911)
  Avoid loading document text in AbstractObjectBrowserLibraryManager.DocumentChangedAsync
  Allow TryGetTextVersion to pass through to the initial source
  Ensure recoverable text is in temporary storage
  Fix test
  Updates the option page type GUID to match the one in pkgdef
  ...
333fred added a commit that referenced this pull request Jun 30, 2020
…e_168

* upstream/master: (102 commits)
  Change contrast ratio to get close to 1.5:1 (#45526)
  Revert "Move SymbolSearch down to EditorFeatures (#45505)"
  Delay accessibility checks to avoid cycles (#45441)
  Prevent trying to convert metadata references into circular project references
  Remove unnecessary Clone() (#45469)
  Align addition of a synthesized override of object.Equals(object? obj) in records with the latest design. (#45475)
  Move SymbolSearch down to EditorFeatures (#45505)
  VisitType in MethodToClassRewriter for function pointers.
  Fix up nondeterminism in serializing naming style preferences
  Update dependencies from https://github.com/dotnet/arcade build 20200626.2 (#45482)
  Fix typo
  Move to vnext
  Add constant inerpolated strings to the test plan, update status for records.
  Don't emit ldftn when the result is unused.
  PR Feedback: * Additional tests for nested function contexts. * Override VisitFunctionPointerLoad in MethodToClassRewriter. * Adjust debug asserts.
  Add records to compiler test plan (#45434)
  Expand comment in CreateRecoverableText
  Replace binary serialization of encoding with a custom serializer. (#45374)
  LangVersion 9 (#44911)
  Avoid loading document text in AbstractObjectBrowserLibraryManager.DocumentChangedAsync
  ...
@dibarbet dibarbet modified the milestones: Next, 16.7.P4 Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants