Merging master into features/embeddedJson by CyrusNajmabadi · Pull Request #26634 · dotnet/roslyn

CyrusNajmabadi · 2018-05-04T21:00:11Z

No description provided.

Leading/trailing decorative text can interfere with the pattern matcher's ability to find/bold matching spans and add redundant items to the MRU list.

…nce. (#25865) * Initial UseConditional work. * Initial UseConditional work. * Working replacement. * Extract common code. * Make 'var' work properly in the simplifier service. * Move types to their own files. * Provide a way to create types that are not simplified to 'var'. * Update test options. * Update test. * Move CSharp code style code down to the Workspace layer. * Rename config value. * Add ui options. * Add VB ui options. * Add VB support * Strip trivia * Initial stubs for 'use conditional for returns' * Add VB impl. * Only support processing of real trees. * Actually assign variable. * Don't assume a single variable. * Share more code. * Fix shared code. * Add check. * Simplify code. * Only the analyzer needs to check the severity. * Generalize loc strings. * remove static. * Remove unneeded methods. * Do cheap checks first. * Handle more cases. * Handle more cases. * Add test. * Add tests. * Add test. * Add tests. * Add tests. * Add tests. * Add tests. * Add tests. * Add tests. * Fix tests. * Add tests. * Add tests. * Add tests. * Add tests. * Add tests. * Add tests. * Add tests. * Add tests. * Add tests. * Add tests. * Add tests. * Add tests. * Add tests. * Add tests. * Add tests. * Add tests. * Add tests. * Add tests. * Format multiline conditions. * Add multiline formatting for VB. * Move code. * Simpler formilization of casts. * Extract out code. * Remove file. * Move files. * Share more code. * Share more code. * Break out types. * Share more code. * Add more tests. * Add VB tests. * Simplify. * Add comment. * Remove newlines. * Move method. * Move method. * Add comments. * Simplify * Update comment. * Update comment. * Remove line. * Update comment. * Update comment. * Update comment. * Fix comment. * Wrap long lines. * Wrap long lines. * Wrap long lines. * Handle trivia. * Simplify. * Fix check. * better support for else-if chains. * Add comments. * Remove 'Use Conditional Expressoin' * Remove more vestiges of feature. * Remove code. * Add back newline.

* move back to debug assert. realized why this was debug assert. if user kills OOP explicitly, connection can disconnect without us explicitly disposing it. especially for connection that kept alive (KeepAliveConnection). that is why this was debug assert. moving back to debug assert. * updated wording on assert

Now that System.Threading.Tasks.Extensions is referenced, the documentation can contain direct links to ValueTask<TResult>.

Changing some IDE tests from async void to Task

Fixing NullReferenceException inside ConvertToInterpolatedString

# Conflicts: # src/NuGet/Bootstrap.csproj # src/NuGet/BuildNuGets.csx

Don't try to create a XamlProject for a null hierarchy.

* Initial UseConditional work. * Initial UseConditional work. * Working replacement. * Extract common code. * Make 'var' work properly in the simplifier service. * Move types to their own files. * Provide a way to create types that are not simplified to 'var'. * Update test options. * Update test. * Move CSharp code style code down to the Workspace layer. * Rename config value. * Add ui options. * Add VB ui options. * Add VB support * Strip trivia * Initial stubs for 'use conditional for returns' * Add VB impl. * Only support processing of real trees. * Actually assign variable. * Don't assume a single variable. * Share more code. * Fix shared code. * Add check. * Simplify code. * Only the analyzer needs to check the severity. * Generalize loc strings. * remove static. * Remove unneeded methods. * Do cheap checks first. * Handle more cases. * Handle more cases. * Add test. * Add tests. * Add test. * Add tests. * Add tests. * Add tests. * Add tests. * Add tests. * Add tests. * Fix tests. * Add tests. * Add tests. * Add tests. * Add tests. * Add tests. * Add tests. * Add tests. * Add tests. * Add tests. * Add tests. * Add tests. * Add tests. * Add tests. * Add tests. * Add tests. * Add tests. * Add tests. * Add tests. * Format multiline conditions. * Add multiline formatting for VB. * Move code. * Simpler formilization of casts. * Extract out code. * Remove file. * Move files. * Share more code. * Share more code. * Break out types. * Share more code. * Add more tests. * Add VB tests. * Simplify. * Add comment. * Remove newlines. * Move method. * Move method. * Add comments. * Simplify * Update comment. * Update comment. * Remove line. * Update comment. * Update comment. * Update comment. * Fix comment. * Wrap long lines. * Wrap long lines. * Wrap long lines. * Handle trivia. * Simplify. * Fix check. * better support for else-if chains. * Add comments. * Remove 'Use Conditional Expressoin' * Remove more vestiges of feature. * Remove code. * Add back newline. * Remove helper. The simplifier will do the right thing now. * try to use var first, before removing casts. * Update tests.

Skipping GenerateMethodInClosedFile with recurring failures

Fix race condition in SolutionExplorer_InProc.OpenFile

…exts Make sure we always subscribe to shared hierarchy eventing

Need to thread through the official build value to ensure packages are built with the correct prerelease modifiers (beta, async, etc ...) instead of simply dev.

Build NuGet with correct prerelease tags

…lizer

VisualStudioRuleSetManager acts a single global cache for the contents of rule set files, and also offers eventing if the effective contents change. This was previously only being called on the UI thread everywhere, but it won't be much sooner. Now that we have ReferenceCountedDisposable, I also take advantage of that type to change how we do caching: previously, we would keep filling this cache until the solution close, and then we'd clear out everything at once. There are two things that aren't great about this pattern: 1. It's a small memory leak, at least up until solution close if you stopped using a rule set -- we'll keep holding onto it until we close everything. 2. It assumes that once solution close happens, all projects are indeed gone. This isn't a good assumption if we ever open up our project APIs and let anybody add things to VisualStudioWorkspace, since projects may then live past the solution close event.

Fixes #24652

Merge dev15.8-preview1 to master

Fixes #17045 by documenting the break

Fixes #4729

Fix Use Auto Property handling of VB's As New syntax

Completion for attributes: searching for attributes recursively

Update the entry for Microsoft.CodeAnalysis.EditorFeatures.Wpf.resources.dll to actually include the "resources" part of the file name.

Fixed incorrect suggestion for collection initialization simplification

Use SyntaxEditorBasedCodeFixProvider for 'qualify member access'

…nager Make VisualStudioRuleSetManager thread safe

CyrusNajmabadi · 2018-05-04T21:00:26Z

Tagging @jcouv . Just keeping this branch up to date. Finally got through the unicorn. Thanks!

CyrusNajmabadi · 2018-05-04T21:17:18Z

Hrmm... i'm getting:

14:09:57 D:\j\workspace\perf_correctn---5f8d76d8>.\build\scripts\cibuild.cmd -testPerfCorrectness 
14:09:57 Repo Dir D:\j\workspace\perf_correctn---5f8d76d8
14:09:57 Binaries Dir D:\j\workspace\perf_correctn---5f8d76d8\Binaries
14:09:57 Unsupported argument -testPerfCorrectness
14:09:57 Usage: build.ps1
14:09:57   -release

@jaredpar @agocke do you know what that's about?

…180502 Add resources to our NuGet packages

CyrusNajmabadi · 2018-05-04T22:02:00Z

@tmeschter did you mean to merge into thsi branch?

Neme12 · 2018-05-04T22:03:23Z

@CyrusNajmabadi I think the commits are updated live as master itself is updated.

CyrusNajmabadi · 2018-05-04T22:03:45Z

That is super cool.

Neme12 · 2018-05-04T22:04:44Z

did you mean to merge into thsi branch?

The branch you are merging from is master, so probably yes. I don't think there's any way to update this PR without updating master and vice versa.

CyrusNajmabadi · 2018-05-04T22:45:52Z

@jcouv can you merge this quickly before anything else goes into master :) It's really just a merge commit, so reviewwise, there's nothing much to so.

Neme12 · 2018-05-04T23:01:08Z

retest perf_correctness_prtest please

Neme12 · 2018-05-04T23:01:21Z

retest windows_release_vs-integration_prtest please

dpoeschl and others added 30 commits April 19, 2018 15:19

Handle completion items with leading/trailing decorative text

162e565

Leading/trailing decorative text can interfere with the pattern matcher's ability to find/bold matching spans and add redundant items to the MRU list.

Merge branch 'master' into abstractWithMethods

46fa7cd

Merge remote-tracking branch 'dotnet/master' into use-valuetask

7db8cea

Add a UseImplicitType refactoring

ec23381

Integrate after Cyrus's change

839e7fe

Factor common code out

549a46d

Rename test files

7cf21db

Reliably set focus using NavigateToLineAndColumn

ff77b97

Update PerformanceSensitiveAttribute documentation

247bf58

Now that System.Threading.Tasks.Extensions is referenced, the documentation can contain direct links to ValueTask<TResult>.

Merge pull request #26271 from Neme12/asyncVoidTests

226cc52

Changing some IDE tests from async void to Task

Merge branch 'master' of https://github.com/dotnet/roslyn

e4a4c54

Merge branch 'master' into testignore

e62088b

remove skip from CSharpToBasic

59c90e6

Merge pull request #25225 from Neme12/concatToInterpolatedString

8df7f5c

Fixing NullReferenceException inside ConvertToInterpolatedString

Merge branch 'openfile-race' of https://github.com/sharwell/roslyn

13f964d

# Conflicts: # src/NuGet/Bootstrap.csproj # src/NuGet/BuildNuGets.csx

Merge pull request #26129 from mgoertz-msft/dev15.7.x

f76e5ed

Don't try to create a XamlProject for a null hierarchy.

Merge pull request #26207 from jfleisher/testignore

58f8ed6

Skipping GenerateMethodInClosedFile with recurring failures

Merge pull request #26265 from sharwell/openfile-race

f076f79

Fix race condition in SolutionExplorer_InProc.OpenFile

Merge remote-tracking branch 'dotnet/master' into use-valuetask

bec2262

Move all our code over to using the new helper.

7de4218

Remove options and make methods synchronous.

933f886

Merge pull request #26215 from jasonmalinowski/fix-sharedproject-cont…

dba06e3

…exts Make sure we always subscribe to shared hierarchy eventing

Build NuGet with correct prerelease tags

b99313d

Need to thread through the official build value to ensure packages are built with the correct prerelease modifiers (beta, async, etc ...) instead of simply dev.

Fix simplifier for complex types.

1d868b6

Fix whitepsace.

38843ac

Merge pull request #26289 from jaredpar/fix-ver

36cb0c8

Build NuGet with correct prerelease tags

Fix issue where a write wasn't detected in make-readonly.

393ab41

sharwell and others added 13 commits May 3, 2018 18:21

Document the special treatment of AsNewClauseSyntax in GetFieldInitia…

1b5421c

…lizer

Document representation of boolean values (#26609)

814195c

Fixes #24652

Merge pull request #26615 from dotnet/merges/dev15.8-preview1-to-master

789f9a7

Merge dev15.8-preview1 to master

Document breaking change in C# 6 regarding indexed properties (#26604)

149494e

Fixes #17045 by documenting the break

Empty C# statement has no side-effects (#26603)

276fb8e

Fixes #4729

Merge pull request #26592 from sharwell/auto-property-as-new

250804a

Fix Use Auto Property handling of VB's As New syntax

Merge pull request #25622 from Neme12/attributeCompletion

84e1af7

Completion for attributes: searching for attributes recursively

Fix SignToolData.json

8faff93

Update the entry for Microsoft.CodeAnalysis.EditorFeatures.Wpf.resources.dll to actually include the "resources" part of the file name.

Use TempRoot.Root to put our stuff in the well-known place

024da90

Merge pull request #23721 from zaytsev-victor/Fixed23672

6a4acdb

Fixed incorrect suggestion for collection initialization simplification

Merge pull request #26611 from CyrusNajmabadi/useSyntaxEditor

c4eb9fd

Use SyntaxEditorBasedCodeFixProvider for 'qualify member access'

Merge pull request #26599 from jasonmalinowski/free-thread-ruleset-ma…

1e6e1ae

…nager Make VisualStudioRuleSetManager thread safe

CyrusNajmabadi requested review from a team as code owners May 4, 2018 21:00

jcouv self-assigned this May 4, 2018

etbyrd added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label May 4, 2018

Merge pull request #26593 from tmeschter/AddResourcesToNuGetPackages-…

990fbbb

…180502 Add resources to our NuGet packages

jcouv merged commit 1840c71 into features/embeddedJson May 4, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merging master into features/embeddedJson#26634

Merging master into features/embeddedJson#26634
jcouv merged 369 commits intofeatures/embeddedJsonfrom
master

CyrusNajmabadi commented May 4, 2018

Uh oh!

CyrusNajmabadi commented May 4, 2018

Uh oh!

CyrusNajmabadi commented May 4, 2018

Uh oh!

CyrusNajmabadi commented May 4, 2018

Uh oh!

Neme12 commented May 4, 2018

Uh oh!

CyrusNajmabadi commented May 4, 2018

Uh oh!

Neme12 commented May 4, 2018 •

edited

Loading

Uh oh!

CyrusNajmabadi commented May 4, 2018

Uh oh!

Neme12 commented May 4, 2018

Uh oh!

Neme12 commented May 4, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

CyrusNajmabadi commented May 4, 2018

Uh oh!

CyrusNajmabadi commented May 4, 2018

Uh oh!

CyrusNajmabadi commented May 4, 2018

Uh oh!

CyrusNajmabadi commented May 4, 2018

Uh oh!

Neme12 commented May 4, 2018

Uh oh!

CyrusNajmabadi commented May 4, 2018

Uh oh!

Neme12 commented May 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CyrusNajmabadi commented May 4, 2018

Uh oh!

Neme12 commented May 4, 2018

Uh oh!

Neme12 commented May 4, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Neme12 commented May 4, 2018 •

edited

Loading