Empty C# statement has no side-effects#26603
Merged
gafter merged 2 commits intodotnet:masterfrom May 4, 2018
Merged
Conversation
jcouv
approved these changes
May 3, 2018
cston
approved these changes
May 3, 2018
333fred
approved these changes
May 3, 2018
sharwell
approved these changes
May 3, 2018
| }"); | ||
| } | ||
|
|
||
| [Fact] |
Contributor
There was a problem hiding this comment.
💡 If you use a [Theory] here, you could actually write the test so the contents of each block is parameterized as a clean way to validate the code generated for "" and ";" is the same.
[Theory]
[InlineData("")]
[InlineData(";")]
public void NopInTryCatchFinally(string nopText)
Member
Author
There was a problem hiding this comment.
Hmmm, that's a great idea.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4729
@dotnet/roslyn-compiler May I please have a couple of reviews of this one-line bug fix?