Don't try to create a XamlProject for a null hierarchy.#26129
Merged
DustinCampbell merged 1 commit intodotnet:masterfrom Apr 20, 2018
Merged
Don't try to create a XamlProject for a null hierarchy.#26129DustinCampbell merged 1 commit intodotnet:masterfrom
DustinCampbell merged 1 commit intodotnet:masterfrom
Conversation
Member
|
@mgoertz-msft: this branch is now in escrow and will require divisional approval for changes. If that's a bar you're willing to go through, we can merge it. Otherwise retarget to master. |
Contributor
Author
|
@jasonmalinowski Master it is then. AFAIK, the symptom is just a null ref dialog popping up. |
DustinCampbell
approved these changes
Apr 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finally got around to submitting this. It has been reported via email for diffing scenarios in VS with XAML files under source code control. I can see how this could null ref but I have not been able to repro it. Fix is trivial - bail out if the IVsHierarchy for the text view is null so we don't attempt to create a XamlProject for a null hierarchy - which is why I have submitted it for dev15.7.x. But if that's too late I would be fine with moving it to 15.8 too.
Ask Mode template not completed
Customer scenario
What does the customer do to get into this situation, and why do we think this
is common enough to address for this release. (Granted, sometimes this will be
obvious "Open project, VS crashes" but in general, I need to understand how
common a scenario is)
Bugs this fixes
(either VSO or GitHub links)
Workarounds, if any
Also, why we think they are insufficient for RC vs. RC2, RC3, or RTW
Risk
This is generally a measure our how central the affected code is to adjacent
scenarios and thus how likely your fix is to destabilize a broader area of code
Performance impact
(with a brief justification for that assessment (e.g. "Low perf impact because no extra allocations/no complexity changes" vs. "Low")
Is this a regression from a previous update?
Root cause analysis
How did we miss it? What tests are we adding to guard against it in the future?
How was the bug found?
(E.g. customer reported it vs. ad hoc testing)
Test documentation updated?
If this is a new non-compiler feature or a significant improvement to an existing feature, update https://github.com/dotnet/roslyn/wiki/Manual-Testing once you know which release it is targeting.