Add resources to our NuGet packages#26593
Conversation
There was a problem hiding this comment.
Nit: is it better to keep these by the lines higher up so it's easier to see that each regular one has it's resources along with?
There was a problem hiding this comment.
It's a source only package -- should never have these.
There was a problem hiding this comment.
Oh yeah, meant to revert that one.
There was a problem hiding this comment.
Not strictly necessary, since in this case this package is really a reference-assembly only package -- we could technically put the binary asset into ref/ and it'd be fine. But this is fine if you prefer the consistency.
There was a problem hiding this comment.
In that case I'll just revert this file. There's no real point in including the satellite assemblies if we don't mean for this package to be used for redistribution.
5182a2e to
8d9e2c0
Compare
Now that we're producing satellite assemblies with localized resources directly out of the repo we can include them in our NuGet packages.
8d9e2c0 to
3a9f937
Compare
We don't really need resource assemblies in our VS compiler toolset insertion, so just ignore them rather than making Roslyn.BuildDevDivInsertionFiles.exe understand them properly.
68f7964 to
a6c76cc
Compare
Update the entry for Microsoft.CodeAnalysis.EditorFeatures.Wpf.resources.dll to actually include the "resources" part of the file name.
|
@jasonmalinowski @jaredpar I've had to make some changes to DevDivInsertionFiles; you may want to take a look again. |
jasonmalinowski
left a comment
There was a problem hiding this comment.
New changes still look good, but is there a reason to not include the localized versions in the Razzle toolset? I'd like to think as a global company people get benefit from that but maybe not?
| <file src="$thirdPartyNoticesPath$" target="" /> | ||
|
|
||
| <!-- Satellite assemblies --> | ||
| <file src="Dlls\CodeAnalysis\**\Microsoft.CodeAnalysis.resources.dll" target="lib\netstandard1.3" /> |
There was a problem hiding this comment.
**\ [](start = 33, length = 3)
Assume the directory structure signified by ** is preserved under the target directory?
|
@jasonmalinowski Right now the DevDivInsertionFiles tooling doesn't know how to expand the wildcards in signtool.json and the .nuspec files. So it can see that those files include .resource.dll files, but it can't actually find them on disk. We don't need to fix that (certainly not for the immediate purpose of getting the resource assemblies into the nuget packages) so I'd rather just avoid the issue. |
Now that we're producing satellite assemblies with localized resources
directly out of the repo we can include them in our NuGet packages.
Not all of these packages currently have satellite assemblies, but if they are added later we will pick them up.