Perf : ButtonContentTypeConverter now using InvariantCulture to parse… by jonathanantoine · Pull Request #25393 · dotnet/maui

jonathanantoine · 2024-10-19T15:53:52Z

While investigating performance issues in my Android app, I noticed that the ButtonContentTypeConverter was parsing a double without providing a Culture and that is leading to perf issue as described in this blog post.

Description of Change

Update ButtonContentTypeConverter to use CultureInfo.InvariantCulture when performing double.parse(xxx).

dotnet-policy-service · 2024-10-19T15:56:06Z

Hey there @jonathanantoine! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

jsuarezruiz · 2024-10-23T09:16:53Z

/rebase

MartyIX · 2024-10-23T09:24:42Z

While investigating performance issues in my Android app, I noticed that the ButtonContentTypeConverter was parsing a double without providing a Culture and that is leading to perf issue as described in this blog post.

Just curious: What impact do you see in your app?

jonathanantoine · 2024-10-23T20:09:20Z

While investigating performance issues in my Android app, I noticed that the ButtonContentTypeConverter was parsing a double without providing a Culture and that is leading to perf issue as described in this blog post.

Just curious: What impact do you see in your app?

A decrease in performance because it's costly to figure out the current culture the first time on Android. It can be 50 to 100ms on some device.

jsuarezruiz · 2024-10-28T08:10:08Z

/rebase

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* [Testing] Feature Matrix UITest Cases for CollectionView Dynamic changes (dotnet#29424) * Added FeatureTests for CollectionView * changes updated * changes updated * [create-pull-request] automated change (dotnet#29505) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * CA1416 warning fix * Added snapshots * Reverting files changes * Removed the old approach * Revert unwanted changes * Reverted unwanted changes * Reverted unwanted changes * Revert unwanted changes --------- Co-authored-by: NafeelaNazhir <nafeela.nazhirhussain@syncfusion.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Changed Syncfusion toolkit version from 1.0.4 to 1.0.5 (dotnet#29659) * [ci] Update dependencies from 9.0.4 to 9.0.5 (dotnet#29667) * [ci] Update dependencies from 9.0.4 to 9.0.5 * Update the net8 version * Add missing version MicrosoftJSInteropPackageVersion * Page.OnBackButtonPressed remove outdated API documentation (dotnet#29543) * Fixed KeepLastItemInView Does Not Scroll to Last Item When Adding Items at Top (dotnet#29632) * Fixed KeepLastItem not scrolled to last item * Updated Fix * Updated test sample * Added comment line * Updated test sample for iOS and mac * Added Snapshots for android and WinUI * Added UI tests. * Test sample changes. * script changes * script changes * Added snapshots * Resaved Mac images and the gradient image size issue has been fixed * CA1416 warning changes * Reverted unwanted changes --------- Co-authored-by: Paul Anderson <42271912+PaulAndersonS@users.noreply.github.com> Co-authored-by: Rui Marinho <me@ruimarinho.net> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> Co-authored-by: Dhivya-SF4094 <127717131+Dhivya-SF4094@users.noreply.github.com>

* fix added * Test added * snap added

…otnet#29637) * fix added * modified the fix * test case added * test case added * summary added * Script name changed

…net#29497) * [Android & iOS] Fix for character spacing in searchHandler * Updated test sample concerns * Update on naming * Update on formatting * Allowing updating character spacing to zero * Updated Andorid, iOS, Mac images

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

…tion Navigation (dotnet#29441) * fix-17521-Updates the SearchHandler when navigating to another page within same ShellSection. * fix-17521-Added testcase and added snapshot for Android and iOS. * fix-17521-Renamed Shell_Navigated to OnShellNavigated. * fix-17521-Modified the Location string value from "Ethopia" to "Ethiopia". * fix-17521-Snapshot updated. * fix-17521-Updated Windows and Mac Snapshot.

… at runtime (dotnet#29681) * Fix-view-position-shift-when-toggling-shadows * Added-Pending-SnapShots * Resaved-image

* Added sample to Matrix UITest Cases for Shadow * Renamed sample page * Renamed sample page * More tests * More tests * More tests * More tests * Added shadow tests * Updated sample * Added Windows snapshots * Updated tests * Added link to issue * More changes * Updated sample reset logic * Updated sample * More changes * More changes * More changes * Updated sample * Added snapshots * Hide cursor * More changes * More snapshots * Updated tests * Updated iOS snapshots * Updated iOS snapshots * Updated snapshots * Updated snapshots * Updated tests * [housekeeping] Automated PR to fix formatting errors on uitest-shadow-feature * Updated tests * Fix build errors * More changes * More changes * More changes * More changes --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

…net#28601) * SearchHandler ClearPlaceholderIcon color fix * Added Mac snapshot * Updated SearchBar Icon changes * Test script changes. * Revert unwanted changes * Updated custom icon changes

…ely on Application Launch in CV2 (dotnet#29316) * Update ItemsSourceFactory2.cs * Update CarouselViewPositionVisibility.xaml

…ouselView (dotnet#29660) * [Windows] Fix for ItemsSource Does Not Dynamically Set to null in CarouselView * Have added test case * Updated AutomationId for better clarity and readability * Have modified the context of the description label * Have committed the snapshots

* Added Label Feature tests * changes updated * changes updated * changes updated * Added Screenshots * Added Snapshots for iOS * Corrected Mistakes * Added snapshots * Added images * Renamed file --------- Co-authored-by: Rui Marinho <me@ruimarinho.net>

… 3 (dotnet#29702) * fix * dispose listner once not needed * Revert "dispose listner once not needed" * call invalidate * add device test to check for leaks * null check and remove strong references in callback * Throw if rootview is null before adding animation * fix spelling mistake

dotnet#29776) * Added tolerance parameter to the VerifyScreenshot method * More changes * Update src/Controls/tests/TestCases.Shared.Tests/UITest.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/Controls/tests/TestCases.Shared.Tests/UITest.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update Appium to the latest version * Removed deprecated logic * Update comment

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

For more information about inflight process check https://github.com/dotnet/maui/wiki/Inflight-Branch-Process

The base branch was changed.

… double

#25393) * [create-pull-request] automated change (#29793) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Convert HybridWebView.js to TypeScript and embed (#27183) * Fix up relevant CA1416 warnings - Set 3 (#26751) * [Testing] Feature Matrix UITest Cases for CollectionView Dynamic changes (#29424) * Added FeatureTests for CollectionView * changes updated * changes updated * [create-pull-request] automated change (#29505) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * CA1416 warning fix * Added snapshots * Reverting files changes * Removed the old approach * Revert unwanted changes * Reverted unwanted changes * Reverted unwanted changes * Revert unwanted changes --------- Co-authored-by: NafeelaNazhir <nafeela.nazhirhussain@syncfusion.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fix up relevant CA1416 warnings - Set 1 (#26696) * Changed Syncfusion toolkit version from 1.0.4 to 1.0.5 (#29659) * [ci] Update dependencies from 9.0.4 to 9.0.5 (#29667) * [ci] Update dependencies from 9.0.4 to 9.0.5 * Update the net8 version * Add missing version MicrosoftJSInteropPackageVersion * Page.OnBackButtonPressed remove outdated API documentation (#29543) * Fixed KeepLastItemInView Does Not Scroll to Last Item When Adding Items at Top (#29632) * Fixed KeepLastItem not scrolled to last item * Updated Fix * Updated test sample * Added comment line * Updated test sample for iOS and mac * Added Snapshots for android and WinUI * Added UI tests. * Test sample changes. * script changes * script changes * Added snapshots * Resaved Mac images and the gradient image size issue has been fixed * CA1416 warning changes * Reverted unwanted changes --------- Co-authored-by: Paul Anderson <42271912+PaulAndersonS@users.noreply.github.com> Co-authored-by: Rui Marinho <me@ruimarinho.net> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> Co-authored-by: Dhivya-SF4094 <127717131+Dhivya-SF4094@users.noreply.github.com> * [iOS/Mac]Fix StrokeDashArray Property not Rendering (#29670) * fix added * Test added * snap added * [Android/ iOS] Fix Flyout icon is displayed when flyout is disabled (#29637) * fix added * modified the fix * test case added * test case added * summary added * Script name changed * [Android & iOS] Fix for SearchHandler Character Spacing Property (#29497) * [Android & iOS] Fix for character spacing in searchHandler * Updated test sample concerns * Update on naming * Update on formatting * Allowing updating character spacing to zero * Updated Andorid, iOS, Mac images * [create-pull-request] automated change (#29724) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [Windows] Fix for SearchHandler Visibility Not Updating During In-Section Navigation (#29441) * fix-17521-Updates the SearchHandler when navigating to another page within same ShellSection. * fix-17521-Added testcase and added snapshot for Android and iOS. * fix-17521-Renamed Shell_Navigated to OnShellNavigated. * fix-17521-Modified the Location string value from "Ethopia" to "Ethiopia". * fix-17521-Snapshot updated. * fix-17521-Updated Windows and Mac Snapshot. * [Windows] - Fix view position shift when shadows are added or removed at runtime (#29681) * Fix-view-position-shift-when-toggling-shadows * Added-Pending-SnapShots * Resaved-image * [Testing] Feature Matrix UITest Cases for Shadows (#27701) * Added sample to Matrix UITest Cases for Shadow * Renamed sample page * Renamed sample page * More tests * More tests * More tests * More tests * Added shadow tests * Updated sample * Added Windows snapshots * Updated tests * Added link to issue * More changes * Updated sample reset logic * Updated sample * More changes * More changes * More changes * Updated sample * Added snapshots * Hide cursor * More changes * More snapshots * Updated tests * Updated iOS snapshots * Updated iOS snapshots * Updated snapshots * Updated snapshots * Updated tests * [housekeeping] Automated PR to fix formatting errors on uitest-shadow-feature * Updated tests * Fix build errors * More changes * More changes * More changes * More changes --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [iOS] Fixed Shell.SearchHandler ClearPlaceholderIcon Color Issue (#28601) * SearchHandler ClearPlaceholderIcon color fix * Added Mac snapshot * Updated SearchBar Icon changes * Test script changes. * Revert unwanted changes * Updated custom icon changes * Fix -[iOS] - CarouselView Throws ArgumentOutOfRangeException Immediately on Application Launch in CV2 (#29316) * Update ItemsSourceFactory2.cs * Update CarouselViewPositionVisibility.xaml * [Windows] Fix for ItemsSource Does Not Dynamically Set to null in CarouselView (#29660) * [Windows] Fix for ItemsSource Does Not Dynamically Set to null in CarouselView * Have added test case * Updated AutomationId for better clarity and readability * Have modified the context of the description label * Have committed the snapshots * [Testing] Feature Matrix UITest Cases for Label (#29690) * Added Label Feature tests * changes updated * changes updated * changes updated * Added Screenshots * Added Snapshots for iOS * Corrected Mistakes * Added snapshots * Added images * Renamed file --------- Co-authored-by: Rui Marinho <me@ruimarinho.net> * updated base images for candidate PR failures (#29766) * [Android] Fix: Modal Animation Repeats When Returning from Background 3 (#29702) * fix * dispose listner once not needed * Revert "dispose listner once not needed" * call invalidate * add device test to check for leaks * null check and remove strong references in callback * Throw if rootview is null before adding animation * fix spelling mistake * [Testing] Include a tolerance parameter in the Verifyscreenshot method (#29776) * Added tolerance parameter to the VerifyScreenshot method * More changes * Update src/Controls/tests/TestCases.Shared.Tests/UITest.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/Controls/tests/TestCases.Shared.Tests/UITest.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * [Testing] Update Appium to v8 (#29774) * Update Appium to the latest version * Removed deprecated logic * Update comment * [create-pull-request] automated change (#29831) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Perf : ButtonContentTypeConverter now using InvariantCulture to parse double --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Matthew Leibowitz <mattleibow@live.com> Co-authored-by: Tamilarasan Paranthaman <93904422+Tamilarasan-Paranthaman@users.noreply.github.com> Co-authored-by: NafeelaNazhir <nafeela.nazhirhussain@syncfusion.com> Co-authored-by: Paul Anderson <42271912+PaulAndersonS@users.noreply.github.com> Co-authored-by: Rui Marinho <me@ruimarinho.net> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> Co-authored-by: Dhivya-SF4094 <127717131+Dhivya-SF4094@users.noreply.github.com> Co-authored-by: devanathan-vaithiyanathan <114395405+devanathan-vaithiyanathan@users.noreply.github.com> Co-authored-by: Subhiksha Chandrasekaran <subhiksha.c@syncfusion.com> Co-authored-by: BagavathiPerumal <93652794+BagavathiPerumal@users.noreply.github.com> Co-authored-by: prakashKannanSf3972 <127308739+prakashKannanSf3972@users.noreply.github.com> Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> Co-authored-by: SuthiYuvaraj <92777079+SuthiYuvaraj@users.noreply.github.com> Co-authored-by: SyedAbdulAzeemSF4852 <syedabdulazeem.a@syncfusion.com> Co-authored-by: Anandhan Rajagopal <97146406+anandhan-rajagopal@users.noreply.github.com> Co-authored-by: Bhavanesh N <bhavanesh001@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Shane Neuville <shneuvil@microsoft.com>

@Shalini-Ashokan

For more information about inflight process check https://github.com/dotnet/maui/wiki/Inflight-Branch-Process # .NET MAUI Release Notes - inflight/candidate Branch ## MAUI Product Fixes * [iOS] Fix SwipeView programmatic open when background color is set by @Shalini-Ashokan in #29765 * [iOS] FormattedText with text color causes stack overflow - fix by @kubaflo in #29874 * [iOS] Fix AdaptiveTrigger not working as expected by @jsuarezruiz in #20987 * [iOS] Fix for Flyout title is not broken over multiple lines when you rotate your screen by @BagavathiPerumal in #29171 * [Windows] Fix for Assigning null to the SelectedItem of the CollectionView in the SelectionChanged event does not clear the selection by @SyedAbdulAzeemSF4852 in #29288 * Fix TapCoordinates method in Catalyst by @jsuarezruiz in #29775 * Fixed ItemSpacing on CarouselView resizes items [Android] by @Dhivya-SF4094 in #29796 * Perf : ButtonContentTypeConverter now using InvariantCulture to parse double by @antoine-jonathan in #25393 * ToolbarItem behavior with ImageSource iOS - fix by @kubaflo in #28833 * [Android] Fixed Button Shadow Color Transparency Not Applied Correctly by @NanthiniMahalingam in #29371 * Don't call NSAttributedString with HTML from a background thread by @kubaflo in #26153 * [Windows] Implemented the Resize and Downsize functions in the W2DImage class by @HarishwaranVijayakumar in #29138 * Templated indicator view - improvements by @kubaflo in #25642 * Update Issue25946.xaml by @anandhan-rajagopal in #30025 ## Testing * Fixed Test case failure in PR 26153 - iOS by @kubaflo in #29906 * Fixed Test case failure in PR 25642 - snapshots by @kubaflo in #29881 * [Testing] Feature Matrix UITest Cases for RadioButton by @TamilarasanSF4853 in #29744 * [Testing] Feature Matrix UITest Cases for CollectionView ItemsSource Feature by @LogishaSelvarajSF4525 in #29322 * [Testing] Feature Matrix UITest Cases for Stepper by @nivetha-nagalingam in #29731 * [Testing] Feature Matrix UITest Cases for CheckBox Control by @anandhan-rajagopal in #29739 * Update the comment for the test properties by @mattleibow in #27306 ## Dependency Updates * No changes in this category ## Docs * No changes in this category ## Housekeeping * [create-pull-request] automated change by @github-actions[bot] in #29875 * [create-pull-request] automated change by @github-actions[bot] in #29792 * [create-pull-request] automated change by @github-actions[bot] in #29760 **Full Changelog**: origin/main...origin/inflight/candidate

#25393) * [create-pull-request] automated change (#29793) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Convert HybridWebView.js to TypeScript and embed (#27183) * Fix up relevant CA1416 warnings - Set 3 (#26751) * [Testing] Feature Matrix UITest Cases for CollectionView Dynamic changes (#29424) * Added FeatureTests for CollectionView * changes updated * changes updated * [create-pull-request] automated change (#29505) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * CA1416 warning fix * Added snapshots * Reverting files changes * Removed the old approach * Revert unwanted changes * Reverted unwanted changes * Reverted unwanted changes * Revert unwanted changes --------- Co-authored-by: NafeelaNazhir <nafeela.nazhirhussain@syncfusion.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fix up relevant CA1416 warnings - Set 1 (#26696) * Changed Syncfusion toolkit version from 1.0.4 to 1.0.5 (#29659) * [ci] Update dependencies from 9.0.4 to 9.0.5 (#29667) * [ci] Update dependencies from 9.0.4 to 9.0.5 * Update the net8 version * Add missing version MicrosoftJSInteropPackageVersion * Page.OnBackButtonPressed remove outdated API documentation (#29543) * Fixed KeepLastItemInView Does Not Scroll to Last Item When Adding Items at Top (#29632) * Fixed KeepLastItem not scrolled to last item * Updated Fix * Updated test sample * Added comment line * Updated test sample for iOS and mac * Added Snapshots for android and WinUI * Added UI tests. * Test sample changes. * script changes * script changes * Added snapshots * Resaved Mac images and the gradient image size issue has been fixed * CA1416 warning changes * Reverted unwanted changes --------- Co-authored-by: Paul Anderson <42271912+PaulAndersonS@users.noreply.github.com> Co-authored-by: Rui Marinho <me@ruimarinho.net> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> Co-authored-by: Dhivya-SF4094 <127717131+Dhivya-SF4094@users.noreply.github.com> * [iOS/Mac]Fix StrokeDashArray Property not Rendering (#29670) * fix added * Test added * snap added * [Android/ iOS] Fix Flyout icon is displayed when flyout is disabled (#29637) * fix added * modified the fix * test case added * test case added * summary added * Script name changed * [Android & iOS] Fix for SearchHandler Character Spacing Property (#29497) * [Android & iOS] Fix for character spacing in searchHandler * Updated test sample concerns * Update on naming * Update on formatting * Allowing updating character spacing to zero * Updated Andorid, iOS, Mac images * [create-pull-request] automated change (#29724) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [Windows] Fix for SearchHandler Visibility Not Updating During In-Section Navigation (#29441) * fix-17521-Updates the SearchHandler when navigating to another page within same ShellSection. * fix-17521-Added testcase and added snapshot for Android and iOS. * fix-17521-Renamed Shell_Navigated to OnShellNavigated. * fix-17521-Modified the Location string value from "Ethopia" to "Ethiopia". * fix-17521-Snapshot updated. * fix-17521-Updated Windows and Mac Snapshot. * [Windows] - Fix view position shift when shadows are added or removed at runtime (#29681) * Fix-view-position-shift-when-toggling-shadows * Added-Pending-SnapShots * Resaved-image * [Testing] Feature Matrix UITest Cases for Shadows (#27701) * Added sample to Matrix UITest Cases for Shadow * Renamed sample page * Renamed sample page * More tests * More tests * More tests * More tests * Added shadow tests * Updated sample * Added Windows snapshots * Updated tests * Added link to issue * More changes * Updated sample reset logic * Updated sample * More changes * More changes * More changes * Updated sample * Added snapshots * Hide cursor * More changes * More snapshots * Updated tests * Updated iOS snapshots * Updated iOS snapshots * Updated snapshots * Updated snapshots * Updated tests * [housekeeping] Automated PR to fix formatting errors on uitest-shadow-feature * Updated tests * Fix build errors * More changes * More changes * More changes * More changes --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [iOS] Fixed Shell.SearchHandler ClearPlaceholderIcon Color Issue (#28601) * SearchHandler ClearPlaceholderIcon color fix * Added Mac snapshot * Updated SearchBar Icon changes * Test script changes. * Revert unwanted changes * Updated custom icon changes * Fix -[iOS] - CarouselView Throws ArgumentOutOfRangeException Immediately on Application Launch in CV2 (#29316) * Update ItemsSourceFactory2.cs * Update CarouselViewPositionVisibility.xaml * [Windows] Fix for ItemsSource Does Not Dynamically Set to null in CarouselView (#29660) * [Windows] Fix for ItemsSource Does Not Dynamically Set to null in CarouselView * Have added test case * Updated AutomationId for better clarity and readability * Have modified the context of the description label * Have committed the snapshots * [Testing] Feature Matrix UITest Cases for Label (#29690) * Added Label Feature tests * changes updated * changes updated * changes updated * Added Screenshots * Added Snapshots for iOS * Corrected Mistakes * Added snapshots * Added images * Renamed file --------- Co-authored-by: Rui Marinho <me@ruimarinho.net> * updated base images for candidate PR failures (#29766) * [Android] Fix: Modal Animation Repeats When Returning from Background 3 (#29702) * fix * dispose listner once not needed * Revert "dispose listner once not needed" * call invalidate * add device test to check for leaks * null check and remove strong references in callback * Throw if rootview is null before adding animation * fix spelling mistake * [Testing] Include a tolerance parameter in the Verifyscreenshot method (#29776) * Added tolerance parameter to the VerifyScreenshot method * More changes * Update src/Controls/tests/TestCases.Shared.Tests/UITest.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/Controls/tests/TestCases.Shared.Tests/UITest.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * [Testing] Update Appium to v8 (#29774) * Update Appium to the latest version * Removed deprecated logic * Update comment * [create-pull-request] automated change (#29831) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Perf : ButtonContentTypeConverter now using InvariantCulture to parse double --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Matthew Leibowitz <mattleibow@live.com> Co-authored-by: Tamilarasan Paranthaman <93904422+Tamilarasan-Paranthaman@users.noreply.github.com> Co-authored-by: NafeelaNazhir <nafeela.nazhirhussain@syncfusion.com> Co-authored-by: Paul Anderson <42271912+PaulAndersonS@users.noreply.github.com> Co-authored-by: Rui Marinho <me@ruimarinho.net> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> Co-authored-by: Dhivya-SF4094 <127717131+Dhivya-SF4094@users.noreply.github.com> Co-authored-by: devanathan-vaithiyanathan <114395405+devanathan-vaithiyanathan@users.noreply.github.com> Co-authored-by: Subhiksha Chandrasekaran <subhiksha.c@syncfusion.com> Co-authored-by: BagavathiPerumal <93652794+BagavathiPerumal@users.noreply.github.com> Co-authored-by: prakashKannanSf3972 <127308739+prakashKannanSf3972@users.noreply.github.com> Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> Co-authored-by: SuthiYuvaraj <92777079+SuthiYuvaraj@users.noreply.github.com> Co-authored-by: SyedAbdulAzeemSF4852 <syedabdulazeem.a@syncfusion.com> Co-authored-by: Anandhan Rajagopal <97146406+anandhan-rajagopal@users.noreply.github.com> Co-authored-by: Bhavanesh N <bhavanesh001@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Shane Neuville <shneuvil@microsoft.com>

jonathanantoine requested a review from a team as a code owner October 19, 2024 15:53

jonathanantoine requested review from StephaneDelcroix and rmarinho October 19, 2024 15:53

dotnet-policy-service bot added the community ✨ Community Contribution label Oct 19, 2024

jsuarezruiz added area-controls-button Button, ImageButton perf/general The issue affects performance (runtime speed, memory usage, startup time, etc.) (sub: perf) labels Oct 21, 2024

dotnet deleted a comment from azure-pipelines bot Oct 23, 2024

github-actions bot and others added 18 commits June 3, 2025 03:40

[create-pull-request] automated change (dotnet#29793)

f8e2404

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Convert HybridWebView.js to TypeScript and embed (dotnet#27183)

3c27291

[iOS/Mac]Fix StrokeDashArray Property not Rendering (dotnet#29670)

0aa43b2

* fix added * Test added * snap added

[Android/ iOS] Fix Flyout icon is displayed when flyout is disabled (d…

984889f

…otnet#29637) * fix added * modified the fix * test case added * test case added * summary added * Script name changed

[create-pull-request] automated change (dotnet#29724)

d57b54f

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

[Windows] - Fix view position shift when shadows are added or removed…

907d603

… at runtime (dotnet#29681) * Fix-view-position-shift-when-toggling-shadows * Added-Pending-SnapShots * Resaved-image

[iOS] Fixed Shell.SearchHandler ClearPlaceholderIcon Color Issue (dot…

39a6e48

…net#28601) * SearchHandler ClearPlaceholderIcon color fix * Added Mac snapshot * Updated SearchBar Icon changes * Test script changes. * Revert unwanted changes * Updated custom icon changes

Fix -[iOS] - CarouselView Throws ArgumentOutOfRangeException Immediat…

bb3bd7c

…ely on Application Launch in CV2 (dotnet#29316) * Update ItemsSourceFactory2.cs * Update CarouselViewPositionVisibility.xaml

updated base images for candidate PR failures (dotnet#29766)

4b537ae

jsuarezruiz and others added 3 commits June 4, 2025 11:22

[Testing] Update Appium to v8 (dotnet#29774)

9894e0f

* Update Appium to the latest version * Removed deprecated logic * Update comment

[create-pull-request] automated change (dotnet#29831)

cc8b096

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

[2025/06/02] Candidate - In Flight Branch (dotnet#29754)

b095e3d

For more information about inflight process check https://github.com/dotnet/maui/wiki/Inflight-Branch-Process

mattleibow previously approved these changes Jun 5, 2025

View reviewed changes

mattleibow changed the base branch from main to inflight/current June 5, 2025 22:41

mattleibow changed the base branch from inflight/current to main June 5, 2025 22:43

Perf : ButtonContentTypeConverter now using InvariantCulture to parse…

761dd6e

… double

mattleibow force-pushed the feature/ButtonContentLayoutConverter-parsing-using-culture branch from 5f3aee2 to 761dd6e Compare June 5, 2025 22:43

mattleibow approved these changes Jun 5, 2025

View reviewed changes

mattleibow changed the base branch from main to inflight/current June 5, 2025 22:44

mattleibow merged commit 98e46e1 into dotnet:inflight/current Jun 5, 2025
1 check passed

mattleibow mentioned this pull request Jun 5, 2025

Revert "Perf : ButtonContentTypeConverter now using InvariantCulture to parse…" #29845

Closed

PureWeen mentioned this pull request Jun 20, 2025

[2025/06/16] Candidate - In Flight Branch #29886

Merged

PureWeen added this to the .NET 9 SR9 milestone Jun 23, 2025

github-actions bot locked and limited conversation to collaborators Jul 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Perf : ButtonContentTypeConverter now using InvariantCulture to parse…#25393

Perf : ButtonContentTypeConverter now using InvariantCulture to parse…#25393
mattleibow merged 22 commits intodotnet:inflight/currentfrom
jonathanantoine:feature/ButtonContentLayoutConverter-parsing-using-culture

jonathanantoine commented Oct 19, 2024

Uh oh!

dotnet-policy-service bot commented Oct 19, 2024

Uh oh!

jsuarezruiz commented Oct 23, 2024

Uh oh!

MartyIX commented Oct 23, 2024

Uh oh!

jonathanantoine commented Oct 23, 2024

Uh oh!

jsuarezruiz commented Oct 28, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

Conversation

jonathanantoine commented Oct 19, 2024

Description of Change

Uh oh!

dotnet-policy-service bot commented Oct 19, 2024

Uh oh!

jsuarezruiz commented Oct 23, 2024

Uh oh!

MartyIX commented Oct 23, 2024

Uh oh!

jonathanantoine commented Oct 23, 2024

Uh oh!

jsuarezruiz commented Oct 28, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants