[Android/ iOS] Fix Flyout icon is displayed when flyout is disabled by devanathan-vaithiyanathan · Pull Request #29637 · dotnet/maui

devanathan-vaithiyanathan · 2025-05-23T10:18:38Z

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Issue Details

On iOS and Android, the flyout icon appears even when FlyoutBehavior is set to Disabled, but it does nothing when clicked. This behavior is inconsistent with Windows, where the icon is hidden.

Description of Change

Only set the FlyoutIcon when FlyoutBehavior is Flyout. This ensures the icon is hidden when the flyout is disabled or locked, matching expected behavior across all platforms.

Issues Fixed

Fixes #29615

Note: There is no existing Appium method to confirm the absence of the Flyout icon, so I have added a new method.

Tested the behavior in the following platforms.

Android
Windows
iOS
Mac

Output Screenshot

Before	After
iOS iOS-BeforeFix.mov	iOS iOS-AfterFix.mov
Android Android-BeforeFix.mov	Android Android-AfterFix.mov

dotnet-policy-service · 2025-05-23T10:18:56Z

Hey there @@devanathan-vaithiyanathan! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

Copilot

Pull Request Overview

This PR fixes the issue where the flyout icon is displayed on iOS and Android when the FlyoutBehavior is set to Disabled. It updates the platform-specific renderers to only set the flyout icon when the behavior is explicitly Flyout, adds a new UITest helper method to verify the icon’s absence, and provides corresponding test cases.

Updated UITest.Appium HelperExtensions to add WaitForNoFlyoutIcon.
Modified ShellPageRendererTracker (iOS) and ShellToolbarTracker (Android) to conditionally set the flyout icon.
Added tests in both TestCases.Shared.Tests and TestCases.HostApp to validate the behavior change.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/TestUtils/src/UITest.Appium/HelperExtensions.cs	Added a new method, WaitForNoFlyoutIcon, to verify that the flyout icon is absent.
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29615.cs	Introduced a new automated test for flyout icon disappearance when disabled.
src/Controls/tests/TestCases.HostApp/Issues/Issue29615.cs	Provided host app test implementation for the updated flyout behavior.
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs	Modified to only assign the flyout icon when FlyoutBehavior is Flyout.
src/Controls/src/Core/Compatibility/Handlers/Shell/Android/ShellToolbarTracker.cs	Adjusted to conditionally retrieve the flyout icon based on the current behavior.

Copilot · 2025-05-23T10:42:36Z

src/TestUtils/src/UITest.Appium/HelperExtensions.cs

+			}
+			else if (app is AppiumIOSApp || app is AppiumCatalystApp || app is AppiumWindowsApp)
+			{
+				if (isShell)


[nitpick] The use of the hardcoded string 'OK' for WaitForNoElement in Shell mode is unclear. Consider adding a comment or using a more descriptive automationId to clarify its intent.

jsuarezruiz · 2025-05-23T11:02:55Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-05-23T11:03:07Z

Azure Pipelines successfully started running 1 pipeline(s).

jsuarezruiz · 2025-05-26T06:37:51Z

src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs

 			{
-				image = _context.Shell.FlyoutIcon;
+				//Add the FlyoutIcon only if the FlyoutBehavior is Flyout
+				if (_flyoutBehavior == FlyoutBehavior.Flyout)


I see changes in Android and iOS but not in Windows, is missing or not necessary?

@jsuarezruiz , I observed that the issue is not reproduced on Windows. It appears to be already handled by the following logic.
Reference: MauiNavigationView.cs#L180
So, the changes are only necessary for Android and iOS platforms.

…29637) * fix added * modified the fix * test case added * test case added * summary added * Script name changed

#25393) * [create-pull-request] automated change (#29793) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Convert HybridWebView.js to TypeScript and embed (#27183) * Fix up relevant CA1416 warnings - Set 3 (#26751) * [Testing] Feature Matrix UITest Cases for CollectionView Dynamic changes (#29424) * Added FeatureTests for CollectionView * changes updated * changes updated * [create-pull-request] automated change (#29505) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * CA1416 warning fix * Added snapshots * Reverting files changes * Removed the old approach * Revert unwanted changes * Reverted unwanted changes * Reverted unwanted changes * Revert unwanted changes --------- Co-authored-by: NafeelaNazhir <nafeela.nazhirhussain@syncfusion.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fix up relevant CA1416 warnings - Set 1 (#26696) * Changed Syncfusion toolkit version from 1.0.4 to 1.0.5 (#29659) * [ci] Update dependencies from 9.0.4 to 9.0.5 (#29667) * [ci] Update dependencies from 9.0.4 to 9.0.5 * Update the net8 version * Add missing version MicrosoftJSInteropPackageVersion * Page.OnBackButtonPressed remove outdated API documentation (#29543) * Fixed KeepLastItemInView Does Not Scroll to Last Item When Adding Items at Top (#29632) * Fixed KeepLastItem not scrolled to last item * Updated Fix * Updated test sample * Added comment line * Updated test sample for iOS and mac * Added Snapshots for android and WinUI * Added UI tests. * Test sample changes. * script changes * script changes * Added snapshots * Resaved Mac images and the gradient image size issue has been fixed * CA1416 warning changes * Reverted unwanted changes --------- Co-authored-by: Paul Anderson <42271912+PaulAndersonS@users.noreply.github.com> Co-authored-by: Rui Marinho <me@ruimarinho.net> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> Co-authored-by: Dhivya-SF4094 <127717131+Dhivya-SF4094@users.noreply.github.com> * [iOS/Mac]Fix StrokeDashArray Property not Rendering (#29670) * fix added * Test added * snap added * [Android/ iOS] Fix Flyout icon is displayed when flyout is disabled (#29637) * fix added * modified the fix * test case added * test case added * summary added * Script name changed * [Android & iOS] Fix for SearchHandler Character Spacing Property (#29497) * [Android & iOS] Fix for character spacing in searchHandler * Updated test sample concerns * Update on naming * Update on formatting * Allowing updating character spacing to zero * Updated Andorid, iOS, Mac images * [create-pull-request] automated change (#29724) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [Windows] Fix for SearchHandler Visibility Not Updating During In-Section Navigation (#29441) * fix-17521-Updates the SearchHandler when navigating to another page within same ShellSection. * fix-17521-Added testcase and added snapshot for Android and iOS. * fix-17521-Renamed Shell_Navigated to OnShellNavigated. * fix-17521-Modified the Location string value from "Ethopia" to "Ethiopia". * fix-17521-Snapshot updated. * fix-17521-Updated Windows and Mac Snapshot. * [Windows] - Fix view position shift when shadows are added or removed at runtime (#29681) * Fix-view-position-shift-when-toggling-shadows * Added-Pending-SnapShots * Resaved-image * [Testing] Feature Matrix UITest Cases for Shadows (#27701) * Added sample to Matrix UITest Cases for Shadow * Renamed sample page * Renamed sample page * More tests * More tests * More tests * More tests * Added shadow tests * Updated sample * Added Windows snapshots * Updated tests * Added link to issue * More changes * Updated sample reset logic * Updated sample * More changes * More changes * More changes * Updated sample * Added snapshots * Hide cursor * More changes * More snapshots * Updated tests * Updated iOS snapshots * Updated iOS snapshots * Updated snapshots * Updated snapshots * Updated tests * [housekeeping] Automated PR to fix formatting errors on uitest-shadow-feature * Updated tests * Fix build errors * More changes * More changes * More changes * More changes --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [iOS] Fixed Shell.SearchHandler ClearPlaceholderIcon Color Issue (#28601) * SearchHandler ClearPlaceholderIcon color fix * Added Mac snapshot * Updated SearchBar Icon changes * Test script changes. * Revert unwanted changes * Updated custom icon changes * Fix -[iOS] - CarouselView Throws ArgumentOutOfRangeException Immediately on Application Launch in CV2 (#29316) * Update ItemsSourceFactory2.cs * Update CarouselViewPositionVisibility.xaml * [Windows] Fix for ItemsSource Does Not Dynamically Set to null in CarouselView (#29660) * [Windows] Fix for ItemsSource Does Not Dynamically Set to null in CarouselView * Have added test case * Updated AutomationId for better clarity and readability * Have modified the context of the description label * Have committed the snapshots * [Testing] Feature Matrix UITest Cases for Label (#29690) * Added Label Feature tests * changes updated * changes updated * changes updated * Added Screenshots * Added Snapshots for iOS * Corrected Mistakes * Added snapshots * Added images * Renamed file --------- Co-authored-by: Rui Marinho <me@ruimarinho.net> * updated base images for candidate PR failures (#29766) * [Android] Fix: Modal Animation Repeats When Returning from Background 3 (#29702) * fix * dispose listner once not needed * Revert "dispose listner once not needed" * call invalidate * add device test to check for leaks * null check and remove strong references in callback * Throw if rootview is null before adding animation * fix spelling mistake * [Testing] Include a tolerance parameter in the Verifyscreenshot method (#29776) * Added tolerance parameter to the VerifyScreenshot method * More changes * Update src/Controls/tests/TestCases.Shared.Tests/UITest.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/Controls/tests/TestCases.Shared.Tests/UITest.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * [Testing] Update Appium to v8 (#29774) * Update Appium to the latest version * Removed deprecated logic * Update comment * [create-pull-request] automated change (#29831) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Perf : ButtonContentTypeConverter now using InvariantCulture to parse double --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Matthew Leibowitz <mattleibow@live.com> Co-authored-by: Tamilarasan Paranthaman <93904422+Tamilarasan-Paranthaman@users.noreply.github.com> Co-authored-by: NafeelaNazhir <nafeela.nazhirhussain@syncfusion.com> Co-authored-by: Paul Anderson <42271912+PaulAndersonS@users.noreply.github.com> Co-authored-by: Rui Marinho <me@ruimarinho.net> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> Co-authored-by: Dhivya-SF4094 <127717131+Dhivya-SF4094@users.noreply.github.com> Co-authored-by: devanathan-vaithiyanathan <114395405+devanathan-vaithiyanathan@users.noreply.github.com> Co-authored-by: Subhiksha Chandrasekaran <subhiksha.c@syncfusion.com> Co-authored-by: BagavathiPerumal <93652794+BagavathiPerumal@users.noreply.github.com> Co-authored-by: prakashKannanSf3972 <127308739+prakashKannanSf3972@users.noreply.github.com> Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> Co-authored-by: SuthiYuvaraj <92777079+SuthiYuvaraj@users.noreply.github.com> Co-authored-by: SyedAbdulAzeemSF4852 <syedabdulazeem.a@syncfusion.com> Co-authored-by: Anandhan Rajagopal <97146406+anandhan-rajagopal@users.noreply.github.com> Co-authored-by: Bhavanesh N <bhavanesh001@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Shane Neuville <shneuvil@microsoft.com>

devanathan-vaithiyanathan added 5 commits May 22, 2025 13:14

fix added

dc0de88

modified the fix

0126fd6

test case added

e00eb08

test case added

eb568e3

summary added

0336746

dotnet-policy-service bot added the community ✨ Community Contribution label May 23, 2025

dotnet-policy-service bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label May 23, 2025

Script name changed

c5a139b

devanathan-vaithiyanathan marked this pull request as ready for review May 23, 2025 10:42

Copilot AI review requested due to automatic review settings May 23, 2025 10:42

devanathan-vaithiyanathan requested a review from a team as a code owner May 23, 2025 10:42

devanathan-vaithiyanathan requested review from StephaneDelcroix and tj-devel709 May 23, 2025 10:42

Copilot AI reviewed May 23, 2025

View reviewed changes

jsuarezruiz added platform/android area-controls-flyout Flyout labels May 26, 2025

jsuarezruiz reviewed May 26, 2025

View reviewed changes

jsuarezruiz approved these changes May 27, 2025

View reviewed changes

rmarinho changed the base branch from main to inflight/current May 28, 2025 18:29

rmarinho merged commit 1ba0829 into dotnet:inflight/current May 28, 2025
79 checks passed

github-actions bot pushed a commit that referenced this pull request May 30, 2025

[Android/ iOS] Fix Flyout icon is displayed when flyout is disabled (#…

9a4d149

…29637) * fix added * modified the fix * test case added * test case added * summary added * Script name changed

rmarinho pushed a commit that referenced this pull request May 30, 2025

[Android/ iOS] Fix Flyout icon is displayed when flyout is disabled (#…

ceda3bd

…29637) * fix added * modified the fix * test case added * test case added * summary added * Script name changed

PureWeen pushed a commit that referenced this pull request Jun 3, 2025

[Android/ iOS] Fix Flyout icon is displayed when flyout is disabled (#…

984889f

…29637) * fix added * modified the fix * test case added * test case added * summary added * Script name changed

github-actions bot locked and limited conversation to collaborators Jun 28, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Android/ iOS] Fix Flyout icon is displayed when flyout is disabled #29637

[Android/ iOS] Fix Flyout icon is displayed when flyout is disabled #29637
rmarinho merged 6 commits intodotnet:inflight/currentfrom
devanathan-vaithiyanathan:fix-29615

devanathan-vaithiyanathan commented May 23, 2025

Uh oh!

dotnet-policy-service bot commented May 23, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI May 23, 2025

Uh oh!

jsuarezruiz commented May 23, 2025

Uh oh!

azure-pipelines bot commented May 23, 2025

Uh oh!

jsuarezruiz May 26, 2025

Uh oh!

devanathan-vaithiyanathan May 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

devanathan-vaithiyanathan commented May 23, 2025

Issue Details

Description of Change

Issues Fixed

Output Screenshot

Uh oh!

dotnet-policy-service bot commented May 23, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI May 23, 2025

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz commented May 23, 2025

Uh oh!

azure-pipelines bot commented May 23, 2025

Uh oh!

jsuarezruiz May 26, 2025

Choose a reason for hiding this comment

Uh oh!

devanathan-vaithiyanathan May 26, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants