[iOS] Fix SwipeView programmatic open when background color is set.#29765
Merged
PureWeen merged 4 commits intodotnet:inflight/currentfrom Jun 9, 2025
Merged
[iOS] Fix SwipeView programmatic open when background color is set.#29765PureWeen merged 4 commits intodotnet:inflight/currentfrom
PureWeen merged 4 commits intodotnet:inflight/currentfrom
Conversation
Contributor
|
Hey there @@Shalini-Ashokan! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Contributor
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsuarezruiz
reviewed
Jun 2, 2025
| { | ||
| App.WaitForElement("OpenSwipeViewButton"); | ||
| App.Tap("OpenSwipeViewButton"); | ||
| VerifyScreenshot(); |
Contributor
There was a problem hiding this comment.
Pending snapshot on Mac and Windows. Running a build.
Contributor
Author
There was a problem hiding this comment.
@jsuarezruiz, I have updated the snapshot on macOS. On Windows, we have restricted the test because programmatically opening the SwipeView does not work.
Contributor
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsuarezruiz
reviewed
Jun 4, 2025
| UpdateOffset(swipeThreshold); | ||
|
|
||
| UpdateSwipeItems(); | ||
| // Set the background on the swipe view, we need to update the layout. |
Contributor
There was a problem hiding this comment.
Can you expand the comment with more details?
jsuarezruiz
approved these changes
Jun 9, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jun 10, 2025
…29765) * Fixed the issue and added the test case * Modified the test case * Modified the fix * Committed the image
github-actions bot
pushed a commit
that referenced
this pull request
Jun 10, 2025
…29765) * Fixed the issue and added the test case * Modified the test case * Modified the fix * Committed the image
github-actions bot
pushed a commit
that referenced
this pull request
Jun 11, 2025
…29765) * Fixed the issue and added the test case * Modified the test case * Modified the fix * Committed the image
github-actions bot
pushed a commit
that referenced
this pull request
Jun 11, 2025
…29765) * Fixed the issue and added the test case * Modified the test case * Modified the fix * Committed the image
github-actions bot
pushed a commit
that referenced
this pull request
Jun 16, 2025
…29765) * Fixed the issue and added the test case * Modified the test case * Modified the fix * Committed the image
github-actions bot
pushed a commit
that referenced
this pull request
Jun 16, 2025
…29765) * Fixed the issue and added the test case * Modified the test case * Modified the fix * Committed the image
github-actions bot
pushed a commit
that referenced
this pull request
Jun 19, 2025
…29765) * Fixed the issue and added the test case * Modified the test case * Modified the fix * Committed the image
PureWeen
added a commit
that referenced
this pull request
Jun 21, 2025
For more information about inflight process check https://github.com/dotnet/maui/wiki/Inflight-Branch-Process # .NET MAUI Release Notes - inflight/candidate Branch ## MAUI Product Fixes * [iOS] Fix SwipeView programmatic open when background color is set by @Shalini-Ashokan in #29765 * [iOS] FormattedText with text color causes stack overflow - fix by @kubaflo in #29874 * [iOS] Fix AdaptiveTrigger not working as expected by @jsuarezruiz in #20987 * [iOS] Fix for Flyout title is not broken over multiple lines when you rotate your screen by @BagavathiPerumal in #29171 * [Windows] Fix for Assigning null to the SelectedItem of the CollectionView in the SelectionChanged event does not clear the selection by @SyedAbdulAzeemSF4852 in #29288 * Fix TapCoordinates method in Catalyst by @jsuarezruiz in #29775 * Fixed ItemSpacing on CarouselView resizes items [Android] by @Dhivya-SF4094 in #29796 * Perf : ButtonContentTypeConverter now using InvariantCulture to parse double by @antoine-jonathan in #25393 * ToolbarItem behavior with ImageSource iOS - fix by @kubaflo in #28833 * [Android] Fixed Button Shadow Color Transparency Not Applied Correctly by @NanthiniMahalingam in #29371 * Don't call NSAttributedString with HTML from a background thread by @kubaflo in #26153 * [Windows] Implemented the Resize and Downsize functions in the W2DImage class by @HarishwaranVijayakumar in #29138 * Templated indicator view - improvements by @kubaflo in #25642 * Update Issue25946.xaml by @anandhan-rajagopal in #30025 ## Testing * Fixed Test case failure in PR 26153 - iOS by @kubaflo in #29906 * Fixed Test case failure in PR 25642 - snapshots by @kubaflo in #29881 * [Testing] Feature Matrix UITest Cases for RadioButton by @TamilarasanSF4853 in #29744 * [Testing] Feature Matrix UITest Cases for CollectionView ItemsSource Feature by @LogishaSelvarajSF4525 in #29322 * [Testing] Feature Matrix UITest Cases for Stepper by @nivetha-nagalingam in #29731 * [Testing] Feature Matrix UITest Cases for CheckBox Control by @anandhan-rajagopal in #29739 * Update the comment for the test properties by @mattleibow in #27306 ## Dependency Updates * No changes in this category ## Docs * No changes in this category ## Housekeeping * [create-pull-request] automated change by @github-actions[bot] in #29875 * [create-pull-request] automated change by @github-actions[bot] in #29792 * [create-pull-request] automated change by @github-actions[bot] in #29760 **Full Changelog**: origin/main...origin/inflight/candidate
rmarinho
pushed a commit
that referenced
this pull request
Jun 24, 2025
…29765) * Fixed the issue and added the test case * Modified the test case * Modified the fix * Committed the image
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Issue Details
In SwipeView, the Open method does not work properly when a background color is set on the SwipeView.
Root Cause
The swipe item is not visible because the layout arrangements are not properly aligned.
Description of Change
We update the content view's layout before the swipe animation begins, making the swipe items properly visible when opened programmatically.
Validated the behavior in the following platforms
Issues Fixed
Fixes #17204
Output ScreenShot
17204Before-fix.mov
17204-AfterFix.mov