Skip to content

Conversation

@VincentDondain
Copy link
Contributor

New commits in xamarin/maccore:

* xamarin/maccore@3064e2c463 [device-builds] Fix if condition typo (double `[`) (dotnet#1986)
* xamarin/maccore@e8bdf7a70f [tests] Treat Xcode GM as beta so we don't have to update all devices to GM (dotnet#1964) (dotnet#1973)

Diff: https://github.com/xamarin/maccore/compare/a86e78a3a1a7ea99b93e59f2fa60f384fca3bb32..3064e2c463e4700b20ce32ae4e522926ab622f8f
@VincentDondain VincentDondain added the pr-change-not-shipping The PR only touch files that are not shipped to customers label Sep 19, 2019
@monojenkins
Copy link
Collaborator

Build failure
Build succeeded
API Diff (from stable)
API Diff (from PR only) (no change)
Generator Diff (no change)
🔥 Test run failed 🔥

Test results

386 tests' device not found, 86 tests passed.

Copy link
Contributor

@spouliot spouliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Test run failed 🔥
^ should not happen

386 tests' device not found, 86 tests passed.
the device tests are normally not mentioned on the public PR and don't turn PR red

@rolfbjarne
Copy link
Member

the device tests are normally not mentioned on the public PR and don't turn PR red

That was a xcode11 merge failure, and was fixed in #7032 (or will be when that's merged to d16-3).

@VincentDondain VincentDondain added the requires-approval-before-merge The pull request requires special approval before it can be merged label Sep 19, 2019
@VincentDondain VincentDondain changed the title Bump maccore for device scheduling fix [d16-3] Bump maccore for device scheduling fix Sep 19, 2019
@VincentDondain VincentDondain added the not-notes-worthy Ignore for release notes label Sep 19, 2019
@chamons
Copy link
Contributor

chamons commented Sep 23, 2019

Approved for d16-3 as a test only fix (due to integration issues).

@VincentDondain VincentDondain merged commit 8e6e61b into dotnet:d16-3 Sep 23, 2019
@VincentDondain VincentDondain deleted the d16-3-device-tests-fix branch September 23, 2019 14:44
dalexsoto pushed a commit that referenced this pull request Oct 8, 2019
* [xharness] Fix incorrect merge. (#7033)

Add new device tasks to the right list so that they're processed and marked as
ignored correctly later.

* Bump maccore for device scheduling fix (#7029)

New commits in xamarin/maccore:

* xamarin/maccore@3064e2c463 [device-builds] Fix if condition typo (double `[`) (#1986)
* xamarin/maccore@e8bdf7a70f [tests] Treat Xcode GM as beta so we don't have to update all devices to GM (#1964) (#1973)

Diff: https://github.com/xamarin/maccore/compare/a86e78a3a1a7ea99b93e59f2fa60f384fca3bb32..3064e2c463e4700b20ce32ae4e522926ab622f8f

* Use Xcode 11 final (#7073)

It's the same hash as Xcode 11 GM 2 but it's cleaner to actually use `Xcode11.app`.

In addition: the device bots are looking for "GM" and "beta" in the Xcode name to run on either the stable or beta pool.

* [builds] Stop shipping the 32-bit AOT compiler for Xamarin.Mac. (#7042)

* [d16-3] Bump mono 2019-06@5608fe0a (#7126)

* [d16-3] Bump mono 2019-06@5608fe0a

New commits in mono/mono:

* mono/mono@5608fe0abb3 [2019-06] Update NETStandard 2.1 APIs (#17081)
* mono/mono@a5b8d6fcb5b [2019-06] Fix time zone issue when jumping into DST (#17062)
* mono/mono@390e6e124f5 Revert "[metadata] Fix leaks when handling a few attributes (#16675) (#16851)"
* mono/mono@459dd927dfd [2019-06] Bump bockbuild to get mono/bockbuild#121
* mono/mono@beb9a1b182a [sdks] Remove the mac32 build.
* mono/mono@747a919a06e [ci] Make ios/mac sdks archive URL more predictable
* mono/mono@114013096e1 [ci] Build iOS/Mac Mono sdks archive using Xcode 11
* mono/mono@10a24f3ea1d Implement WriteCore and ReadCore in DeflateStream
* mono/mono@a925846b1f0 [offsets-tool] Install clang into the user-specific python directory. (#16933)
* mono/mono@fe64a4765e6 [2019-06] Bump msbuild and sdk versions to 3.0.1xx latest (#16870)
* mono/mono@7293597b905 [corlib] Fix building nunit-lite twice (#16910)
* mono/mono@1648e886873 Rename bundle identifier for the various Mono.frameworks we create for Xamarin.iOS. Fixes #7005. (#16896)
* mono/mono@a6b5187d76a [metadata] Fix leaks when handling a few attributes (#16675) (#16851)
* mono/mono@7da9a041b3b [2019-06] Bump to mono/corefx@e79cf5b
* mono/mono@2b7050bdf36 [2019-06] Add RenamedEvent* to FSW sources from CoreFX (#16758)
* mono/mono@4f5ed502c6e [msbuild] pick up p4 versions
* mono/mono@f04ee2219d5 [2019-06][msbuid][roslyn] Bump msbuild and roslyn-binaries to pick up dotnet 3.0.100-p9 toolset
* mono/mono@6b4b99e571b Vtable [i] can be null so this should be check before use it. Fixes #16712

Diff: https://github.com/mono/mono/compare/7af64d1ebe9e9ee305cdae8ec5995c9521cbcf19..5608fe0abb3e501c461b2979a913c0bed3fe2a6d

* [tests] Adjust to non-fat macOS libraries from mono.

* [monotouch-test] Fix UrlProtocolTest after a server we don't control changed its output. Fixes xamarin/maccore#2006. (#7157)

microsoft.com is doing user agent sniffing, and broke our our test since their
output is now different. Switch to example.com instead.

Fixes xamarin/maccore#2006.
VincentDondain pushed a commit to VincentDondain/xamarin-macios that referenced this pull request Oct 16, 2019
* [xharness] Fix incorrect merge. (dotnet#7033)

Add new device tasks to the right list so that they're processed and marked as
ignored correctly later.

* Bump maccore for device scheduling fix (dotnet#7029)

New commits in xamarin/maccore:

* xamarin/maccore@3064e2c463 [device-builds] Fix if condition typo (double `[`) (dotnet#1986)
* xamarin/maccore@e8bdf7a70f [tests] Treat Xcode GM as beta so we don't have to update all devices to GM (dotnet#1964) (dotnet#1973)

Diff: https://github.com/xamarin/maccore/compare/a86e78a3a1a7ea99b93e59f2fa60f384fca3bb32..3064e2c463e4700b20ce32ae4e522926ab622f8f

* Use Xcode 11 final (dotnet#7073)

It's the same hash as Xcode 11 GM 2 but it's cleaner to actually use `Xcode11.app`.

In addition: the device bots are looking for "GM" and "beta" in the Xcode name to run on either the stable or beta pool.

* [builds] Stop shipping the 32-bit AOT compiler for Xamarin.Mac. (dotnet#7042)

* [d16-3] Bump mono 2019-06@5608fe0a (dotnet#7126)

* [d16-3] Bump mono 2019-06@5608fe0a

New commits in mono/mono:

* mono/mono@5608fe0abb3 [2019-06] Update NETStandard 2.1 APIs (dotnet#17081)
* mono/mono@a5b8d6fcb5b [2019-06] Fix time zone issue when jumping into DST (dotnet#17062)
* mono/mono@390e6e124f5 Revert "[metadata] Fix leaks when handling a few attributes (dotnet#16675) (dotnet#16851)"
* mono/mono@459dd927dfd [2019-06] Bump bockbuild to get mono/bockbuild#121
* mono/mono@beb9a1b182a [sdks] Remove the mac32 build.
* mono/mono@747a919a06e [ci] Make ios/mac sdks archive URL more predictable
* mono/mono@114013096e1 [ci] Build iOS/Mac Mono sdks archive using Xcode 11
* mono/mono@10a24f3ea1d Implement WriteCore and ReadCore in DeflateStream
* mono/mono@a925846b1f0 [offsets-tool] Install clang into the user-specific python directory. (dotnet#16933)
* mono/mono@fe64a4765e6 [2019-06] Bump msbuild and sdk versions to 3.0.1xx latest (dotnet#16870)
* mono/mono@7293597b905 [corlib] Fix building nunit-lite twice (dotnet#16910)
* mono/mono@1648e886873 Rename bundle identifier for the various Mono.frameworks we create for Xamarin.iOS. Fixes dotnet#7005. (dotnet#16896)
* mono/mono@a6b5187d76a [metadata] Fix leaks when handling a few attributes (dotnet#16675) (dotnet#16851)
* mono/mono@7da9a041b3b [2019-06] Bump to mono/corefx@e79cf5b
* mono/mono@2b7050bdf36 [2019-06] Add RenamedEvent* to FSW sources from CoreFX (dotnet#16758)
* mono/mono@4f5ed502c6e [msbuild] pick up p4 versions
* mono/mono@f04ee2219d5 [2019-06][msbuid][roslyn] Bump msbuild and roslyn-binaries to pick up dotnet 3.0.100-p9 toolset
* mono/mono@6b4b99e571b Vtable [i] can be null so this should be check before use it. Fixes dotnet#16712

Diff: https://github.com/mono/mono/compare/7af64d1ebe9e9ee305cdae8ec5995c9521cbcf19..5608fe0abb3e501c461b2979a913c0bed3fe2a6d

* [tests] Adjust to non-fat macOS libraries from mono.

* [monotouch-test] Fix UrlProtocolTest after a server we don't control changed its output. Fixes xamarin/maccore#2006. (dotnet#7157)

microsoft.com is doing user agent sniffing, and broke our our test since their
output is now different. Switch to example.com instead.

Fixes xamarin/maccore#2006.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not-notes-worthy Ignore for release notes pr-change-not-shipping The PR only touch files that are not shipped to customers requires-approval-before-merge The pull request requires special approval before it can be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants