[In Work] Add basic linker support to XM Full product library #1973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Right now we're deleting XM.dll during the mark step with: https://gist.github.com/chamons/d240e76190cee99a83cba06e1e43c2bf |
Contributor
Author
|
Ok, I think this is related to the hack here: https://gist.github.com/71cf19c2457ee98f996ebd625627b30e but without that we get: |
Collaborator
|
Build failure |
Collaborator
|
Build failure |
spouliot
suggested changes
Apr 10, 2017
|
|
||
| protected override TypeDefinition MarkType (TypeReference reference) | ||
| { | ||
| if (FullLimitedLinking && reference.Name != "Xamarin.Mac") |
Contributor
There was a problem hiding this comment.
that's not correct, let's talk :)
spouliot
added a commit
to spouliot/xamarin-macios
that referenced
this pull request
Apr 11, 2017
…embly on the full profile Replace dotnet#1973 expect that the test parts are still needed.
spouliot
added a commit
that referenced
this pull request
May 16, 2017
…embly on the full profile (#1990) Replace #1973 expect that the test parts are still needed. * Add XM SDK + LinkSkip test * [macos] Add platform linking support to msbuild * [macos] Add full SDK test * [macios] Diable classic from using linkplatform - Extended test infrastructure change to allow classic projects that include bundling - Setting linkplatform in MonoBundlingExtraArgs since we don't even read project setting LinkMode - Platform for classic
VincentDondain
added a commit
to VincentDondain/xamarin-macios
that referenced
this pull request
Sep 19, 2019
New commits in xamarin/maccore: * xamarin/maccore@3064e2c463 [device-builds] Fix if condition typo (double `[`) (dotnet#1986) * xamarin/maccore@e8bdf7a70f [tests] Treat Xcode GM as beta so we don't have to update all devices to GM (dotnet#1964) (dotnet#1973) Diff: https://github.com/xamarin/maccore/compare/a86e78a3a1a7ea99b93e59f2fa60f384fca3bb32..3064e2c463e4700b20ce32ae4e522926ab622f8f
VincentDondain
added a commit
to VincentDondain/xamarin-macios
that referenced
this pull request
Sep 19, 2019
New commits in xamarin/maccore: * xamarin/maccore@3064e2c463 [device-builds] Fix if condition typo (double `[`) (dotnet#1986) * xamarin/maccore@e8bdf7a70f [tests] Treat Xcode GM as beta so we don't have to update all devices to GM (dotnet#1964) (dotnet#1973) Diff: https://github.com/xamarin/maccore/compare/a86e78a3a1a7ea99b93e59f2fa60f384fca3bb32..3064e2c463e4700b20ce32ae4e522926ab622f8f
VincentDondain
added a commit
that referenced
this pull request
Sep 19, 2019
New commits in xamarin/maccore: * xamarin/maccore@3064e2c463 [device-builds] Fix if condition typo (double `[`) (#1986) * xamarin/maccore@e8bdf7a70f [tests] Treat Xcode GM as beta so we don't have to update all devices to GM (#1964) (#1973) Diff: https://github.com/xamarin/maccore/compare/a86e78a3a1a7ea99b93e59f2fa60f384fca3bb32..3064e2c463e4700b20ce32ae4e522926ab622f8f
VincentDondain
added a commit
that referenced
this pull request
Sep 23, 2019
New commits in xamarin/maccore: * xamarin/maccore@3064e2c463 [device-builds] Fix if condition typo (double `[`) (#1986) * xamarin/maccore@e8bdf7a70f [tests] Treat Xcode GM as beta so we don't have to update all devices to GM (#1964) (#1973) Diff: https://github.com/xamarin/maccore/compare/a86e78a3a1a7ea99b93e59f2fa60f384fca3bb32..3064e2c463e4700b20ce32ae4e522926ab622f8f
dalexsoto
pushed a commit
that referenced
this pull request
Oct 8, 2019
* [xharness] Fix incorrect merge. (#7033) Add new device tasks to the right list so that they're processed and marked as ignored correctly later. * Bump maccore for device scheduling fix (#7029) New commits in xamarin/maccore: * xamarin/maccore@3064e2c463 [device-builds] Fix if condition typo (double `[`) (#1986) * xamarin/maccore@e8bdf7a70f [tests] Treat Xcode GM as beta so we don't have to update all devices to GM (#1964) (#1973) Diff: https://github.com/xamarin/maccore/compare/a86e78a3a1a7ea99b93e59f2fa60f384fca3bb32..3064e2c463e4700b20ce32ae4e522926ab622f8f * Use Xcode 11 final (#7073) It's the same hash as Xcode 11 GM 2 but it's cleaner to actually use `Xcode11.app`. In addition: the device bots are looking for "GM" and "beta" in the Xcode name to run on either the stable or beta pool. * [builds] Stop shipping the 32-bit AOT compiler for Xamarin.Mac. (#7042) * [d16-3] Bump mono 2019-06@5608fe0a (#7126) * [d16-3] Bump mono 2019-06@5608fe0a New commits in mono/mono: * mono/mono@5608fe0abb3 [2019-06] Update NETStandard 2.1 APIs (#17081) * mono/mono@a5b8d6fcb5b [2019-06] Fix time zone issue when jumping into DST (#17062) * mono/mono@390e6e124f5 Revert "[metadata] Fix leaks when handling a few attributes (#16675) (#16851)" * mono/mono@459dd927dfd [2019-06] Bump bockbuild to get mono/bockbuild#121 * mono/mono@beb9a1b182a [sdks] Remove the mac32 build. * mono/mono@747a919a06e [ci] Make ios/mac sdks archive URL more predictable * mono/mono@114013096e1 [ci] Build iOS/Mac Mono sdks archive using Xcode 11 * mono/mono@10a24f3ea1d Implement WriteCore and ReadCore in DeflateStream * mono/mono@a925846b1f0 [offsets-tool] Install clang into the user-specific python directory. (#16933) * mono/mono@fe64a4765e6 [2019-06] Bump msbuild and sdk versions to 3.0.1xx latest (#16870) * mono/mono@7293597b905 [corlib] Fix building nunit-lite twice (#16910) * mono/mono@1648e886873 Rename bundle identifier for the various Mono.frameworks we create for Xamarin.iOS. Fixes #7005. (#16896) * mono/mono@a6b5187d76a [metadata] Fix leaks when handling a few attributes (#16675) (#16851) * mono/mono@7da9a041b3b [2019-06] Bump to mono/corefx@e79cf5b * mono/mono@2b7050bdf36 [2019-06] Add RenamedEvent* to FSW sources from CoreFX (#16758) * mono/mono@4f5ed502c6e [msbuild] pick up p4 versions * mono/mono@f04ee2219d5 [2019-06][msbuid][roslyn] Bump msbuild and roslyn-binaries to pick up dotnet 3.0.100-p9 toolset * mono/mono@6b4b99e571b Vtable [i] can be null so this should be check before use it. Fixes #16712 Diff: https://github.com/mono/mono/compare/7af64d1ebe9e9ee305cdae8ec5995c9521cbcf19..5608fe0abb3e501c461b2979a913c0bed3fe2a6d * [tests] Adjust to non-fat macOS libraries from mono. * [monotouch-test] Fix UrlProtocolTest after a server we don't control changed its output. Fixes xamarin/maccore#2006. (#7157) microsoft.com is doing user agent sniffing, and broke our our test since their output is now different. Switch to example.com instead. Fixes xamarin/maccore#2006.
VincentDondain
pushed a commit
to VincentDondain/xamarin-macios
that referenced
this pull request
Oct 16, 2019
* [xharness] Fix incorrect merge. (dotnet#7033) Add new device tasks to the right list so that they're processed and marked as ignored correctly later. * Bump maccore for device scheduling fix (dotnet#7029) New commits in xamarin/maccore: * xamarin/maccore@3064e2c463 [device-builds] Fix if condition typo (double `[`) (dotnet#1986) * xamarin/maccore@e8bdf7a70f [tests] Treat Xcode GM as beta so we don't have to update all devices to GM (dotnet#1964) (dotnet#1973) Diff: https://github.com/xamarin/maccore/compare/a86e78a3a1a7ea99b93e59f2fa60f384fca3bb32..3064e2c463e4700b20ce32ae4e522926ab622f8f * Use Xcode 11 final (dotnet#7073) It's the same hash as Xcode 11 GM 2 but it's cleaner to actually use `Xcode11.app`. In addition: the device bots are looking for "GM" and "beta" in the Xcode name to run on either the stable or beta pool. * [builds] Stop shipping the 32-bit AOT compiler for Xamarin.Mac. (dotnet#7042) * [d16-3] Bump mono 2019-06@5608fe0a (dotnet#7126) * [d16-3] Bump mono 2019-06@5608fe0a New commits in mono/mono: * mono/mono@5608fe0abb3 [2019-06] Update NETStandard 2.1 APIs (dotnet#17081) * mono/mono@a5b8d6fcb5b [2019-06] Fix time zone issue when jumping into DST (dotnet#17062) * mono/mono@390e6e124f5 Revert "[metadata] Fix leaks when handling a few attributes (dotnet#16675) (dotnet#16851)" * mono/mono@459dd927dfd [2019-06] Bump bockbuild to get mono/bockbuild#121 * mono/mono@beb9a1b182a [sdks] Remove the mac32 build. * mono/mono@747a919a06e [ci] Make ios/mac sdks archive URL more predictable * mono/mono@114013096e1 [ci] Build iOS/Mac Mono sdks archive using Xcode 11 * mono/mono@10a24f3ea1d Implement WriteCore and ReadCore in DeflateStream * mono/mono@a925846b1f0 [offsets-tool] Install clang into the user-specific python directory. (dotnet#16933) * mono/mono@fe64a4765e6 [2019-06] Bump msbuild and sdk versions to 3.0.1xx latest (dotnet#16870) * mono/mono@7293597b905 [corlib] Fix building nunit-lite twice (dotnet#16910) * mono/mono@1648e886873 Rename bundle identifier for the various Mono.frameworks we create for Xamarin.iOS. Fixes dotnet#7005. (dotnet#16896) * mono/mono@a6b5187d76a [metadata] Fix leaks when handling a few attributes (dotnet#16675) (dotnet#16851) * mono/mono@7da9a041b3b [2019-06] Bump to mono/corefx@e79cf5b * mono/mono@2b7050bdf36 [2019-06] Add RenamedEvent* to FSW sources from CoreFX (dotnet#16758) * mono/mono@4f5ed502c6e [msbuild] pick up p4 versions * mono/mono@f04ee2219d5 [2019-06][msbuid][roslyn] Bump msbuild and roslyn-binaries to pick up dotnet 3.0.100-p9 toolset * mono/mono@6b4b99e571b Vtable [i] can be null so this should be check before use it. Fixes dotnet#16712 Diff: https://github.com/mono/mono/compare/7af64d1ebe9e9ee305cdae8ec5995c9521cbcf19..5608fe0abb3e501c461b2979a913c0bed3fe2a6d * [tests] Adjust to non-fat macOS libraries from mono. * [monotouch-test] Fix UrlProtocolTest after a server we don't control changed its output. Fixes xamarin/maccore#2006. (dotnet#7157) microsoft.com is doing user agent sniffing, and broke our our test since their output is now different. Switch to example.com instead. Fixes xamarin/maccore#2006.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in progress.
You will need this applied to external/linker: https://gist.github.com/dca09b1bef4699bb5687b2da898d9e66
I am unsure how kosher any of this is yet. It's just hacking for now.