[metadata] Fix leaks when handling a few attributes (#16675) (#16851)

BrzVlad · web-flow · commit a6b5187d76ab · 2019-09-16T14:16:01.000+03:00
Callers of mono_reflection_create_custom_attr_data_args_noalloc were leaking some of the returned information. Accessed attributes are FixedBufferAttribute and UnmanagedFunctionPointerAttribute.
diff --git a/mono/metadata/marshal-ilgen.c b/mono/metadata/marshal-ilgen.c
@@ -182,6 +182,7 @@ get_fixed_buffer_attr (MonoClassField *field, MonoType **out_etype, int *out_len
 			return FALSE;
 		*out_etype = (MonoType*)typed_args [0];
 		*out_len = *(gint32*)typed_args [1];
+		g_free (typed_args [1]);
 		g_free (typed_args);
 		g_free (named_args);
 		g_free (arginfo);
diff --git a/mono/metadata/marshal.c b/mono/metadata/marshal.c
@@ -3907,7 +3907,9 @@ mono_marshal_get_managed_wrapper (MonoMethod *method, MonoClass *delegate_klass,
 				} else {
 					g_assert_not_reached ();
 				}
+				g_free (named_args [i]);
 			}
+			g_free (typed_args [0]);
 			g_free (typed_args);
 			g_free (named_args);
 			g_free (arginfo);

Original file line number	Diff line number	Diff line change
`@@ -3907,7 +3907,9 @@ mono_marshal_get_managed_wrapper (MonoMethod method, MonoClass delegate_klass,`
`3907`	`3907`	`} else {`
`3908`	`3908`	`g_assert_not_reached ();`
`3909`	`3909`	`}`
	`3910`	`+ g_free (named_args [i]);`
`3910`	`3911`	`}`
	`3912`	`+ g_free (typed_args [0]);`
`3911`	`3913`	`g_free (typed_args);`
`3912`	`3914`	`g_free (named_args);`
`3913`	`3915`	`g_free (arginfo);`