[tests] Allow a little bit of leeway when testing floating point numbers in SKTransformNodeTest. by rolfbjarne · Pull Request #18157 · dotnet/macios

rolfbjarne · 2023-04-27T09:50:54Z

Fixes this test failure:

MonoTouchFixtures.SpriteKit.SKTransformNodeTest
    [FAIL] EulerAngles :   #x1
        Expected: -2.14159298f
        But was:  -2.14159274f

…ers in SKTransformNodeTest. Fixes this test failure: MonoTouchFixtures.SpriteKit.SKTransformNodeTest [FAIL] EulerAngles : #x1 Expected: -2.14159298f But was: -2.14159274f

vs-mobiletools-engineering-service2 · 2023-04-27T11:21:29Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

~~iOS~~ (no change detected)
~~tvOS~~ (no change detected)
~~watchOS~~ (no change detected)
~~macOS~~ (no change detected)

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 05c4a37c4143dcfaa4f1c5478c74a80f8d032cc7 [PR build]

vs-mobiletools-engineering-service2 · 2023-04-27T11:22:05Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1030.Ventura
Hash: 05c4a37c4143dcfaa4f1c5478c74a80f8d032cc7 [PR build]

vs-mobiletools-engineering-service2 · 2023-04-27T11:26:46Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 05c4a37c4143dcfaa4f1c5478c74a80f8d032cc7 [PR build]

vs-mobiletools-engineering-service2 · 2023-04-27T11:31:04Z

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-04-27T11:33:46Z

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

monotouch-test

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-04-27T15:32:27Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 225 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 25 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 05c4a37c4143dcfaa4f1c5478c74a80f8d032cc7 [PR build]

rolfbjarne · 2023-04-27T15:55:42Z

Test failure is unrelated (#18159).

rolfbjarne · 2023-04-27T16:23:49Z

/sudo backport release/7.0.2xx-xcode14.3

vs-mobiletools-engineering-service2 · 2023-04-27T16:24:15Z

Backport Job to branch release/7.0.2xx-xcode14.3 Created! The magic is happening here

vs-mobiletools-engineering-service2 · 2023-04-27T16:26:06Z

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7694142 for more details.

rolfbjarne · 2023-04-27T16:28:40Z

/sudo backport release/7.0.2xx-xcode14.2

rolfbjarne · 2023-04-27T16:28:45Z

/sudo backport release/7.0.3xx

rolfbjarne · 2023-04-27T16:28:54Z

/sudo backport release/6.0.4xx-xcode14.2

rolfbjarne · 2023-04-27T16:28:57Z

/sudo backport release/6.0.4xx-xcode14.3

vs-mobiletools-engineering-service2 · 2023-04-27T16:29:04Z

Backport Job to branch release/7.0.3xx Created! The magic is happening here

vs-mobiletools-engineering-service2 · 2023-04-27T16:29:04Z

Backport Job to branch release/7.0.2xx-xcode14.2 Created! The magic is happening here

vs-mobiletools-engineering-service2 · 2023-04-27T16:29:18Z

Backport Job to branch release/6.0.4xx-xcode14.2 Created! The magic is happening here

vs-mobiletools-engineering-service2 · 2023-04-27T16:29:26Z

Backport Job to branch release/6.0.4xx-xcode14.3 Created! The magic is happening here

vs-mobiletools-engineering-service2 · 2023-04-27T16:31:05Z

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7694192 for more details.

vs-mobiletools-engineering-service2 · 2023-04-27T16:31:10Z

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7694190 for more details.

vs-mobiletools-engineering-service2 · 2023-04-27T16:31:20Z

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7694187 for more details.

rolfbjarne · 2023-04-27T16:36:21Z

/sudo backport release/7.0.2xx

vs-mobiletools-engineering-service2 · 2023-04-27T16:36:46Z

Backport Job to branch release/7.0.2xx Created! The magic is happening here

vs-mobiletools-engineering-service2 · 2023-04-27T16:38:19Z

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7694251 for more details.

… testing floating point numbers in SKTransformNodeTest. (#18168) Fixes this test failure: MonoTouchFixtures.SpriteKit.SKTransformNodeTest [FAIL] EulerAngles : #x1 Expected: -2.14159298f But was: -2.14159274f Backport of #18157 Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

… testing floating point numbers in SKTransformNodeTest. (#18169) Fixes this test failure: MonoTouchFixtures.SpriteKit.SKTransformNodeTest [FAIL] EulerAngles : #x1 Expected: -2.14159298f But was: -2.14159274f Backport of #18157 Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

… testing floating point numbers in SKTransformNodeTest. (#18165) Fixes this test failure: MonoTouchFixtures.SpriteKit.SKTransformNodeTest [FAIL] EulerAngles : #x1 Expected: -2.14159298f But was: -2.14159274f Backport of #18157 Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

…loating point numbers in SKTransformNodeTest. (#18170) Fixes this test failure: MonoTouchFixtures.SpriteKit.SKTransformNodeTest [FAIL] EulerAngles : #x1 Expected: -2.14159298f But was: -2.14159274f Backport of #18157 Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

…loating point numbers in SKTransformNodeTest. (#18173) Fixes this test failure: MonoTouchFixtures.SpriteKit.SKTransformNodeTest [FAIL] EulerAngles : #x1 Expected: -2.14159298f But was: -2.14159274f Backport of #18157 Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

rolfbjarne · 2023-04-28T09:14:53Z

/sudo backport release/8.0.1xx-preview4

vs-mobiletools-engineering-service2 · 2023-04-28T09:15:10Z

Backport Job to branch release/8.0.1xx-preview4 Created! The magic is happening here

vs-mobiletools-engineering-service2 · 2023-04-28T09:16:49Z

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7698555 for more details.

…testing floating point numbers in SKTransformNodeTest. (#18180) Fixes this test failure: MonoTouchFixtures.SpriteKit.SKTransformNodeTest [FAIL] EulerAngles : #x1 Expected: -2.14159298f But was: -2.14159274f Backport of #18157 Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

rolfbjarne · 2023-08-28T09:11:02Z

/sudo backport xcode14.3

vs-mobiletools-engineering-service2 · 2023-08-28T09:11:38Z

Backport Job to branch xcode14.3 Created! The magic is happening here

vs-mobiletools-engineering-service2 · 2023-08-28T09:13:26Z

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8317481 for more details.

…g point numbers in SKTransformNodeTest. (#18842) Fixes this test failure: MonoTouchFixtures.SpriteKit.SKTransformNodeTest [FAIL] EulerAngles : #x1 Expected: -2.14159298f But was: -2.14159274f Backport of #18157 Fixes xamarin/maccore#2701.

[tests] Allow a little bit of leeway when testing floating point numb…

05c4a37

…ers in SKTransformNodeTest. Fixes this test failure: MonoTouchFixtures.SpriteKit.SKTransformNodeTest [FAIL] EulerAngles : #x1 Expected: -2.14159298f But was: -2.14159274f

rolfbjarne mentioned this pull request Apr 27, 2023

[tests] Find a workaround for #xamarin/maccore@2668. #18159

Merged

haritha-mohan approved these changes Apr 27, 2023

View reviewed changes

rolfbjarne merged commit bdf25df into dotnet:main Apr 27, 2023

rolfbjarne deleted the tests-better-fp-comparison-sktransformnodetest branch April 27, 2023 15:55

vs-mobiletools-engineering-service2 mentioned this pull request Apr 27, 2023

[release/7.0.2xx-xcode14.3] [tests] Allow a little bit of leeway when testing floating point numbers in SKTransformNodeTest. #18165

Merged

vs-mobiletools-engineering-service2 mentioned this pull request Apr 27, 2023

[release/7.0.3xx] [tests] Allow a little bit of leeway when testing floating point numbers in SKTransformNodeTest. #18170

Merged

vs-mobiletools-engineering-service2 mentioned this pull request Apr 27, 2023

[release/7.0.2xx] [tests] Allow a little bit of leeway when testing floating point numbers in SKTransformNodeTest. #18173

Merged

vs-mobiletools-engineering-service2 mentioned this pull request Apr 28, 2023

[release/8.0.1xx-preview4] [tests] Allow a little bit of leeway when testing floating point numbers in SKTransformNodeTest. #18180

Merged

vs-mobiletools-engineering-service2 mentioned this pull request Aug 28, 2023

[xcode14.3] [tests] Allow a little bit of leeway when testing floating point numbers in SKTransformNodeTest. #18842

Merged

Conversation

rolfbjarne commented Apr 27, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 27, 2023

✅ API diff for current PR / commit

✅ API diff vs stable

✅ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 27, 2023

📚 [PR Build] Artifacts 📚

Packages generated

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 27, 2023

💻 [CI Build] Windows Integration Tests passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 27, 2023

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 27, 2023

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 27, 2023

🚀 [CI Build] Test results 🚀

Test results

Tests counts

Uh oh!

rolfbjarne commented Apr 27, 2023

Uh oh!

rolfbjarne commented Apr 27, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 27, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 27, 2023

Uh oh!

rolfbjarne commented Apr 27, 2023

Uh oh!

rolfbjarne commented Apr 27, 2023

Uh oh!

rolfbjarne commented Apr 27, 2023

Uh oh!

rolfbjarne commented Apr 27, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 27, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 27, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 27, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 27, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 27, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 27, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 27, 2023

Uh oh!

rolfbjarne commented Apr 27, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 27, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 27, 2023

Uh oh!

rolfbjarne commented Apr 28, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 28, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 28, 2023

Uh oh!

rolfbjarne commented Aug 28, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 28, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development