Skip to content

[release/7.0.2xx] [tests] Allow a little bit of leeway when testing floating point numbers in SKTransformNodeTest.#18173

Merged
rolfbjarne merged 1 commit intodotnet:release/7.0.2xxfrom
vs-mobiletools-engineering-service2:backport-pr-18157-to-release/7.0.2xx
Apr 28, 2023
Merged

[release/7.0.2xx] [tests] Allow a little bit of leeway when testing floating point numbers in SKTransformNodeTest.#18173
rolfbjarne merged 1 commit intodotnet:release/7.0.2xxfrom
vs-mobiletools-engineering-service2:backport-pr-18157-to-release/7.0.2xx

Conversation

@vs-mobiletools-engineering-service2
Copy link
Collaborator

@vs-mobiletools-engineering-service2 vs-mobiletools-engineering-service2 commented Apr 27, 2023

Fixes this test failure:

MonoTouchFixtures.SpriteKit.SKTransformNodeTest
    [FAIL] EulerAngles :   #x1
        Expected: -2.14159298f
        But was:  -2.14159274f

Backport of #18157

@rolfbjarne
[tests] Allow a little bit of leeway when testing floating point numb…
be161e9 
…ers in SKTransformNodeTest.

Fixes this test failure:

    MonoTouchFixtures.SpriteKit.SKTransformNodeTest
        [FAIL] EulerAngles :   #x1
            Expected: -2.14159298f
            But was:  -2.14159274f
@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

vs-mobiletools-engineering-service2 commented Apr 27, 2023

✅ API diff for current PR / commit

NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

.NET (No breaking changes)
  • iOS: vsdrops gist (No breaking changes)
  • tvOS: (empty diff detected)
  • MacCatalyst: vsdrops gist (No breaking changes)
  • macOS: vsdrops gist (No breaking changes)
  • Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops (could not create gist: file 'D:\a\1\s\change-detection\results\stable-api-comparison\diff\dotnet\iOS-MacCatalyst-diff\Microsoft.iOS.Ref\ref\net7.0\Microsoft.iOS.MacCatalyst.md' does not exist)

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: be161e90cf5ed949c6214d1c7909e2495ee36939 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

vs-mobiletools-engineering-service2 commented Apr 27, 2023

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

  • monotouch-test

Pipeline on Agent
Hash: be161e90cf5ed949c6214d1c7909e2495ee36939 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

vs-mobiletools-engineering-service2 commented Apr 27, 2023

❌ [PR Build] Tests on macOS M1 - Mac Ventura (13.0) failed ❌

Failed tests are:

  • monotouch-test

Pipeline on Agent
Hash: be161e90cf5ed949c6214d1c7909e2495ee36939 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

vs-mobiletools-engineering-service2 commented Apr 27, 2023

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1167.Ventura
Hash: be161e90cf5ed949c6214d1c7909e2495ee36939 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

vs-mobiletools-engineering-service2 commented Apr 27, 2023

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 1 tests failed, 76 tests passed.

Failures

❌ monotouch tests

1 tests failed, 10 tests passed.
Details
  • monotouch-test/Mac Catalyst [dotnet]/Debug [dotnet]: TimedOut (Execution timed out after 1200 seconds.
    Test run crashed)

Html Report (VSDrops) Download

Successes

⚠️ bcl: No tests selected. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ framework: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 1 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 4 tests passed. Html Report (VSDrops) Download
⚠️ install_source: No tests selected. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 40 tests passed. Html Report (VSDrops) Download
⚠️ mac_binding_project: No tests selected. Html Report (VSDrops) Download
⚠️ mmp: No tests selected. Html Report (VSDrops) Download
⚠️ mononative: No tests selected. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
⚠️ mtouch: No tests selected. Html Report (VSDrops) Download
⚠️ xammac: No tests selected. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

@rolfbjarne
Copy link
Member

rolfbjarne commented Apr 28, 2023

Test failure is unrelated (#18121).

@rolfbjarne rolfbjarne merged commit bfea84b into dotnet:release/7.0.2xx Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

Assignees

No one assigned

Labels

backported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vs-mobiletools-engineering-service2 @rolfbjarne @dalexsoto