[runtime] Always look for dynamic libraries relative to the root directory first. Fixes #xamarin/maccore@2668. by rolfbjarne · Pull Request #18121 · dotnet/macios

rolfbjarne · 2023-04-24T13:36:28Z

Fixes https://github.com/xamarin/maccore/issues/2668.

…ctory first. Fixes #xamarin/maccore@2668. Fixes xamarin/maccore#2668.

vs-mobiletools-engineering-service2 · 2023-04-24T15:13:10Z

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-04-24T15:15:36Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

~~iOS~~ (no change detected)
~~tvOS~~ (no change detected)
~~watchOS~~ (no change detected)
~~macOS~~ (no change detected)

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 41f57529c8a63501fa1781ec3107c34ffe745940 [PR build]

vs-mobiletools-engineering-service2 · 2023-04-24T15:19:38Z

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

monotouch-test

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-04-24T15:29:29Z

❌ [CI Build] Windows Integration Tests failed ❌

❌ SucceededWithIssues ❌

Pipeline on Agent
Hash: 41f57529c8a63501fa1781ec3107c34ffe745940 [PR build]

vs-mobiletools-engineering-service2 · 2023-04-24T15:40:58Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1030.Ventura
Hash: 41f57529c8a63501fa1781ec3107c34ffe745940 [PR build]

vs-mobiletools-engineering-service2 · 2023-04-25T07:14:46Z

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

monotouch-test

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-04-25T07:41:12Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 225 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 25 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 41f57529c8a63501fa1781ec3107c34ffe745940 [PR build]

rolfbjarne · 2023-04-25T08:22:56Z

/sudo backport release/7.0.2xx-xcode14.2

rolfbjarne · 2023-04-25T08:23:00Z

/sudo backport release/7.0.2xx-xcode14.3

rolfbjarne · 2023-04-25T08:23:05Z

/sudo backport release/7.0.3xx

vs-mobiletools-engineering-service2 · 2023-04-25T08:23:13Z

Backport Job to branch release/7.0.2xx-xcode14.2 Created! The magic is happening here

vs-mobiletools-engineering-service2 · 2023-04-25T08:23:16Z

Backport Job to branch release/7.0.2xx-xcode14.3 Created! The magic is happening here

rolfbjarne · 2023-04-25T08:23:16Z

/sudo backport release/6.0.4xx-xcode14.2

rolfbjarne · 2023-04-25T08:23:20Z

/sudo backport release/6.0.4xx-xcode14.3

vs-mobiletools-engineering-service2 · 2023-04-25T08:23:27Z

Backport Job to branch release/7.0.3xx Created! The magic is happening here

vs-mobiletools-engineering-service2 · 2023-04-25T08:23:33Z

Backport Job to branch release/6.0.4xx-xcode14.2 Created! The magic is happening here

vs-mobiletools-engineering-service2 · 2023-04-25T08:23:38Z

Backport Job to branch release/6.0.4xx-xcode14.3 Created! The magic is happening here

vs-mobiletools-engineering-service2 · 2023-04-25T08:24:55Z

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7678672 for more details.

vs-mobiletools-engineering-service2 · 2023-04-25T08:25:21Z

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7678676 for more details.

vs-mobiletools-engineering-service2 · 2023-04-25T08:25:28Z

Oh no! Backport failed! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7678679 for more details.

vs-mobiletools-engineering-service2 · 2023-04-25T08:25:29Z

Oh no! Backport failed! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7678682 for more details.

…es relative to the root directory first. Fixes #xamarin/maccore@2668. (#18131) Fixes xamarin/maccore#2668. Backport of #18121 Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

…e to the root directory first. Fixes #xamarin/maccore@2668. (#18132) Fixes xamarin/maccore#2668. Backport of #18121 Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

…es relative to the root directory first. Fixes #xamarin/maccore@2668. (#18133) Fixes xamarin/maccore#2668. Backport of #18121.

…es relative to the root directory first. Fixes #xamarin/maccore@2668. (#18134) Fixes xamarin/maccore#2668. Backport of #18121.

rolfbjarne · 2023-04-28T08:55:38Z

/sudo backport release/7.0.2xx

vs-mobiletools-engineering-service2 · 2023-04-28T08:56:00Z

Backport Job to branch release/7.0.2xx Created! The magic is happening here

vs-mobiletools-engineering-service2 · 2023-04-28T08:57:38Z

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7698492 for more details.

…e to the root directory first. Fixes #xamarin/maccore@2668. (#18177) Fixes xamarin/maccore#2668. Backport of #18121 Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

[runtime] Always look for dynamic libraries relative to the root dire…

41f5752

…ctory first. Fixes #xamarin/maccore@2668. Fixes xamarin/maccore#2668.

This comment has been minimized.

Sign in to view

tj-devel709 approved these changes Apr 24, 2023

View reviewed changes

haritha-mohan approved these changes Apr 25, 2023

View reviewed changes

rolfbjarne merged commit edd9881 into dotnet:main Apr 25, 2023

rolfbjarne deleted the maccore-issue-2668 branch April 25, 2023 08:22

vs-mobiletools-engineering-service2 mentioned this pull request Apr 25, 2023

[release/7.0.2xx-xcode14.3] [runtime] Always look for dynamic libraries relative to the root directory first. Fixes #xamarin/maccore@2668. #18131

Merged

vs-mobiletools-engineering-service2 mentioned this pull request Apr 25, 2023

[release/7.0.3xx] [runtime] Always look for dynamic libraries relative to the root directory first. Fixes #xamarin/maccore@2668. #18132

Merged

rolfbjarne added a commit that referenced this pull request Apr 27, 2023

[release/6.0.4xx-xcode14.3] [runtime] Always look for dynamic librari…

0390600

…es relative to the root directory first. Fixes #xamarin/maccore@2668. (#18133) Fixes xamarin/maccore#2668. Backport of #18121.

rolfbjarne added a commit that referenced this pull request Apr 27, 2023

[release/6.0.4xx-xcode14.2] [runtime] Always look for dynamic librari…

404f5a8

…es relative to the root directory first. Fixes #xamarin/maccore@2668. (#18134) Fixes xamarin/maccore#2668. Backport of #18121.

rolfbjarne mentioned this pull request Apr 28, 2023

[release/7.0.2xx] [tests] Allow a little bit of leeway when testing floating point numbers in SKTransformNodeTest. #18173

Merged

vs-mobiletools-engineering-service2 mentioned this pull request Apr 28, 2023

[release/7.0.2xx] [runtime] Always look for dynamic libraries relative to the root directory first. Fixes #xamarin/maccore@2668. #18177

Merged

Conversation

rolfbjarne commented Apr 24, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 24, 2023

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 24, 2023

✅ API diff for current PR / commit

✅ API diff vs stable

✅ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 24, 2023

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 24, 2023

❌ [CI Build] Windows Integration Tests failed ❌

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 24, 2023

📚 [PR Build] Artifacts 📚

Packages generated

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Apr 25, 2023

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 25, 2023

🚀 [CI Build] Test results 🚀

Test results

Tests counts

Uh oh!

rolfbjarne commented Apr 25, 2023

Uh oh!

rolfbjarne commented Apr 25, 2023

Uh oh!

rolfbjarne commented Apr 25, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 25, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 25, 2023

Uh oh!

rolfbjarne commented Apr 25, 2023

Uh oh!

rolfbjarne commented Apr 25, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 25, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 25, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 25, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 25, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 25, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 25, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 25, 2023

Uh oh!

rolfbjarne commented Apr 28, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 28, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants