Skip to content

[xcode14.3] [tests] Allow a little bit of leeway when testing floating point numbers in SKTransformNodeTest.#18842

Merged
rolfbjarne merged 1 commit intodotnet:xcode14.3from
vs-mobiletools-engineering-service2:backport-pr-18157-to-xcode14.3
Aug 29, 2023
Merged

[xcode14.3] [tests] Allow a little bit of leeway when testing floating point numbers in SKTransformNodeTest.#18842
rolfbjarne merged 1 commit intodotnet:xcode14.3from
vs-mobiletools-engineering-service2:backport-pr-18157-to-xcode14.3

Conversation

@vs-mobiletools-engineering-service2
Copy link
Collaborator

@vs-mobiletools-engineering-service2 vs-mobiletools-engineering-service2 commented Aug 28, 2023 •
edited by rolfbjarne
Loading

Fixes this test failure:

MonoTouchFixtures.SpriteKit.SKTransformNodeTest
    [FAIL] EulerAngles :   #x1
        Expected: -2.14159298f
        But was:  -2.14159274f

Backport of #18157

Fixes https://github.com/xamarin/maccore/issues/2701.

@rolfbjarne
[tests] Allow a little bit of leeway when testing floating point numb…
2cdc0cc 
…ers in SKTransformNodeTest.

Fixes this test failure:

    MonoTouchFixtures.SpriteKit.SKTransformNodeTest
        [FAIL] EulerAngles :   #x1
            Expected: -2.14159298f
            But was:  -2.14159274f
@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

vs-mobiletools-engineering-service2 commented Aug 28, 2023

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 2cdc0cc1696804dd29f5cf648a890ecd89cab63a [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

vs-mobiletools-engineering-service2 commented Aug 28, 2023

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 2cdc0cc1696804dd29f5cf648a890ecd89cab63a [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

vs-mobiletools-engineering-service2 commented Aug 28, 2023

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent xambot-1199.Ventura
Hash: 2cdc0cc1696804dd29f5cf648a890ecd89cab63a [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

vs-mobiletools-engineering-service2 commented Aug 28, 2023

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: 2cdc0cc1696804dd29f5cf648a890ecd89cab63a [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

vs-mobiletools-engineering-service2 commented Aug 28, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: 2cdc0cc1696804dd29f5cf648a890ecd89cab63a [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

vs-mobiletools-engineering-service2 commented Aug 28, 2023

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 1 tests failed, 149 tests passed.

Failures

❌ dotnettests tests [attempt 2]

1 tests failed, 0 tests passed.
Details
  • DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 3 tests passed. Html Report (VSDrops) Download
✅ framework: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 1 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 3 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 25 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 12 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 2cdc0cc1696804dd29f5cf648a890ecd89cab63a [PR build]

@rolfbjarne
Copy link
Member

rolfbjarne commented Aug 29, 2023

Test failure are unrelated (https://github.com/xamarin/maccore/issues/2567, https://github.com/xamarin/maccore/issues/2688).

@rolfbjarne rolfbjarne merged commit 36a6c18 into dotnet:xcode14.3 Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

+1 more reviewer

@mandel-macaque mandel-macaque mandel-macaque approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vs-mobiletools-engineering-service2 @rolfbjarne @dalexsoto @mandel-macaque