Skip to content

[main] Source code updates from dotnet/runtime#3175

Closed
dotnet-maestro[bot] wants to merge 8 commits intomainfrom
darc-main-8a551d19-67bf-4ce9-b5e3-2be5f6e400b8
Closed

[main] Source code updates from dotnet/runtime#3175
dotnet-maestro[bot] wants to merge 8 commits intomainfrom
darc-main-8a551d19-67bf-4ce9-b5e3-2be5f6e400b8

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Oct 31, 2025 •
edited
Loading

Note

This is a codeflow update. It may contain both source code changes from the source repo as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/runtime

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Oct 31, 2025

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/product-construction for assistance.

@dotnet-policy-service dotnet-policy-service bot requested a review from a team October 31, 2025 02:11
@am11
Copy link
Member

am11 commented Oct 31, 2025

@kotlarmilos, does it ring a bell:

##[error]src/runtime/artifacts/bin/Crossgen2Tasks/Release/net10.0/Microsoft.NET.CrossGen.targets(467,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Error: iOSSimulator
  /Users/runner/work/1/s/src/runtime/artifacts/bin/Crossgen2Tasks/Release/net10.0/Microsoft.NET.CrossGen.targets(467,5): error : Error: iOSSimulator [/Users/runner/work/1/s/src/runtime/src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Runtime.CoreCLR.sfxproj]
##[error]src/runtime/artifacts/bin/Crossgen2Tasks/Release/net10.0/Microsoft.NET.CrossGen.targets(467,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) System.NotImplementedException: iOSSimulator
  /Users/runner/work/1/s/src/runtime/artifacts/bin/Crossgen2Tasks/Release/net10.0/Microsoft.NET.CrossGen.targets(467,5): error : System.NotImplementedException: iOSSimulator [/Users/runner/work/1/s/src/runtime/src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Runtime.CoreCLR.sfxproj]
##[error]src/runtime/artifacts/bin/Crossgen2Tasks/Release/net10.0/Microsoft.NET.CrossGen.targets(467,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build)    at ILCompiler.Diagnostics.PerfMapWriter.TranslateTargetDetailsToPerfmapConstants(TargetDetails details) in /_/src/runtime/src/coreclr/tools/aot/ILCompiler.Diagnostics/PerfMapWriter.cs:line 120
  /Users/runner/work/1/s/src/runtime/artifacts/bin/Crossgen2Tasks/Release/net10.0/Microsoft.NET.CrossGen.targets(467,5): error :    at ILCompiler.Diagnostics.PerfMapWriter.TranslateTargetDetailsToPerfmapConstants(TargetDetails details) in /_/src/runtime/src/coreclr/tools/aot/ILCompiler.Diagnostics/PerfMapWriter.cs:line 120 [/Users/runner/work/1/s/src/runtime/src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Runtime.CoreCLR.sfxproj]
##[error]src/runtime/artifacts/bin/Crossgen2Tasks/Release/net10.0/Microsoft.NET.CrossGen.targets(467,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build)    at ILCompiler.Diagnostics.PerfMapWriter.PerfMapV1SignatureHelper(IEnumerable`1 inputAssemblies, TargetDetails details) in /_/src/runtime/src/coreclr/tools/aot/ILCompiler.Diagnostics/PerfMapWriter.cs:line 79
  /Users/runner/work/1/s/src/runtime/artifacts/bin/Crossgen2Tasks/Release/net10.0/Microsoft.NET.CrossGen.targets(467,5): error :    at ILCompiler.Diagnostics.PerfMapWriter.PerfMapV1SignatureHelper(IEnumerable`1 inputAssemblies, TargetDetails details) in /_/src/runtime/src/coreclr/tools/aot/ILCompiler.Diagnostics/PerfMapWriter.cs:line 79 [/Users/runner/work/1/s/src/runtime/src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Runtime.CoreCLR.sfxproj]
##[error]src/runtime/artifacts/bin/Crossgen2Tasks/Release/net10.0/Microsoft.NET.CrossGen.targets(467,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build)    at ILCompiler.DependencyAnalysis.ReadyToRun.PerfMapDebugDirectoryEntryNode.GetData(NodeFactory factory, Boolean relocsOnly) in /_/src/runtime/src/coreclr/tools/aot/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/DebugDirectoryEntryNode.cs:line 113
  /Users/runner/work/1/s/src/runtime/artifacts/bin/Crossgen2Tasks/Release/net10.0/Microsoft.NET.CrossGen.targets(467,5): error :    at ILCompiler.DependencyAnalysis.ReadyToRun.PerfMapDebugDirectoryEntryNode.GetData(NodeFactory factory, Boolean relocsOnly) in /_/src/runtime/src/coreclr/tools/aot/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/DebugDirectoryEntryNode.cs:line 113 [/Users/runner/work/1/s/src/runtime/src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Runtime.CoreCLR.sfxproj]
##[error]src/runtime/artifacts/bin/Crossgen2Tasks/Release/net10.0/Microsoft.NET.CrossGen.targets(467,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build)    at ILCompiler.DependencyAnalysis.ObjectNode.GetStaticDependencies(NodeFactory factory) in /_/src/runtime/src/coreclr/tools/Common/Compiler/DependencyAnalysis/ObjectNode.cs:line 59
  /Users/runner/work/1/s/src/runtime/artifacts/bin/Crossgen2Tasks/Release/net10.0/Microsoft.NET.CrossGen.targets(467,5): error :    at ILCompiler.DependencyAnalysis.ObjectNode.GetStaticDependencies(NodeFactory factory) in /_/src/runtime/src/coreclr/tools/Common/Compiler/DependencyAnalysis/ObjectNode.cs:line 59 [/Users/runner/work/1/s/src/runtime/src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Runtime.CoreCLR.sfxproj]
##[error]src/runtime/artifacts/bin/Crossgen2Tasks/Release/net10.0/Microsoft.NET.CrossGen.targets(467,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build)    at ILCompiler.DependencyAnalysisFramework.DependencyAnalyzer`2.GetStaticDependenciesImpl(DependencyNodeCore`1 node) in /_/src/runtime/src/coreclr/tools/aot/ILCompiler.DependencyAnalysisFramework/DependencyAnalyzer.cs:line 182
  /Users/runner/work/1/s/src/runtime/artifacts/bin/Crossgen2Tasks/Release/net10.0/Microsoft.NET.CrossGen.targets(467,5): error :    at ILCompiler.DependencyAnalysisFramework.DependencyAnalyzer`2.GetStaticDependenciesImpl(DependencyNodeCore`1 node) in /_/src/runtime/src/coreclr/tools/aot/ILCompiler.DependencyAnalysisFramework/DependencyAnalyzer.cs:line 182 [/Users/runner/work/1/s/src/runtime/src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Runtime.CoreCLR.sfxproj]
##[error]src/runtime/artifacts/bin/Crossgen2Tasks/Release/net10.0/Microsoft.NET.CrossGen.targets(467,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build)    at ILCompiler.DependencyAnalysisFramework.DependencyAnalyzer`2.GetStaticDependencies(DependencyNodeCore`1 node) in /_/src/runtime/src/coreclr/tools/aot/ILCompiler.DependencyAnalysisFramework/DependencyAnalyzer.cs:line 222
  /Users/runner/work/1/s/src/runtime/artifacts/bin/Crossgen2Tasks/Release/net10.0/Microsoft.NET.CrossGen.targets(467,5): error :    at ILCompiler.Program.Run() in /_/src/runtime/src/coreclr/tools/aot/crossgen2/Program.cs:line 304 [/Users/runner/work/1/s/src/runtime/src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Runtime.CoreCLR.sfxproj]
##[error]src/runtime/artifacts/bin/Crossgen2Tasks/Release/net10.0/Microsoft.NET.CrossGen.targets(467,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build)    at ILCompiler.Crossgen2RootCommand.<>c__DisplayClass211_0.<.ctor>b__0(ParseResult result) in /_/src/runtime/src/coreclr/tools/aot/crossgen2/Crossgen2RootCommand.cs:line 268
  /Users/runner/work/1/s/src/runtime/artifacts/bin/Crossgen2Tasks/Release/net10.0/Microsoft.NET.CrossGen.targets(467,5): error :    at ILCompiler.Crossgen2RootCommand.<>c__DisplayClass211_0.<.ctor>b__0(ParseResult result) in /_/src/runtime/src/coreclr/tools/aot/crossgen2/Crossgen2RootCommand.cs:line 268 [/Users/runner/work/1/s/src/runtime/src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Runtime.CoreCLR.sfxproj]
##[error]src/runtime/artifacts/bin/Crossgen2Tasks/Release/net10.0/Microsoft.NET.CrossGen.targets(467,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Error: iOSSimulator

@kotlarmilos
Copy link
Member

kotlarmilos commented Oct 31, 2025

Yes, it is dotnet/runtime#121237

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Nov 1, 2025

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/product-construction for assistance.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Nov 2, 2025

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/product-construction for assistance.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Nov 4, 2025

Important

The source repository has received code changes from an opposite flow. Any additional codeflows into this PR may potentially result in lost changes.

Please continue with one of the following options:

  1. Close or merge this PR and let the codeflow continue normally
  2. Close or merge this PR and receive the new codeflow immediately by triggering the subscription:
    darc trigger-subscriptions --id 6458ae35-db00-43d0-af59-e57a01ca3120
  3. Force-flow new changes into this PR at your own risk (some PR commits might be reverted):
    darc trigger-subscriptions --force --id 6458ae35-db00-43d0-af59-e57a01ca3120

💡 You may consult the FAQ for more information or tag @dotnet/product-construction for assistance.

@kotlarmilos kotlarmilos mentioned this pull request Nov 4, 2025
Merged
kotlarmilos added a commit to dotnet/runtime that referenced this pull request Nov 5, 2025
@kotlarmilos
Add support for JumpStubStubManager when FEATURE_JIT is enabled (#121338
b524fc3 
)

## Description

This PR fixes the iOS build by wrapping JumpStubStubManager in
FEATURE_JIT. It unblocks dotnet/dotnet#3175 and
adds the iOS CoreCLR functional test to runtime.yml to catch build
failures earlier in PRs.
@kotlarmilos
Copy link
Member

kotlarmilos commented Nov 6, 2025

@am11 How to pull the latest changes from main? I want to check if this PR is unblocked

@am11
Copy link
Member

am11 commented Nov 6, 2025

@kotlarmilos, AFAIK there are three options:

  1. Ask @akoeplinger et al. to manually kick darc subscription (assuming runtime builds are not blocked and maestro is stuck)
  2. If maestro is syncing fine and something is blocking runtime builds, just wait until that issue is resolved.
  3. Apply your PR(s) as patches, e.g. curl -sSLO https://github.com/dotnet/runtime/pull/121338.patch then update 121338.patch file with src/runtime prefix to all filenames and then git apply 121338.patch (I'm sure there is one liner syntax for it which I just ask AI, but this poor man's method works for me 😅)

#3 is better/DIY option if you can push to darc-main-8a551d19-67bf-4ce9-b5e3-2be5f6e400b8 branch.

@kotlarmilos
Copy link
Member

kotlarmilos commented Nov 6, 2025

Deferring to @akoeplinger to decide. It is dotnet/runtime#121237, dotnet/runtime#121338, and dotnet/runtime#121117

@akoeplinger
Copy link
Member

akoeplinger commented Nov 6, 2025 •
edited
Loading

Given this PR doesn't have any manual changes the fastest option is closing and retriggering the subscription, will do that.

new PR: #3258

@akoeplinger akoeplinger closed this Nov 6, 2025
@akoeplinger akoeplinger deleted the darc-main-8a551d19-67bf-4ce9-b5e3-2be5f6e400b8 branch November 6, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

.NET Unified Build
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@am11 @kotlarmilos @akoeplinger