Skip to content

Add -optimistic for crossgen2 option --instruction-set.#121203

Merged
jkotas merged 6 commits intodotnet:mainfrom
viewizard:add_optimistic_crossgen2
Nov 1, 2025
Merged

Add -optimistic for crossgen2 option --instruction-set.#121203
jkotas merged 6 commits intodotnet:mainfrom
viewizard:add_optimistic_crossgen2

Conversation

@viewizard
Copy link
Member

@viewizard viewizard commented Oct 30, 2025

Could be used for compile on x64 host for arm64 target (for example, during Tizen OS image creation).

Related to #121175, another approach for disable optimistic instruction set to be added.

CC @gbalykov @tannergooding @MichalStrehovsky

@viewizard
Add -optimistic for crossgen2 option --instruction-set.
9451b1f 
Could be used for compile on x64 host for arm64 target (for example, during Tizen OS image creation).
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 30, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Oct 30, 2025
@viewizard viewizard mentioned this pull request Oct 30, 2025
Closed
@am11
Copy link
Member

am11 commented Oct 30, 2025

It would be nice to also update the help text with native and optimistic options (ilc --help, crossgen2 --help):

runtime/src/coreclr/tools/aot/ILCompiler/ILCompilerRootCommand.cs

Lines 356 to 385 in 9451b1f

Console.WriteLine("The allowable values for the --instruction-set option are described in the table below. Each architecture has a different set of valid " +
"instruction sets, and multiple instruction sets may be specified by separating the instructions sets by a ','. For example 'avx,aes,apx'");
foreach (string arch in ValidArchitectures)
{
TargetArchitecture targetArch = Helpers.GetTargetArchitecture(arch);
bool first = true;
foreach (var instructionSet in Internal.JitInterface.InstructionSetFlags.ArchitectureToValidInstructionSets(targetArch).DistinctBy((instructionSet) => instructionSet.Name, StringComparer.OrdinalIgnoreCase))
{
// Only instruction sets with are specifiable should be printed to the help text
if (instructionSet.Specifiable)
{
if (first)
{
Console.Write(arch);
Console.Write(": ");
first = false;
}
else
{
Console.Write(", ");
}
Console.Write(instructionSet.Name);
}
}
if (first) continue; // no instruction-set found for this architecture
Console.WriteLine();
}

and

runtime/src/coreclr/tools/aot/crossgen2/Crossgen2RootCommand.cs

Lines 316 to 343 in 9451b1f

Console.WriteLine(SR.InstructionSetHelp);
foreach (string arch in ValidArchitectures)
{
TargetArchitecture targetArch = Helpers.GetTargetArchitecture(arch);
bool first = true;
foreach (var instructionSet in Internal.JitInterface.InstructionSetFlags.ArchitectureToValidInstructionSets(targetArch).DistinctBy((instructionSet) => instructionSet.Name, StringComparer.OrdinalIgnoreCase))
{
// Only instruction sets with are specifiable should be printed to the help text
if (instructionSet.Specifiable)
{
if (first)
{
Console.Write(arch);
Console.Write(": ");
first = false;
}
else
{
Console.Write(", ");
}
Console.Write(instructionSet.Name);
}
}
if (first) continue; // no instruction-set found for this architecture
Console.WriteLine();
}

tannergooding
tannergooding reviewed Oct 30, 2025
View reviewed changes
@build-analysis build-analysis bot mentioned this pull request Oct 30, 2025
Open
3 tasks
@viewizard
Care about +optimistic value in --instruction-set option.
6df0353 
Add more info in --instruction-set option of crossgen2 help output.
@viewizard
Copy link
Member Author

viewizard commented Oct 31, 2025

It would be nice to also update the help text with native and optimistic options (ilc --help, crossgen2 --help):

Good point, thanks! Added.

jkotas
jkotas reviewed Oct 31, 2025
View reviewed changes
@am11 am11 added area-crossgen2-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Oct 31, 2025
jkotas
jkotas reviewed Oct 31, 2025
View reviewed changes
tannergooding
tannergooding reviewed Oct 31, 2025
View reviewed changes
@jkotas
Copy link
Member

jkotas commented Nov 1, 2025

/ba-g infrastructure timeouts

@jkotas jkotas merged commit b71517e into dotnet:main Nov 1, 2025
92 of 97 checks passed
This was referenced Nov 2, 2025
Closed
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tannergooding tannergooding tannergooding left review comments

@jkotas jkotas jkotas approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

+1 more reviewer

@gbalykov gbalykov gbalykov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-crossgen2-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@viewizard @am11 @jkotas @tannergooding @gbalykov