[clr-interp] Fix CEE_ISINST to push object reference instead of InterpTypeI#121207
Merged
janvorli merged 1 commit intodotnet:mainfrom Oct 30, 2025
Merged
[clr-interp] Fix CEE_ISINST to push object reference instead of InterpTypeI#121207janvorli merged 1 commit intodotnet:mainfrom
janvorli merged 1 commit intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes trailing whitespace throughout the compiler.cpp file and fixes a bug in the handling of the ISINST and CASTCLASS IL opcodes.
- Removes trailing whitespace from multiple lines for code cleanliness
- Fixes incorrect type selection for ISINST opcode by always using InterpTypeO instead of conditionally choosing between InterpTypeO and InterpTypeI
Member
|
/ba-g Windows arm64 in CI is down |
Open
3 tasks
This was referenced Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
According to ECMA, CEE_ISINST must push an object reference onto stack, but it currently pushes InterpTypeI, which propagates an invalid IR stack type.
In the example below, by IL_0022 the stind.ref takes an i8 instead of object reference, triggering OBJECTREF validation failure.