-
Notifications
You must be signed in to change notification settings - Fork 383
Comparing changes
Open a pull request
base repository: dotnet/arcade
base: ff3e7d2
head repository: dotnet/arcade
compare: 286d980
- 14 commits
- 31 files changed
- 9 contributors
Commits on Jun 30, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 812a324 - Browse repository at this point
Copy the full SHA 812a324View commit details
Commits on Jul 1, 2021
-
* tests * remove unwanted using * addressed feedback * change response * comments * Revert some changes * changed it cos, the test were timing out * few nits * review comment
Configuration menu - View commit details
-
Copy full SHA for c206f6f - Browse repository at this point
Copy the full SHA c206f6fView commit details -
[Workloads] Fix license and icon paths in msi proj (#7579)
I was running into a couple of issues when building `msi.csproj` files generated by the `GenerateVisualStudioWorkload` task: C:\Program Files\dotnet\sdk\5.0.301\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(221,5): error : Could not find a part of the path 'C:\Users\peter\source\yaml-templates\nuget-msi-convert\msbuild\obj\Debug\src\msiPackage\x86\Microsoft.Android.Sdk.Windows\obj\Debug\src\msiPackage\x86\Microsoft.Android.Sdk.Windows'. C:\Program Files\dotnet\sdk\5.0.301\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(221,5): error NU5046: The icon file 'Icon.png' does not exist in the package. The first error was a result of the following relative path being included in the `LICENSE.TXT` item: <None Include="obj\Debug\src\msiPackage\x86\Microsoft.Android.Sdk.Windows\LICENSE.TXT" Pack="true" PackagePath="\" /> Since `LICENSE.TXT` is created in the same directory as `msi.proj`, we can exclude this relative path. The second error appears to be a result of a missing `Icon.png` item, which has been added. The generated pack item content should now look like this: <ItemGroup> <None Include="C:\Users\peter\source\yaml-templates\nuget-msi-convert\msbuild\bin\Microsoft.Android.Sdk.Windows.30.0.100-ci.main.61-x86.msi" Pack="true" PackagePath="\data" /> <None Include="C:\Users\peter\source\yaml-templates\nuget-msi-convert\msbuild\bin\Microsoft.Android.Sdk.Windows.30.0.100-ci.main.61-x86.json" Pack="true" PackagePath="\data\msi.json" /> <None Include="Icon.png" Pack="true" PackagePath="" /> <None Include="LICENSE.TXT" Pack="true" PackagePath="\" /> </ItemGroup>Configuration menu - View commit details
-
Copy full SHA for e865162 - Browse repository at this point
Copy the full SHA e865162View commit details -
* Send results using helix.public reporting * Test target queue * Use open test queue * Put Creator back * Get rid of the venv so we can load helix.public * Forgot an import * Correct HELIX_PYTHONPATH * Add rerun configuration * Try a flaky test * Allow for non-archive payloads * Wrong branch * Reset fake queue targeting * Ignore .env file
Configuration menu - View commit details
-
Copy full SHA for 7f52af2 - Browse repository at this point
Copy the full SHA 7f52af2View commit details
Commits on Jul 2, 2021
-
Automatically add dotnet6-internal feeds (#7580)
If dotnet6 is present, add dotnet6-internal and dotnet6-internal-transport. This is the same methodology as .NET 5 and .NET 3.1
Configuration menu - View commit details
-
Copy full SHA for ec35b48 - Browse repository at this point
Copy the full SHA ec35b48View commit details -
Add VS2022 support to the CMake SDK (#7586)
CMake 3.21.0-rc2 has support for VS2022, so enable VS2022 support in the CMake SDK since that's available for download. cc: @RussKie
Configuration menu - View commit details
-
Copy full SHA for 0f49657 - Browse repository at this point
Copy the full SHA 0f49657View commit details
Commits on Jul 5, 2021
-
[main] Update dependencies from dotnet/roslyn dotnet/xharness dotnet/…
…xliff-tasks dotnet/arcade mono/linker (#7581) [main] Update dependencies from dotnet/roslyn dotnet/xharness dotnet/xliff-tasks dotnet/arcade mono/linker
Configuration menu - View commit details
-
Copy full SHA for ecba7da - Browse repository at this point
Copy the full SHA ecba7daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 615fbd8 - Browse repository at this point
Copy the full SHA 615fbd8View commit details
Commits on Jul 6, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 66fc839 - Browse repository at this point
Copy the full SHA 66fc839View commit details -
[main] Update dependencies from dotnet/arcade mono/linker (#7591)
[main] Update dependencies from dotnet/arcade mono/linker
Configuration menu - View commit details
-
Copy full SHA for 52058eb - Browse repository at this point
Copy the full SHA 52058ebView commit details -
Add internal runtime args to source build template (#7587)
These need to be passed through to correct restore an internal runtime
Configuration menu - View commit details
-
Copy full SHA for 0563473 - Browse repository at this point
Copy the full SHA 0563473View commit details
Commits on Jul 7, 2021
-
Update dependencies from https://github.com/dotnet/xliff-tasks build …
…20210706.1 (#7594) [main] Update dependencies from dotnet/xliff-tasks
Configuration menu - View commit details
-
Copy full SHA for 03b92b3 - Browse repository at this point
Copy the full SHA 03b92b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9159815 - Browse repository at this point
Copy the full SHA 9159815View commit details -
Configuration menu - View commit details
-
Copy full SHA for 286d980 - Browse repository at this point
Copy the full SHA 286d980View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff ff3e7d2...286d980