Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/arcade
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: ff3e7d2
Choose a base ref
...
head repository: dotnet/arcade
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 286d980
Choose a head ref
  • 14 commits
  • 31 files changed
  • 9 contributors

Commits on Jun 30, 2021

  1. Configuration menu
    Copy the full SHA
    812a324 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2021

  1. Tests for publishing (#7346)

    * tests
    
    * remove unwanted using
    
    * addressed feedback
    
    * change response
    
    * comments
    
    * Revert some changes
    
    * changed it cos, the test were timing out
    
    * few nits
    
    * review comment
    epananth authored Jul 1, 2021
    Configuration menu
    Copy the full SHA
    c206f6f View commit details
    Browse the repository at this point in the history
  2. [Workloads] Fix license and icon paths in msi proj (#7579)

    I was running into a couple of issues when building `msi.csproj` files
    generated by the `GenerateVisualStudioWorkload` task:
    
        C:\Program Files\dotnet\sdk\5.0.301\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(221,5): error : Could not find a part of the path 'C:\Users\peter\source\yaml-templates\nuget-msi-convert\msbuild\obj\Debug\src\msiPackage\x86\Microsoft.Android.Sdk.Windows\obj\Debug\src\msiPackage\x86\Microsoft.Android.Sdk.Windows'.
    
        C:\Program Files\dotnet\sdk\5.0.301\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(221,5): error NU5046: The icon file 'Icon.png' does not exist in the package.
    
    The first error was a result of the following relative path being
    included in the `LICENSE.TXT` item:
    
        <None Include="obj\Debug\src\msiPackage\x86\Microsoft.Android.Sdk.Windows\LICENSE.TXT" Pack="true" PackagePath="\" />
    
    Since `LICENSE.TXT` is created in the same directory as `msi.proj`, we
    can exclude this relative path.
    
    The second error appears to be a result of a missing `Icon.png` item,
    which has been added.
    
    The generated pack item content should now look like this:
    
        <ItemGroup>
          <None Include="C:\Users\peter\source\yaml-templates\nuget-msi-convert\msbuild\bin\Microsoft.Android.Sdk.Windows.30.0.100-ci.main.61-x86.msi" Pack="true" PackagePath="\data" />
          <None Include="C:\Users\peter\source\yaml-templates\nuget-msi-convert\msbuild\bin\Microsoft.Android.Sdk.Windows.30.0.100-ci.main.61-x86.json" Pack="true" PackagePath="\data\msi.json" />
          <None Include="Icon.png" Pack="true" PackagePath="" />
          <None Include="LICENSE.TXT" Pack="true" PackagePath="\" />
        </ItemGroup>
    pjcollins authored Jul 1, 2021
    Configuration menu
    Copy the full SHA
    e865162 View commit details
    Browse the repository at this point in the history
  3. Use helix reporting (#7383)

    * Send results using helix.public reporting
    
    * Test target queue
    
    * Use open test queue
    
    * Put Creator back
    
    * Get rid of the venv so we can load helix.public
    
    * Forgot an import
    
    * Correct HELIX_PYTHONPATH
    
    * Add rerun configuration
    
    * Try a flaky test
    
    * Allow for non-archive payloads
    
    * Wrong branch
    
    * Reset fake queue targeting
    
    * Ignore .env file
    ChadNedzlek authored Jul 1, 2021
    Configuration menu
    Copy the full SHA
    7f52af2 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2021

  1. Automatically add dotnet6-internal feeds (#7580)

    If dotnet6 is present, add dotnet6-internal and dotnet6-internal-transport.
    This is the same methodology as .NET 5 and .NET 3.1
    mmitche authored Jul 2, 2021
    Configuration menu
    Copy the full SHA
    ec35b48 View commit details
    Browse the repository at this point in the history
  2. Add VS2022 support to the CMake SDK (#7586)

    CMake 3.21.0-rc2 has support for VS2022, so enable VS2022 support in the CMake SDK since that's available for download.
    cc: @RussKie
    jkoritzinsky authored Jul 2, 2021
    Configuration menu
    Copy the full SHA
    0f49657 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2021

  1. [main] Update dependencies from dotnet/roslyn dotnet/xharness dotnet/…

    …xliff-tasks dotnet/arcade mono/linker (#7581)
    
    [main] Update dependencies from dotnet/roslyn dotnet/xharness dotnet/xliff-tasks dotnet/arcade mono/linker
    dotnet-maestro[bot] authored Jul 5, 2021
    Configuration menu
    Copy the full SHA
    ecba7da View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    615fbd8 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2021

  1. Configuration menu
    Copy the full SHA
    66fc839 View commit details
    Browse the repository at this point in the history
  2. [main] Update dependencies from dotnet/arcade mono/linker (#7591)

    [main] Update dependencies from dotnet/arcade mono/linker
    dotnet-maestro[bot] authored Jul 6, 2021
    Configuration menu
    Copy the full SHA
    52058eb View commit details
    Browse the repository at this point in the history
  3. Add internal runtime args to source build template (#7587)

    These need to be passed through to correct restore an internal runtime
    mmitche authored Jul 6, 2021
    Configuration menu
    Copy the full SHA
    0563473 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2021

  1. Update dependencies from https://github.com/dotnet/xliff-tasks build …

    …20210706.1 (#7594)
    
    [main] Update dependencies from dotnet/xliff-tasks
    dotnet-maestro[bot] authored Jul 7, 2021
    Configuration menu
    Copy the full SHA
    03b92b3 View commit details
    Browse the repository at this point in the history
  2. Revert 7383 (#7595)

    * Update badge branch names
    
    * Revert "Use helix reporting (#7383)"
    
    This reverts commit 7f52af2.
    missymessa authored Jul 7, 2021
    Configuration menu
    Copy the full SHA
    9159815 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    286d980 View commit details
    Browse the repository at this point in the history
Loading