Merged
Conversation
Contributor
|
There seem to be additional commits here (dating back to March?) It looks like the code changes are right, but it's confusing to have anything other than the revert in the PR. |
riarenas
approved these changes
Jul 7, 2021
Member
Author
I noticed that too and tried to clean it up, but git didn't see a difference in what I was trying change :( |
AlitzelMendez
approved these changes
Jul 7, 2021
missymessa
added a commit
that referenced
this pull request
Jul 12, 2021
This reverts commit 9159815.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To double check:
Reverts #7383 until further investigation can be done to see if this PR caused errors in Runtime. See: dotnet/runtime#55074 (comment)