Conversation
# Conflicts: # src/Microsoft.DotNet.Helix/Sdk/tools/azure-pipelines/reporter/azure_devops_result_publisher.py # src/Microsoft.DotNet.Helix/Sdk/tools/azure-pipelines/reporter/run.py
# Conflicts: # src/Microsoft.DotNet.Helix/Sdk/tools/azure-pipelines/reporter/run.py
# Conflicts: # tests/UnitTests.proj
# Conflicts: # src/Microsoft.DotNet.Helix/Sdk/tools/azure-pipelines/reporter/run.py
src/Microsoft.DotNet.Helix/Sdk/tools/azure-pipelines/reporter/formats/result_format.py
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
It would be very beneficial with this reporting change to add support for a docker-container helix work item (just a row in UnitTests.proj), so we find out whether this works there before going to production. |
@MattGal would you mind writing an issue for this work? Since Chad is OOF for another week, we are likely going to merge this PR in as-is before he gets back if it's successful. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
It's just one line to the project file to prove that this scenario works, I really think either adding it or some proof of manually exercising this with it should be part of this PR before it merges. If you get everything else working but that's still a problem, I can help. |
Would you mind contributing that change to this PR? |
Sure, but let's wait til the normal path is green in the current run to make sure we're not mixing and matching different problems. |
MattGal
left a comment
There was a problem hiding this comment.
I will open a PR immediately after this merges to add the docker testing I commented about.
|
LGTM |
Follow up from #7383. This means we now depend on the Helix clients to do reporting, and the code path is somewhat different for Docker, so let's test one docker variation (Alpine chosen because it's small, and the original reason the Helix Docker feature exists)
This reverts commit 7f52af2.
Reintroduce corrected #7383 This switches arcade from using a custom reporter, to using a reporter more tightly integrated with helix. That reporter has the capacity to handle local test retrying and reporting to Azure DevOps for "flaky" tests. To enable the retry, a file "eng/test-configuration.json" must be created following the documented schema.
… This means we now depend on the Helix clients to do reporting, and the code path is somewhat different for Docker, so let's test one docker variation
… This means we now depend on the Helix clients to do reporting, and the code path is somewhat different for Docker, so let's test one docker variation (#7790)
Use the Helix test reporting feature that allows for test retry configuration/reporting.