Automatically add dotnet6-internal feeds#7580
Merged
mmitche merged 1 commit intodotnet:mainfrom Jul 2, 2021
Merged
Conversation
If dotnet6 is present, add dotnet6-internal and dotnet6-internal-transport. This is the same methodology as .NET 5 and .NET 3.1
lukas-lansky
approved these changes
Jul 2, 2021
| PackageSources+=('dotnet5-internal-transport') | ||
| fi | ||
|
|
||
| # Ensure dotnet6-internal and dotnet6-internal-transport are in the packageSources if the public dotnet6 feeds are present |
Contributor
There was a problem hiding this comment.
It might be nice to loop over ("dotnet3.1-internal" "dotnet5-internal" "dotnet6-internal") here to get rid off the almost-duplicated code.
Member
Author
There was a problem hiding this comment.
Yeah...I just didn't want to mess with it too much. Also the URIs for 3.1 are different than 5.0 and 6.0
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If dotnet6 is present, add dotnet6-internal and dotnet6-internal-transport.
This is the same methodology as .NET 5 and .NET 3.1
To double check: