Merged
Conversation
That method has been deprecated for almost 15 years, in 85d4084. On top of that I'm adding a deprecation for something related that was scheduled for deprecation at in the same commit.
Stop using QueryBuilder::getRootAlias()
This fixes a dangerous bug where LIMIT is silently ignored in DELETE
operations, potentially causing developers to delete all rows instead
of just the intended subset. The setMaxResults() method would be
silently omitted from the final query, making operations like
delete last entry accidentally delete entire tables.
…misuse QueryBuilder: prevent misuse of DELETE with LIMIT
Merge 3.5.x up into 3.6.x
Merge 3.5.x up into 3.6.x
…output Add JSON format option for orm:mapping:describe command output
Merge 3.5.x up into 3.6.x
Merge 3.5.x up into 3.6.x
* 3.5.x: Move LazyGhost deprecation to ProxyFactory (doctrine#12101) Address deprecations from doctrine/dbal (doctrine#12098)
….6.x_OhbrLWrh Merge release 3.5.1 into 3.6.x
* 3.5.x: Don't partially mock the AbstractPlatform class (doctrine#12114)
….6.x_N9Rr16zf Merge release 3.5.2 into 3.6.x
It produces no effect.
Deprecate specifying nullable on primary key columns
I forgot to copy it from another test.
Add missing assertion in test
* 3.5.x: Prefer non-deprecated AbstractAsset API (doctrine#12142)
Merge 3.5.x up into 3.6.x
In the scope of doctrine/persistence#433 (available from `doctrine/persistence` >= 4.1) there was added `ColocatedMappingDriver::$classLocator` (`ClassLocator`) property, which allows passing any instance of `ClassLocator` for the mapping driver to use. This commit integrates those changes into `AttributeDriver`. Since `doctrine/orm` maintains the support for `doctrine/persistence` of older versions, tests ensure that `ClassLocator` actually exists. The old paths' behaviour can be adapted into the new by passing `FileClassLocator` into `AttributeDriver` (see `FileClassLocator::createFromDirectories($directoryPaths)`).
…octrine-persistence-4.1 Feature: add support for `ClassLocator`
Co-authored-by: a.dmitryuk <a.dmitryuk@movavi.com>
* 3.5.x: Add a CI job that fails on deprecations (doctrine#12188) use the empty string instead of null as an array offset (doctrine#12181) do not call setAccessible() on PHP >= 8.1 (doctrine#12182) Fix docs on final entities (doctrine#12176) Remove Database and Model First chapters that said little of value. Switch to IgnoreDeprecations docs: consistent PostgreSQL's name case docs: generation strategies differences between DBAL 3 and 4 Check extra condition to decide if a test was skipped Use PHPUnit 11 when possible Migrate away from annotations in tests Migrate away from assertStringNotMatchesFormat() Migrate to willReturn() Migrate away from getMockForAbstractClass() Fix `IN`/`NOT IN` expression handling and support enums when matching on to-many-collections
* 3.5.x: Fix missing import Remove calls to getMockForAbstractClass() (doctrine#12003) Upgrade to doctrine/coding-standard 14 Bump doctrine/.github from 7.3.0 to 8.0.0
…being `@deprecated`
Merge 3.5.x up into 3.6.x
…er-result Add deprecation messages for methods that were only annotated as being `@deprecated`
DQL arbitrary joins are semantically equivalent to SQL joins, so using the same keyword reduces confusion. It also means that in next major version, the WITH keyword will only be about applying adhoc filtering on relations instead of having 2 responsibilities.
Merge 3.5.x up into 3.6.x
Update DQL arbitrary joins to use the ON keyword instead of WITH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.