Merged
Conversation
Merge 2.20.x up into 2.21.x
Merge 2.20.x up into 2.21.x
…Yg2ZYgM Merge release 2.20.1 into 2.21.x
* 2.20.x: Introduce testNotListedValueInEnumArray Fix documentation for JoinColumn nullable (#11798) Ignore deprecations from doctrine/common Fix fields of transient classes being considered duplicate with `reportFieldsWhereDeclared`
…O8nHxqC Merge release 2.20.2 into 2.21.x
If scheduleForInsert was called in prePersist hook already, then persistNew need to check this case first, otherwise a ORMInvalidArgumentException will be thrown
…kdqS0u7 Merge release 2.20.3 into 2.21.x
Add functional strict-locking 2nd level cache test
When the persister is extended to do a multi update, the caching is not wanted. The impact is minimal as the CPU/time overhead per query is much bigger and the prepared statement is not cached anyway.
The new variable name is much more clearer.
Improve BasicEntityPersister to be more flexible and cleaner
Fix JoinedSubclassPersister as BasicEntityPersister was already fixed in GH-10735. The fix can be verified by modifying UnitOfWork to execute `BasicEntityPersister::executeInserts()` for multiple entities at once for the same entity class/persister instance - https://github.com/doctrine/orm/blob/2.20.3/src/UnitOfWork.php#L1186 - then reproducible on `Doctrine\Tests\ORM\Functional\Ticket\GH10531Test::testInserts` test. As extending/modifying UnitOfWork in tests in not easily possible, I submit this fix for v2.x without a test.
…_insert_of_multiple_entities Fix JoinedSubclassPersister when multiple entities are inserted
…-branches-on-README doc: update supported branches on README (2.20.x)
Inserts without post-inserted ID can be sent to DB grouped together hence the extra test.
Using a nullable column that references another table as part of a primary key makes no sense, and is ignored by DBAL. Let us ignore it at the ORM level.
fix: calling scheduleForInsert twice
Address deprecations
…ry_test Add 2nd level cache test for insert without post-inserted ID
Fix broken comments
Merge 2.20.x up into 3.5.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes for 3.5.2
3.5.x bugfix release (patch)
3.5.2
Test Suite
Bug