Add 2nd level cache test for insert without post-inserted ID#12097
Merged
greg0ire merged 1 commit intodoctrine:2.20.xfrom Aug 8, 2025
Merged
Add 2nd level cache test for insert without post-inserted ID#12097greg0ire merged 1 commit intodoctrine:2.20.xfrom
greg0ire merged 1 commit intodoctrine:2.20.xfrom
Conversation
Member
|
Have you seen #11978 ? |
Contributor
Author
|
Thank you for pointing that PR out. I was not aware of it. This test is still stronger as it tests also the 2nd level cache. When merging up the query count might need to be reduced. |
greg0ire
reviewed
Aug 3, 2025
tests/Tests/ORM/Functional/SecondLevelCacheCountQueriesTest.php
Outdated
Show resolved
Hide resolved
tests/Tests/ORM/Functional/SecondLevelCacheCountQueriesTest.php
Outdated
Show resolved
Hide resolved
Inserts without post-inserted ID can be sent to DB grouped together hence the extra test.
fa3b05f to
5b2060e
Compare
greg0ire
approved these changes
Aug 7, 2025
SenseException
approved these changes
Aug 7, 2025
Member
|
Thanks @mvorisek |
greg0ire
reviewed
Aug 8, 2025
| } | ||
|
|
||
| /** | ||
| /* @param SupportedCacheUsage $cacheUsage |
Member
There was a problem hiding this comment.
Didn't notice this before merging.
Suggested change
| /* @param SupportedCacheUsage $cacheUsage | |
| * @param SupportedCacheUsage $cacheUsage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inserts without autoincrement (post inserted ID) can be sent to DB grouped together hence the extra test.
improves test added in #12086
Currently the query count for inserts with and without autoincrement are the same, but in the future, these counts can improved using changes like #8260, so better to have this usecase tested.