Skip to content

Add functional strict-locking 2nd level cache test#12086

Merged
greg0ire merged 11 commits intodoctrine:2.20.xfrom
mvorisek:add_cache_rw_strict_locking_test
Jul 29, 2025
Merged

Add functional strict-locking 2nd level cache test#12086
greg0ire merged 11 commits intodoctrine:2.20.xfrom
mvorisek:add_cache_rw_strict_locking_test

Conversation

@mvorisek
Copy link
Copy Markdown
Contributor

@mvorisek mvorisek commented Jul 25, 2025

Currently, 2nd level caching is functionally tested with only "NONSTRICT_READ_WRITE" cache usage mode.

This PR adds testing with strict "READ_WRITE" mode.

To cover Doctrine\ORM\Cache\Persister\Entity\ReadWriteCachedEntityPersister class, more precisely https://github.com/doctrine/orm/blob/2.20.5/src/Cache/Persister/Entity/ReadWriteCachedEntityPersister.php#L76 and https://github.com/doctrine/orm/blob/2.20.5/src/Cache/Persister/Entity/ReadWriteCachedEntityPersister.php#L101 methods using E2E functional tests.

greg0ire and others added 10 commits October 16, 2024 23:37
…2.21.x_3Yg2ZYgM

Merge release 2.20.1 into 2.21.x
* 2.20.x:
  Introduce testNotListedValueInEnumArray
  Fix documentation for JoinColumn nullable (doctrine#11798)
  Ignore deprecations from doctrine/common
  Fix fields of transient classes being considered duplicate with `reportFieldsWhereDeclared`
…2.21.x_8O8nHxqC

Merge release 2.20.2 into 2.21.x
…2.21.x_KkdqS0u7

Merge release 2.20.3 into 2.21.x
@mvorisek mvorisek marked this pull request as draft July 25, 2025 09:50
@mvorisek mvorisek force-pushed the add_cache_rw_strict_locking_test branch 2 times, most recently from 5d43989 to b84cf30 Compare July 25, 2025 09:55
@mvorisek mvorisek marked this pull request as ready for review July 25, 2025 10:21
@mvorisek mvorisek force-pushed the add_cache_rw_strict_locking_test branch from b84cf30 to ab2be96 Compare July 28, 2025 10:14
@mvorisek mvorisek force-pushed the add_cache_rw_strict_locking_test branch from ab2be96 to ae7489f Compare July 28, 2025 10:14
greg0ire
greg0ire previously approved these changes Jul 28, 2025
SenseException
SenseException previously approved these changes Jul 28, 2025
@greg0ire
Copy link
Copy Markdown
Member

You should target 2.20.x according to #11208

@mvorisek mvorisek changed the base branch from 2.21.x to 2.20.x July 29, 2025 08:26
@mvorisek mvorisek dismissed stale reviews from SenseException and greg0ire July 29, 2025 08:26

The base branch was changed.

@mvorisek
Copy link
Copy Markdown
Contributor Author

mvorisek commented Jul 29, 2025

retargeted

@greg0ire greg0ire merged commit 154a465 into doctrine:2.20.x Jul 29, 2025
71 checks passed
@greg0ire
Copy link
Copy Markdown
Member

Thanks @mvorisek !

@mvorisek mvorisek deleted the add_cache_rw_strict_locking_test branch July 29, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants