Fix docs on final entities#12176
Merged
SenseException merged 1 commit intodoctrine:3.5.xfrom Sep 25, 2025
Merged
Conversation
greg0ire
reviewed
Sep 23, 2025
docs/en/reference/architecture.rst
Outdated
| - An entity class must not be final nor read-only but | ||
| it may contain final methods or read-only properties. | ||
| - An entity class can be final or read-only when | ||
| you use :ref:`native lazy object<reference-native-lazy-objects>`. |
Member
There was a problem hiding this comment.
Suggested change
| you use :ref:`native lazy object<reference-native-lazy-objects>`. | |
| you use :ref:`native lazy objects<reference-native-lazy-objects>`. |
docs/en/reference/architecture.rst
Outdated
| it may contain final methods or read-only properties. | ||
| - An entity class can be final or read-only when | ||
| you use :ref:`native lazy object<reference-native-lazy-objects>`. | ||
| It may always contain final methods or read-only properties. |
Member
There was a problem hiding this comment.
Did you mean to say "also" instead of "always"?
Contributor
Author
There was a problem hiding this comment.
Did you mean to say "also" instead of "always"?
Nope. The properties can be final/ro in any case, so "always" is correct.
Member
There was a problem hiding this comment.
Ok… feels a bit weird that you don't use the same wording for the entity and its methods. Also, it's unclear what cases you are thinking about when you say "in any case"
Member
There was a problem hiding this comment.
Ah I get it, it's when using native lazy objects or not 💡
Member
There was a problem hiding this comment.
Then I think I would reverse it: An entity class may contain final methods or read-only properties, and can be final or read-only as soon as you use…
Member
There was a problem hiding this comment.
Suggested change
| It may always contain final methods or read-only properties. | |
| It may contain final methods or read-only properties too. |
73ec5c0 to
a3790e3
Compare
SenseException
requested changes
Sep 23, 2025
docs/en/reference/architecture.rst
Outdated
| it may contain final methods or read-only properties. | ||
| - An entity class can be final or read-only when | ||
| you use :ref:`native lazy object<reference-native-lazy-objects>`. | ||
| It may always contain final methods or read-only properties. |
Member
There was a problem hiding this comment.
Suggested change
| It may always contain final methods or read-only properties. | |
| It may contain final methods or read-only properties too. |
a3790e3 to
e46e641
Compare
greg0ire
approved these changes
Sep 25, 2025
SenseException
approved these changes
Sep 25, 2025
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Oct 7, 2025
* 3.5.x: Add a CI job that fails on deprecations (doctrine#12188) use the empty string instead of null as an array offset (doctrine#12181) do not call setAccessible() on PHP >= 8.1 (doctrine#12182) Fix docs on final entities (doctrine#12176) Remove Database and Model First chapters that said little of value. Switch to IgnoreDeprecations docs: consistent PostgreSQL's name case docs: generation strategies differences between DBAL 3 and 4 Check extra condition to decide if a test was skipped Use PHPUnit 11 when possible Migrate away from annotations in tests Migrate away from assertStringNotMatchesFormat() Migrate to willReturn() Migrate away from getMockForAbstractClass() Fix `IN`/`NOT IN` expression handling and support enums when matching on to-many-collections
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Oct 7, 2025
* 3.6.x: Add a CI job that fails on deprecations (doctrine#12188) use the empty string instead of null as an array offset (doctrine#12181) do not call setAccessible() on PHP >= 8.1 (doctrine#12182) Fix docs on final entities (doctrine#12176) Remove Database and Model First chapters that said little of value. Switch to IgnoreDeprecations Fix php doc for getPropertyAccessors method (doctrine#12159) docs: consistent PostgreSQL's name case docs: generation strategies differences between DBAL 3 and 4 Check extra condition to decide if a test was skipped Use PHPUnit 11 when possible Migrate away from annotations in tests Migrate away from assertStringNotMatchesFormat() Migrate to willReturn() Migrate away from getMockForAbstractClass() Fix `IN`/`NOT IN` expression handling and support enums when matching on to-many-collections
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Oct 8, 2025
* 3.6.x: Fix missing import Remove calls to getMockForAbstractClass() (doctrine#12003) Add a CI job that fails on deprecations (doctrine#12188) use the empty string instead of null as an array offset (doctrine#12181) Upgrade to doctrine/coding-standard 14 Bump doctrine/.github from 7.3.0 to 8.0.0 do not call setAccessible() on PHP >= 8.1 (doctrine#12182) Fix docs on final entities (doctrine#12176) Remove Database and Model First chapters that said little of value. Switch to IgnoreDeprecations Fix php doc for getPropertyAccessors method (doctrine#12159) docs: consistent PostgreSQL's name case docs: generation strategies differences between DBAL 3 and 4 Check extra condition to decide if a test was skipped Use PHPUnit 11 when possible Migrate away from annotations in tests Migrate away from assertStringNotMatchesFormat() Migrate to willReturn() Migrate away from getMockForAbstractClass() Fix `IN`/`NOT IN` expression handling and support enums when matching on to-many-collections
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #12156
I'm not sure about the wording. I'm open to suggestions.