do not call setAccessible() on PHP >= 8.1#12182
Merged
derrabus merged 1 commit intodoctrine:2.20.xfrom Oct 1, 2025
Merged
Conversation
Member
|
Not sure we should do this for 2.x still, as for 3.x we dont need it anymore anyways. Has this already happened in 3.x? |
Member
|
2.x is still going to be supported when 8.5 comes out, so I'd say it would make sense. There is still 10% of the userbase of 2.x using 8.4, we should IMO let them migrate to 8.5 before they upgrade to 3.x if they want to. |
greg0ire
approved these changes
Sep 29, 2025
SenseException
approved these changes
Sep 30, 2025
Member
SenseException
left a comment
There was a problem hiding this comment.
Don't know if these 10% are even using 8.4 though.
Member
|
@SenseException what do you mean? The 10% are the 10% of 2.x users using 8.4, of course they are using 8.4 😅 |
derrabus
approved these changes
Oct 1, 2025
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Oct 7, 2025
* 2.20.x: use the empty string instead of null as an array offset (doctrine#12181) do not call setAccessible() on PHP >= 8.1 (doctrine#12182) Bump actions/checkout from 4 to 5 PHPCS 3.13.2 (doctrine#12134) PHPStan 2.1.22 Bump actions/download-artifact from 4 to 5 chore: remove run-all.sh Fix `IN`/`NOT IN` expression handling and support enums when matching on to-many-collections
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Oct 7, 2025
* 2.20.x: use the empty string instead of null as an array offset (doctrine#12181) do not call setAccessible() on PHP >= 8.1 (doctrine#12182)
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Oct 7, 2025
* 3.5.x: Add a CI job that fails on deprecations (doctrine#12188) use the empty string instead of null as an array offset (doctrine#12181) do not call setAccessible() on PHP >= 8.1 (doctrine#12182) Fix docs on final entities (doctrine#12176) Remove Database and Model First chapters that said little of value. Switch to IgnoreDeprecations docs: consistent PostgreSQL's name case docs: generation strategies differences between DBAL 3 and 4 Check extra condition to decide if a test was skipped Use PHPUnit 11 when possible Migrate away from annotations in tests Migrate away from assertStringNotMatchesFormat() Migrate to willReturn() Migrate away from getMockForAbstractClass() Fix `IN`/`NOT IN` expression handling and support enums when matching on to-many-collections
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Oct 7, 2025
* 3.6.x: Add a CI job that fails on deprecations (doctrine#12188) use the empty string instead of null as an array offset (doctrine#12181) do not call setAccessible() on PHP >= 8.1 (doctrine#12182) Fix docs on final entities (doctrine#12176) Remove Database and Model First chapters that said little of value. Switch to IgnoreDeprecations Fix php doc for getPropertyAccessors method (doctrine#12159) docs: consistent PostgreSQL's name case docs: generation strategies differences between DBAL 3 and 4 Check extra condition to decide if a test was skipped Use PHPUnit 11 when possible Migrate away from annotations in tests Migrate away from assertStringNotMatchesFormat() Migrate to willReturn() Migrate away from getMockForAbstractClass() Fix `IN`/`NOT IN` expression handling and support enums when matching on to-many-collections
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Oct 8, 2025
* 3.6.x: Fix missing import Remove calls to getMockForAbstractClass() (doctrine#12003) Add a CI job that fails on deprecations (doctrine#12188) use the empty string instead of null as an array offset (doctrine#12181) Upgrade to doctrine/coding-standard 14 Bump doctrine/.github from 7.3.0 to 8.0.0 do not call setAccessible() on PHP >= 8.1 (doctrine#12182) Fix docs on final entities (doctrine#12176) Remove Database and Model First chapters that said little of value. Switch to IgnoreDeprecations Fix php doc for getPropertyAccessors method (doctrine#12159) docs: consistent PostgreSQL's name case docs: generation strategies differences between DBAL 3 and 4 Check extra condition to decide if a test was skipped Use PHPUnit 11 when possible Migrate away from annotations in tests Migrate away from assertStringNotMatchesFormat() Migrate to willReturn() Migrate away from getMockForAbstractClass() Fix `IN`/`NOT IN` expression handling and support enums when matching on to-many-collections
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.