fix(label-content-name-mismatch): better dismiss and wysiwyg symbolic text characters by gaiety-deque · Pull Request #4402 · dequelabs/axe-core

gaiety-deque · 2024-04-09T19:28:05Z

adds exceptions for (dismiss) ×, wysiwyg characters b, aA, abc

This does not handle all potential use cases. Potential shortcomings worth discussing and opening further issues for are as follows:

Considering other languages, such as this example in German including "UT", "AD" or "DGS"
The original issue label-content-name-mismatch incorrectly fails close button with #4386 mentioned this being handled as a character limit, but it's unclear if that's a valid option. Consider the WCAG ABC example
EDIT: Does not specifically have test cases for math expressions and formulae

… text characters adds exceptions for (dismiss) ×, wysiwyg characters b, aA, abc fix: #4386

CLAassistant · 2024-04-09T19:28:11Z

All committers have signed the CLA.

lib/commons/text/is-human-interpretable.js

test/integration/rules/label-content-name-mismatch/label-content-name-mismatch.html

… char alpha the same fix: #4386

…s var -> const isHumanInterpretable was getting lengthy, refactored into several small functions unit test used var, switched to const Refs: #4386

lib/commons/text/is-human-interpretable.js

test/commons/text/is-human-interpretable.js

lib/commons/text/is-human-interpretable.js

gaiety-deque · 2024-04-11T16:36:19Z

Should switch to case insensitive for symbolic text

straker · 2024-04-11T16:36:43Z

As discussed, we'll want to add a test that uses a single CJK character (any of the 3) for the label and a different one for the visible text and show that it returns incomplete, that way we document the behavior (previous to this change CJK would pass/fail for single characters if different).

…, ignore cap Addresses all feedback on PR #4402 - Simpler symbolic text check, ignoring case, with unit test for both - Added back "x" and "X" in unit test - Removed trim step, uneeded - Reverted set to list, uneeded - removed /i in non-digit regex - test for a CJK character - adjusted integration test labels for single character incompletes, noticed an ordering bug and corrected Refs: #4386

Followed Steven's advice for a simpler non-digit single character check, added a test to show a digit isn't incompleted Refs: #4386

gaiety-deque · 2024-04-11T18:56:32Z

As discussed, we'll want to add a test that uses a single CJK character (any of the 3) for the label and a different one for the visible text and show that it returns incomplete, that way we document the behavior (previous to this change CJK would pass/fail for single characters if different).

@straker addressed in 30d8388

requested changes addressed

dbjorge

Thanks for the updates, LGTM!

dbjorge · 2024-04-13T02:05:03Z

lib/checks/label/label-content-name-mismatch-evaluate.js

+
+  if (
+    isHumanInterpretable(accText) < 1 ||
+    isHumanInterpretable(visibleText) < 1


I had to think about this for a while, but I think I agree with your changes here. I think this creates 2 (but really 1) behavior changes:

If accText is not interpretable and visibleText is empty

Previously incomplete, now pass

This is irrelevant in practice because label-content-name-mismatch-matches filters out cases without visible text

If accText is interpretable, visibleText is not intepretable, and visibleText is contained in accText

Previously pass, now incomplete

Example: <button aria-label="bold">B</button>

Previously I think that case would pass (return true) - with this change, I think it incompletes (returns undefined). I think it's more consistent with the change (I don't think it makes sense for a visible "x" button to give different results for labels "close" vs "exit").

@WilcoFiers

### [4.9.1](v4.9.0...v4.9.1) (2024-05-06) ### Bug Fixes - Prevent errors when loading axe in a page with prototype.js - **aria-allowed-attr:** allow meter role allowed aria-\* attributes on meter element ([#4435](#4435)) ([7ac6392](7ac6392)) - **aria-allowed-role:** add gridcell, separator, slider and treeitem to allowed roles of button element ([#4398](#4398)) ([4788bf8](4788bf8)) - **aria-roles:** correct abstract roles (types) for aria-roles([#4421](#4421)) - **aria-valid-attr-value:** aria-controls & aria-haspopup incomplete ([#4418](#4418)) - fix building axe-core translation files with region locales ([#4396](#4396)) ([5c318f3](5c318f3)), closes [#4388](#4388) - **invalidrole:** allow upper and mixed case role names ([#4358](#4358)) ([105016c](105016c)), closes [#2695](#2695) - **isVisibleOnScreen:** account for position: absolute elements inside overflow container ([#4405](#4405)) ([2940f6e](2940f6e)), closes [#4016](#4016) - **label-content-name-mismatch:** better dismiss and wysiwyg symbolic text characters ([#4402](#4402)) - **region:** Decorative images ignored by region rule ([#4412](#4412)) - **target-size:** ignore descendant elements in shadow dom ([#4410](#4410)) ([6091367](6091367)) - **target-size:** pass for element that has nearby elements that are obscured ([#4422](#4422)) ([3a90bb7](3a90bb7)), closes [#4387](#4387) This PR was opened by a robot 🤖 🎉 (And updated by @WilcoFiers )

fix(label-content-name-mismatch): better dismiss and wysiwyg symbolic…

c215a9d

… text characters adds exceptions for (dismiss) ×, wysiwyg characters b, aA, abc fix: #4386

gaiety-deque requested a review from a team as a code owner April 9, 2024 19:28

dbjorge previously requested changes Apr 10, 2024

View reviewed changes

lib/commons/text/is-human-interpretable.js Show resolved Hide resolved

test/integration/rules/label-content-name-mismatch/label-content-name-mismatch.html Show resolved Hide resolved

gaiety-deque added 2 commits April 11, 2024 09:36

fix(label-content-name-mismatch): fewer blocklists, handle all single…

0cd9d71

… char alpha the same fix: #4386

fix(label-content-name-mismatch): refactor isHumanInterpretable, test…

9ed16e6

…s var -> const isHumanInterpretable was getting lengthy, refactored into several small functions unit test used var, switched to const Refs: #4386

straker previously requested changes Apr 11, 2024

View reviewed changes

gaiety-deque added 2 commits April 11, 2024 13:45

fix(label-content-name-mismatch): simpler non-digit check, test added

c4aa062

Followed Steven's advice for a simpler non-digit single character check, added a test to show a digit isn't incompleted Refs: #4386

gaiety-deque requested review from dbjorge and straker April 11, 2024 19:12

dbjorge approved these changes Apr 13, 2024

View reviewed changes

gaiety-deque merged commit 56e139a into develop Apr 15, 2024

gaiety-deque deleted the agw--label-content-name-mismatch-exceptions branch April 15, 2024 14:06

attest-team-ci mentioned this pull request May 6, 2024

chore(release): v4.9.1 #4446

Merged

data-sync-user mentioned this pull request Jun 3, 2024

Bump axe-core from 4.9.0 to 4.9.1 MozillaFoundation/foundation.mozilla.org#12328

Merged

wingn8t mentioned this pull request Jun 14, 2024

[Snyk] Upgrade axe-core from 4.8.4 to 4.9.1 wingn8t/wagtail#1

Open

gurudeep9 mentioned this pull request Jun 23, 2024

[Snyk] Upgrade axe-core from 4.9.0 to 4.9.1 gurudeep9/mattermost-test#2

Open

Stanislav1975 mentioned this pull request Aug 9, 2024

[Snyk] Upgrade axe-core from 4.3.3 to 4.9.1 Stanislav1975/sitespeed.io#4

Open

Stanislav1975 mentioned this pull request Aug 19, 2024

[Snyk] Upgrade axe-core from 4.3.3 to 4.10.0 Stanislav1975/sitespeed.io#11

Open

Stanislav1975 mentioned this pull request Sep 9, 2024

[Snyk] Upgrade: uuid, , , axe-core, fast-stats, find-up, cli-color, coach-core, dayjs, fs-extra, influx, jstransformer-markdown-it, junit-report-builder, os-name, p-limit, pug, recursive-readdir Stanislav1975/sitespeed.io#12

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(label-content-name-mismatch): better dismiss and wysiwyg symbolic text characters#4402

fix(label-content-name-mismatch): better dismiss and wysiwyg symbolic text characters#4402
gaiety-deque merged 5 commits intodevelopfrom
agw--label-content-name-mismatch-exceptions

gaiety-deque commented Apr 9, 2024 •

edited

Loading

Uh oh!

CLAassistant commented Apr 9, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gaiety-deque commented Apr 11, 2024

Uh oh!

straker commented Apr 11, 2024 •

edited

Loading

Uh oh!

gaiety-deque commented Apr 11, 2024

Uh oh!

dbjorge left a comment

Uh oh!

dbjorge Apr 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

gaiety-deque commented Apr 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CLAassistant commented Apr 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gaiety-deque commented Apr 11, 2024

Uh oh!

straker commented Apr 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gaiety-deque commented Apr 11, 2024

Uh oh!

dbjorge left a comment

Choose a reason for hiding this comment

Uh oh!

dbjorge Apr 13, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gaiety-deque commented Apr 9, 2024 •

edited

Loading

CLAassistant commented Apr 9, 2024 •

edited

Loading

straker commented Apr 11, 2024 •

edited

Loading