-
Notifications
You must be signed in to change notification settings - Fork 881
label-content-name-mismatch incorrectly fails close button with #4386
Copy link
Copy link
Closed
Labels
experimentalfixBug fixesBug fixesrulesIssue or false result from an axe-core ruleIssue or false result from an axe-core rulesupport
Milestone
Description
This should not fail the label-content-name-mismatch rule:
<button aria-label="Close">×</button>I think sort of generally this rule should not fail on single character content elements. For this case I think the "×" needs to be added to the list of chars never to fail. I'm not sure why it isn't already. It would be good to go over the list of unicode characters we're always allowing. There are clearly some gaps there.
More generally, even if we encounter single-character texts (excluding digits) that are not on the list it would be better to incomplete them instead of failing. We do a similar thing in the color-contrast rule just to be on the safe side.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
experimentalfixBug fixesBug fixesrulesIssue or false result from an axe-core ruleIssue or false result from an axe-core rulesupport
Type
Fields
Give feedbackNo fields configured for issues without a type.