Skip to content

fix(invalidrole): allow upper and mixed case role names#4358

Merged
straker merged 7 commits intodequelabs:developfrom
lsprr:invalidrole-evaluate
Apr 1, 2024
Merged

fix(invalidrole): allow upper and mixed case role names#4358
straker merged 7 commits intodequelabs:developfrom
lsprr:invalidrole-evaluate

Conversation

@lsprr
Copy link
Copy Markdown
Contributor

@lsprr lsprr commented Mar 5, 2024

Closes: #2695

@lsprr lsprr requested a review from a team as a code owner March 5, 2024 17:37
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 5, 2024

CLA assistant check
All committers have signed the CLA.

@lsprr lsprr changed the title fix(invalidrole-evaluate): add toLowerCase to the invalidrole check for role validation. fix(invalidrole): add toLowerCase to the invalidrole check for role validation. Mar 5, 2024
Copy link
Copy Markdown
Contributor

@straker straker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for the pr. We'll want to add a test to the invalid role test file that verifies passing an uppercase role does not return undefined

@lsprr
Copy link
Copy Markdown
Contributor Author

lsprr commented Mar 5, 2024

Awesome! Thanks for the pr. We'll want to add a test to the invalid role test file that verifies passing an uppercase role does not return undefined

Hi! Thank you for the feedback. I've added a test to the invalid role test file.

@straker straker dismissed their stale review March 25, 2024 21:51

Resolved

@straker
Copy link
Copy Markdown
Contributor

straker commented Apr 1, 2024

Thanks for the pr and updating the tests!

@straker
Copy link
Copy Markdown
Contributor

straker commented Apr 1, 2024

Reviewed for security

@straker straker changed the title fix(invalidrole): add toLowerCase to the invalidrole check for role validation. fix(invalidrole): allow upper and mixed case role names Apr 1, 2024
@straker straker merged commit 105016c into dequelabs:develop Apr 1, 2024
WilcoFiers added a commit that referenced this pull request May 6, 2024
###
[4.9.1](v4.9.0...v4.9.1)
(2024-05-06)

### Bug Fixes

- Prevent errors when loading axe in a page with prototype.js
- **aria-allowed-attr:** allow meter role allowed aria-\* attributes on
meter element
([#4435](#4435))
([7ac6392](7ac6392))
- **aria-allowed-role:** add gridcell, separator, slider and treeitem to
allowed roles of button element
([#4398](#4398))
([4788bf8](4788bf8))
- **aria-roles:** correct abstract roles (types) for
aria-roles([#4421](#4421))
- **aria-valid-attr-value:** aria-controls & aria-haspopup incomplete
([#4418](#4418))
- fix building axe-core translation files with region locales
([#4396](#4396))
([5c318f3](5c318f3)),
closes [#4388](#4388)
- **invalidrole:** allow upper and mixed case role names
([#4358](#4358))
([105016c](105016c)),
closes [#2695](#2695)
- **isVisibleOnScreen:** account for position: absolute elements inside
overflow container
([#4405](#4405))
([2940f6e](2940f6e)),
closes [#4016](#4016)
- **label-content-name-mismatch:** better dismiss and wysiwyg symbolic
text characters
([#4402](#4402))
- **region:** Decorative images ignored by region rule
([#4412](#4412))
- **target-size:** ignore descendant elements in shadow dom
([#4410](#4410))
([6091367](6091367))
- **target-size:** pass for element that has nearby elements that are
obscured ([#4422](#4422))
([3a90bb7](3a90bb7)),
closes [#4387](#4387)


This PR was opened by a robot 🤖 🎉 (And updated by @WilcoFiers
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Report case sensitivity issues

3 participants