Fix initiatives display when not initialized#9928
Merged
alecslupu merged 5 commits intodecidim:developfrom Apr 14, 2023
Merged
Conversation
Contributor
|
Hi Elie and Alexandru, I tried locally and your fix is working great on my side ! I tried on a clean installation, I created a new system admin in command line and then my organization. Once the organization was created, I could test the PR and I confirm that I couldn't access to initiatives routes and that the Initiatives button is removed in the menu if there is no initiative type or scope created.
|
Contributor
|
@eliegaboriau please rebase this branch with decidim develop, so we can start the review / test process. |
alecslupu
previously approved these changes
Apr 14, 2023
alecslupu
approved these changes
Apr 14, 2023
alecslupu
added a commit
that referenced
this pull request
Apr 14, 2023
ahukkanen
pushed a commit
that referenced
this pull request
Apr 14, 2023
This was referenced Apr 19, 2023
alecslupu
added a commit
that referenced
this pull request
Apr 25, 2023
alecslupu
added a commit
that referenced
this pull request
Apr 25, 2023
ahukkanen
pushed a commit
that referenced
this pull request
Apr 25, 2023
ahukkanen
pushed a commit
that referenced
this pull request
Apr 26, 2023
andreslucena
added a commit
to decidim/metadecidim
that referenced
this pull request
Jul 6, 2023
This is not valid anymore with the introduction of this fix in the release: decidim/decidim#9928
alecslupu
pushed a commit
to decidim/metadecidim
that referenced
this pull request
Jul 11, 2023
* Update decidim to 0.27.3 * Remove "Initiatives" menu expectation from example This is not valid anymore with the introduction of this fix in the release: decidim/decidim#9928
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR removes the initiatives button in the menu when there is no initiative types or scope created.
It also redirects any request to initiatives to the homepage with a flash message
📌 Related Issues
Link your PR to an issue
Testing
On a clean installation