Add create authorization to initiative types by eliegaboriau · Pull Request #9309 · decidim/decidim

eliegaboriau · 2022-05-17T06:54:04Z

🎩 What? Why?

This PR offers the possibility to add an authorization handler on the creation of initiatives, according to the initiative type.
It asks for the authorization when choosing the initiative type, if an authorization handler has been chosen.
If there's only one initiative type, it asks for the authorization when clicking on "new initiative"

📌 Related Issues

Link your PR to an issue

Fixes Configure authorization for initiative creation #9294

Testing

Describe the best way to test or validate your PR.
- Go to admin initiative type list
- Click on permissions for one
- Change the create permissions
- Go to initiative
- Click on create initiative
- See that under the initiative type you changed, it's written "verify your account to promote this initiative"
- Click on it
- See that it asks for an authorization

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

📷 Screenshots

Please add screenshots of the changes you're proposing
The screenshots are in the issue

♥️ Thank you!

fix test

add button when initiative type doesn't need an authorisation but initiative does

…//github.com/eliegaboriau/decidim into add_create_authorization_to_initiative_types

ahukkanen

Looks great, thanks @eliegaboriau !

I just have one question, see below. I understand that you may have a valid reason to do this but just for me to understand us well, could you please explain?

decidim-initiatives/app/helpers/decidim/initiatives/initiative_helper.rb

...im-initiatives/app/controllers/decidim/initiatives/authorization_create_modals_controller.rb

eliegaboriau · 2022-06-14T16:00:00Z

Looks great, thanks @eliegaboriau !

It's actually not that great, we've seen that it's depend a lot on the "do not require authorization" configuration.
I'm gonna draft it to rewrite the spec

ahukkanen · 2022-06-17T15:06:12Z

@eliegaboriau Also a kind reminder to you that we are planning releasing 0.27 RC1 next week so if you'd like to incorporate this into the next release, we would need to get this done shortly.

If you cannot finish it shortly, no worries! It will then be part of the 0.28 release.

eliegaboriau · 2022-06-20T08:05:49Z

@eliegaboriau Also a kind reminder to you that we are planning releasing 0.27 RC1 next week so if you'd like to incorporate this into the next release, we would need to get this done shortly.

If you cannot finish it shortly, no worries! It will then be part of the 0.28 release.

Hello @ahukkanen
I'm trying to add everything i want to add today, hopefully we can add this in the next release

Fix not authorized modal when choosing initiative type

eliegaboriau · 2022-06-20T15:01:19Z

@ahukkanen It's okay for me, let me know if something's missing !

ahukkanen · 2022-06-23T08:35:00Z

@eliegaboriau There is one conflict, could you please resolve?

ahukkanen

I noticed one issue after the latest changes, could you please move the reveal to its own partial?

Also, there are some conflicts, could you resolve those?

After #9347, we also changed the default password to decidim123456789, so we also need to apply this change to the specs where you are logging in.

decidim-initiatives/spec/system/create_initiative_spec.rb

...-initiatives/app/views/decidim/initiatives/create_initiative/select_initiative_type.html.erb

Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>

eliegaboriau · 2022-06-23T09:57:58Z

It should be okay now !

ahukkanen

Tested this and this works great!

The UX flow just feels weird when doing the following:

Require authorization for initiative type creation (e.g. use the example authorization with the default configuration)
Login with an unauthorized user account
Go to create an initiative of the type that requires the authorization that you configured
Authorize the user with the required authorization but provide authorization data that does not match the configurations of the configured authorization (e.g. use a different postal code than the required one)

After authorizing the account, I now see this:

If this happened, I would rather see some error message that my authorization data does not match the requirements.

But I also understand it is not in the scope of this PR, so we probably cannot do much about it. This is just how the authorizations work as they are decoupled from the sections that may or may not require an authorization.

When I click the "Verify your account to promote this initiative", I correctly see this popup as expected:

Therefore, I still get the information why I cannot vote but just the UX is pretty weird after the authorization action.

Regarding this particular PR, it's all good.

Even though this PR touches the participant facing UI, I will merge this as this has been already implemented way before the redesign guidelines were published and there were just some code cleanup happening at the final stage of the review. Also, the initiatives redesign has not started yet so I believe it won't do any harm merging this now.

Also FYI @eliegaboriau, for any further PRs, the guidelines are available at #9512 (if you didn't already know).

* first version * fix i18n * linter * linter * fix permissions fix test * fix tests add button when initiative type doesn't need an authorisation but initiative does * lint * lint * change requests * refactor * linter * Improve spec Fix not authorized modal when choosing initiative type * linter * linter * add refresh when needed * Update decidim-initiatives/spec/system/create_initiative_spec.rb Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi> * Update decidim-initiatives/spec/system/create_initiative_spec.rb Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi> * Update decidim-initiatives/spec/system/create_initiative_spec.rb Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi> * Update decidim-initiatives/spec/system/create_initiative_spec.rb Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi> * Update decidim-initiatives/spec/system/create_initiative_spec.rb Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi> * Update decidim-initiatives/spec/system/create_initiative_spec.rb Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi> * refactor modal in partial * linter Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>

eliegaboriau and others added 13 commits May 13, 2022 12:01

first version

b12acb0

fix i18n

66e7174

linter

3cf3826

linter

5c068a2

fix permissions

623cffe

fix test

fix tests

c1066e5

add button when initiative type doesn't need an authorisation but initiative does

Merge branch 'develop' into add_create_authorization_to_initiative_types

13ecba1

lint

14f1d2d

Merge branch 'add_create_authorization_to_initiative_types' of https:…

2b45b7d

…//github.com/eliegaboriau/decidim into add_create_authorization_to_initiative_types

lint

0764465

change requests

fe14d47

refactor

f99d559

linter

2a1eca6

This was referenced Jun 1, 2022

backport create initiatives with authorization handler OpenSourcePolitics/decidim-cd44#28

Closed

Backport/create initiative authorization OpenSourcePolitics/decidim-cd44#29

Merged

ahukkanen added type: feature module: initiatives labels Jun 8, 2022

ahukkanen reviewed Jun 14, 2022

View reviewed changes

decidim-initiatives/app/helpers/decidim/initiatives/initiative_helper.rb Show resolved Hide resolved

...im-initiatives/app/controllers/decidim/initiatives/authorization_create_modals_controller.rb Show resolved Hide resolved

eliegaboriau marked this pull request as draft June 14, 2022 16:00

eliegaboriau and others added 2 commits June 20, 2022 16:57

Improve spec

b1a3948

Fix not authorized modal when choosing initiative type

Merge branch 'develop' into add_create_authorization_to_initiative_types

c5acf70

eliegaboriau marked this pull request as ready for review June 20, 2022 14:58

linter

c41ec3c

eliegaboriau added 2 commits June 20, 2022 17:07

linter

40e6e4c

add refresh when needed

d120735

ahukkanen requested changes Jun 23, 2022

View reviewed changes

eliegaboriau and others added 9 commits June 23, 2022 10:48

Merge branch 'develop' into add_create_authorization_to_initiative_types

7c77311

Update decidim-initiatives/spec/system/create_initiative_spec.rb

f8e9a52

Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>

Update decidim-initiatives/spec/system/create_initiative_spec.rb

5e46e05

Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>

Update decidim-initiatives/spec/system/create_initiative_spec.rb

ecd5a51

Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>

Update decidim-initiatives/spec/system/create_initiative_spec.rb

7820ea7

Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>

Update decidim-initiatives/spec/system/create_initiative_spec.rb

2bfbdeb

Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>

Update decidim-initiatives/spec/system/create_initiative_spec.rb

c4945dd

Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>

refactor modal in partial

aa5e4aa

linter

53280aa

ahukkanen approved these changes Jul 8, 2022

View reviewed changes

ahukkanen merged commit 56c1986 into decidim:develop Jul 8, 2022

eliegaboriau mentioned this pull request Nov 28, 2022

Backport create initiative with AH OpenSourcePolitics/decidim-cese#4

Merged

12 tasks

This was referenced Jan 30, 2023

Backport 'Respect "rich text editor" setting in Initiatives' to v0.26 #10304

Merged

Backport 'Respect "rich text editor" setting in Initiatives' to v0.27 #10271

Merged

alecslupu mentioned this pull request Mar 12, 2023

Fix initiatives display when not initialized #9928

Merged

jorgeatgu mentioned this pull request May 25, 2023

Redesign: initiatives #10646

Merged

2 tasks

This was referenced Feb 26, 2024

Bump decidim version AjuntamentdeBarcelona/decidim-barcelona#531

Merged

release/0.27 stable bcn AjuntamentdeBarcelona/decidim#34

Draft

Uh oh!

Conversation

eliegaboriau commented May 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎩 What? Why?

📌 Related Issues

Testing

📋 Checklist

📷 Screenshots

Uh oh!

ahukkanen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

eliegaboriau commented Jun 14, 2022

Uh oh!

ahukkanen commented Jun 17, 2022

Uh oh!

eliegaboriau commented Jun 20, 2022

Uh oh!

eliegaboriau commented Jun 20, 2022

Uh oh!

ahukkanen commented Jun 23, 2022

Uh oh!

ahukkanen left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eliegaboriau commented Jun 23, 2022

Uh oh!

ahukkanen left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

eliegaboriau commented May 17, 2022 •

edited

Loading

ahukkanen left a comment •

edited

Loading