Implement drawers with turbo in accountability#9884
Closed
entantoencuanto wants to merge 162 commits intodevelopfrom
Closed
Implement drawers with turbo in accountability#9884entantoencuanto wants to merge 162 commits intodevelopfrom
entantoencuanto wants to merge 162 commits intodevelopfrom
Conversation
* develop: Redesign: action buttons (#9852)
…o refresh filtered path and clear drawer
Contributor
|
@NilHomedes @decidim/product drawers can be reviewed again. We have removed (temporally) comments from drawers, it was causing some weird side effects, and we want you just to focus on the drawer itself. |
Contributor
|
The versions browsing is pending, we leave it to #10174 |
NilHomedes
previously approved these changes
Dec 22, 2022
Member
NilHomedes
left a comment
There was a problem hiding this comment.
Drawer behaviour now looks good to me.
Just to note: The back button is missing. As we talked in #10107
ahukkanen
requested changes
Dec 22, 2022
Contributor
ahukkanen
left a comment
There was a problem hiding this comment.
This seems fine for me but I don't think the dynamic heading is a good idea.
Please also see the other comment regarding the versions link. It seems broken but not sure if it's supposed to work either.
decidim-accountability/app/cells/decidim/accountability/project/show.erb
Show resolved
Hide resolved
decidim-accountability/app/views/decidim/accountability/results/_project.html.erb
Show resolved
Hide resolved
Closed
Contributor
|
Please @Crashillo fix conflicts so @ahukkanen can merge this. |
Merged
Contributor
Author
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10096
Closes #10090
🎩 What? Why?
This PR implements the drawers feature using Turbo:
Due to Turbo way of working, scripts can't be loaded inside the
<body>tag, because the body is reloaded on each request. This PR also moves JS back to the<head>section to fix #10090Notice that although the thread of comments is included in the drawer, it's not working yet, so comments shouldn't be reviewed to approve this PR. Comments are being redesigned in #9898
📌 Related Issues
Testing
Describe the best way to test or validate your PR.
📷 Screenshots
Please add screenshots of the changes you're proposing
