Conversation
* develop: Fix running DB commands consecutively (#9607) Always allow image upload in WYSWYG editor (#10011) Fix usages of sanitize helper methods for editable content provided by admins (#10007) Show only ToS acceptance when admin hasn't accepted it (#9907) Redesign: accountability (#9772) Update the gitignore statement for development app (#10045) Improve RSpec configuration (#9931) Refactor the meeting list item title display (#10043)
74d597b to
ee0d79e
Compare
4a15b77 to
425abdc
Compare
|
We have a decision about drawers #10184 (comment), so we need to plan how to undo all code related to drawers and Turbo. We'd need to:
|
|
@decidim/product @decidim/maintainers we can't proceed with the drawers removal until this is merged. Please tell us what you think about it. We asked last wednesday |
ahukkanen
left a comment
There was a problem hiding this comment.
I have just left one request above regarding removing the heading changer JS if that will be no longer required.
Can we do that and then it's good to be merged?
I have also created the following issue to list the pending issues I have noticed #10228 during the latest review.
I also noticed an issue with the sidebar filters which I have reported to an existing issue at #10148.
|
The headings hack will be removed in #10184, so merging this in |
* feature/redesign: Redesign: meetings (#9830)
* feature/redesign-card-g: Use date instead of time for current date in metadata Revert delegation Add deprecation redesign comments Update decidim-assemblies/app/cells/decidim/assemblies/assembly_metadata_g_cell.rb Redesign: meetings (#9830) Rename method to make purpose clearer Fix typo
…nt-blocks * feature/redesign: User's group endorsement no longer disappears after personal endorsement removed (#10223) Multi content blocks with the same manifest for the same page and section content block for ToS (#10166) Fix initiatives count in initiatives index page (#10150) Fix Pipeline after #10211 (#10240) send notifications after transaction (#10211) Switch to GitHub concurrency in CI (#10133) Added missing localizations (#10210) Added links and nickname fields to User Group Admin panel (#10236) Improve link handling of the redirect engine (#10235) Fix pipeline asset absolute URLs (#9597) Fix double parentheses in the titled upload modal with existing attachment (#10221) Removed "disabled" status from proposals' main categories (#10216) Added Reporting time in Global Moderation / Users (#10213) Fix dependency resolver trying to fetch gem paths from lazy specifications (#10220) Implement card g (#10219) Redesign: meetings (#9830)
* feature/redesign: Redesign: main header layout glitches (#10182) User's group endorsement no longer disappears after personal endorsement removed (#10223) Multi content blocks with the same manifest for the same page and section content block for ToS (#10166) Fix initiatives count in initiatives index page (#10150) Fix Pipeline after #10211 (#10240) send notifications after transaction (#10211) Switch to GitHub concurrency in CI (#10133) Added missing localizations (#10210) Added links and nickname fields to User Group Admin panel (#10236) Improve link handling of the redirect engine (#10235) Fix pipeline asset absolute URLs (#9597) Fix double parentheses in the titled upload modal with existing attachment (#10221) Removed "disabled" status from proposals' main categories (#10216) Added Reporting time in Global Moderation / Users (#10213) Fix dependency resolver trying to fetch gem paths from lazy specifications (#10220) Implement card g (#10219) Redesign: meetings (#9830)
* Update JS tests
* Apply initializer to changed comments from polling
* Proper JS reprocessing when create comment
* Safer execution
* Prevent multiple execution of external links
* Trailing space
* create a fake id for accorions and dropdown if has none
* Typo
* Typo
* better paddings to dropdown items
* extract the styles from modal to modal_flag
* Offense
* Remove unused translations
* Redesign: meetings (#9830)
* Use version date in author cell
* Link to the last version show from meeting
* Remove index action on versions of meetings
* Simplify code and remove unused methods in versions cells
* turn the partial month into a cell
* include map in meetings block
* remove sticky from filter-container component
* Add a callback to replace url con drawer close event
* Allow passing a path argument to diff cell
* Use turbo to update diff view selection options
* Change method not present yet
* Add icons support to highlighted_meetings_for_component_cell
* Add path to year calendar inside component to cell
* Refactor meeting_month cell and update params
* Define year param and use it in year_calendar partial
* Update link
* Allow to redefine the item list default class
* Define meeting_l card and use it in lists
* Remove wrong file
* move logic to fuction
* Define duration of meeting metadata
* Display official metadata only when required
* Update meeting metadata in show action
* Extract dates and map of show to a cell
* Remove deprecations
* Fix announcement messages in meetings index
* Add redesigned filter form builder to generate redesigned filters, including nested ones
* Change the way to pass filter options to templates
* Integrate shared filters template
* Update values for filters in meetings index to use icons
* Fix value of root input hidden element
* Move filters list generation
* Fix generation of checkboxes_tree_id
* update item-list* classes with card__list*
* merge item-list into card css component
* Don't enable dropdown behaviour for blank root component of an item
* Put depending elements at the same level if the main leaf is blank ('all' option)
* Prevent errors if filter_text_form is called from a not redesinged part of application
* Add icons to filters options in meetings and general
* Setup meetings filters for index both in component and directory
* Remove unused partial
* Refactor month cell
* Fix id for panel-dropdown behavior at first level in filters
* Clean deprecations
* clean meetings content-block
* Fix year_calendar to work both in global and component context
* truncate large categories
* filters duplication on redesign
* Make data conditional in dropdown_label
* adapt script y markup to check/uncheck children
* Define a helper method to build a tree of checkboxes an array of values and labels
* Use trees for filter options in directory
* Fix linters and clean code
* Change default
* Use turbo_frames in meetings show
* better js-doc
* Define a Decidim::TurboHelper and use turbo in versions show view
* Refresh versions views using turbo
* Add missing translations to duration metadata format
* Avoid using filter_params in close filtered path of drawer when no params for filter exist
* filters checkbox recursives & indeterminates
* Fix element to refresh in filters
* Recover par page hidden field tag
* include note about the funtionality
* Remove commented turbo frame tag
* Remove not required turbo_frame_tag
* Add tabs to meeting drawer
* Add missing translations
* refactor images component
* Avoid errors if result l card is called from other component
* Use card_l on linked resources of accountability results
* Refactor generation of items
* Use meeting_l card on linked_meetings template
* Change translations and icons of tabs
* Add calendar modal (styles pending)
* Add styles to calendar modal
* duplicate layout live meetings
* live meetings header
* use the redesigned scripts
* Remove jQuery from script
* Move javascript to head to prevent Turbo issue
* Move foot scripts to body
* Remove broken links
* set max height for images
* Unify origin values for meetings filters
* Avoid initialize twice on turbo events
* Avoid initialize twice on turbo events
* Wrap drawer content inside a frame
* Wrap drawer content inside a frame
* Improve navigation between projects inside frames
* Launch a visit on onClose event of drawer
* Launch a visit on onClose event of drawer
* Change target frame on meetings navigation inside a drawer
* Move meeting frame from index to partial
* edit form inside live events
* Fix call to partial from cell
* fix registration modal markup
* fix cancelation modal markup
* editor content spans to max space
* change order cookies and stuff
* Move images and documents tabs content to cells to be shared in decidim-core
* Use unique ids for calendar share modals
* Update class of private meeting badge
* responsive drawer
* mark links in dynamic content
* increase calendar lg width
* create new meeting form
* Remove calendar link
* Avoid visit after drawer close
* Remove preview in meetings
* Set main frame
* Don't use a in close drawer element
* make form element block when they're surrounded by form__wrapper class
* adapt scripts to the head due to #10090
* add space after map
* minimal fixes live events
* Fix linter offenses
* block background scroll #10135
* fix scss lint
* fix stylelint
* Remove unused translations
* Add ignored keys to i18n-tasks
* Refactor highlighted meeetings content block to show past meetings and hide calendar link
* Fix translations calls
* actions flow meeting drawer aside
* close meeting form
* add more space desktop
* discard blocking the page when the drawer is open
* handle special case moving out of the drawer through links
* Disable turbo on meetings filter
* fix admin bar answer live event
* replace missing styles
* Move method to appropriate helper
* Consider redesign in test
* replace missing styles
* Add extra param required by decidim/version cell
* Fix tests of diff cell
* Fix tests of diff partials on some modules [WIP]
Updated on:
* Accountability
* Debates
* Initiatives
* Fix test about meetings in initiatives
* Normalize locales
* Fix package tests
* remove dummy map
* update read-only condition
* Fix expected selector in meeting_cell spec
* Add category metadata to meeting cell
* Remove disable_dynamic_change data option in meetings filter
* Replace url_calendar_url to share on refresh instead of removing modal
* Adapt tests in explore_meeting_directory
* Skip some tests when redesign is not fully enabled
* Adapt tests to redesign in meetings exploration
* Fix accountability tests
* Display correctly author of version when added as string
* Skip test with redesign disabled
* Move redesign_prepared skips to a helper
* Quick fix for filters with 'All' option marked
* Fix minutes format
* Fix tests and skip redesign dependent ones
* Fix selector in tests
* hide creation date on author
* remove border calendar small
* Skip redesign dependent tests
* Add comments count and withdrawn badge to metadata
* Enable redesign explicitly in meetings controllers
* Recover withdrawn feature in meetings list
* Add withdraw meeting button in meeting drawer
* Remove duplicated visits
* Create tests for attachments in drawers
* Fix selector in tests
* Skip redesign dependent tests
* Fix tests
* Remove deprecated test
* Remove unnecessary content_for
* Move js_content to body
* Remove preview of results
* Wrap results index in main frame
* Replace document with element in redesigned_index.js
* Move meeting_frame out of main_frame
* Move project_frame out of main_frame
* Update filtered path on index update
* Update filtered path on index update
* update filtered path on index.js
* avoid duplicates & ignore children if parent checked
* Update URL on results filter changes
* Add turbo_stream_action tag when main_frame is updated with filters to refresh filtered path and clear drawer
* Revert "Quick fix for filters with 'All' option marked"
This reverts commit 8fd154e526f7c6dcfd6a4b7aebaf32fd15d2f6b2.
* Remove unused translation
* Skip redesign dependent tests
* Update selectors
* Remove deprecated test
* Add missing dependency
* Allow calling diff cell without a path
* Add some test skips dependant of redesign
* Fix selectors in tests and remove deprecated ones
* Add some skips related with redesign
* Prevent errors ordering versions when calculated as an array instead of a relation
* Adapt proposals versions tests
* Fix tests
* Recover announcement callout in meetings index
* Disable Turbo when switching to admin
* Restore service worker pack
* Avoid visit after drawer close
* Don't refresh filter when index is called from show action
* Update test
* Ignore comments tests in meetings drawer pending of redesign integration
* Adapt meetings versions tests
* Update selector in test
* Update selectors in tests
* Fix tests of meetings edition
* Disable test pending of integration
* Fix tests
* Fix selector in test
* Fix tests
* Skip tests dependant of redesign
* Fix tests
* Skip deprecated tests
* Skip redesign pending tests about reporting in meetings drawer
* update translation
* Rename comments_count item in card metadata
* update tests with new literal
* fix meetings tests
* fix meetings tests
* Change header
* Display component name in meetings aside partial when the index refers to a component
* Use correct partial to display documents inside a meeting drawer
* add button for withdrawn meetings
* fulfill a11y
* Rename partial to be used in cells also
* fix overflowing mobile
* fix tests
* fix tests accountability
* fix tests meetings
Co-authored-by: Eduardo Martinez Echevarria <eduardomech@gmail.com>
Co-authored-by: Fernando Blat <fernando@blat.es>
* Implement card g (#10219)
* Define card_g cell
* Define progress item in metadata
* Define processes g cell
* Define post grid card
* Adjust description in card g cell
* Improve id generation in card g cell
* Hide metadata block from card_g if not defined or empty
* Define assemblies g cell
* Define conferences g cell
* Leave interactions item pending in process metadata
* Use highlighted card g for promoted assemblies conferences and processes in their indexes
* Correct PostGCell inheritance
* Don't use sanitize_editor on description
* avoid tailwind purging
* Fix linter offense
* Simplify progress span
* Enable process and process_group g cells and force it on promoted items of index
* Skip redesign pending accesibility tests
* Skip deprecated tests
* Fix tests in processes
* Enable assembly g cell and force it on promoted items of index
* Fix assembly test for highlighted items in index
* Fix conferences test for highlighted items in index
* Remove unused translations
* Fix typo
Co-authored-by: Fernando Blat <fernando@blat.es>
* Rename method to make purpose clearer
* Update decidim-assemblies/app/cells/decidim/assemblies/assembly_metadata_g_cell.rb
Co-authored-by: Fernando Blat <fernando@blat.es>
* Add deprecation redesign comments
* Revert delegation
* Use date instead of time for current date in metadata
* Remove wrong parentheses
* Delegate method
* Simplify method
* Remove partials
* Remove redundant condition
* Move values to constants
* Remove partials and invoke card-g from views directly
Co-authored-by: Hugoren Martinako <aumpfbahn@gmail.com>
Co-authored-by: Fernando Blat <fernando@blat.es>
* Fix dependency resolver trying to fetch gem paths from lazy specifications (#10220)
* Ensure we are not returning lazy specifications
The lazy specification is not responding to the `#full_gem_path`
method which causes the dependency resolving to fail under newer
bundler versions and also in the situation that the newest
installed bundler version differs from the locked bundler version.
* Fix the expecation in the dependency resolver spec
* Added Reporting time in Global Moderation / Users (#10213)
* added-reported-time-to-user-moderations
* deleted-extra-line
* locale-changes
* fields reorder/contentmoderations - localizations revert
* fixed tests
* Removed "disabled" status from proposals' main categories (#10216)
* removed-main-category-disabling
* fixed-a-typo
* Fix double parentheses in the titled upload modal with existing attachment (#10221)
* Fix pipeline asset absolute URLs (#9597)
* Rename Decidim::AssetRouter to Decidim::AssetRouter::Storage
* Implement pipeline asset router
* Fetch the avatar default URLs through Decidim::AssetRouter::Pipeline
* Add specs for the avatar uploader
* Fix failing spec for NilPresenter
* Rubocop
* Fix spec after merge
* Fix the pipeline spec after merge
* Improve link handling of the redirect engine (#10235)
* Added links and nickname fields to User Group Admin panel (#10236)
* added-nickname-field-to-usergroups
* Added missing localizations (#10210)
* added-missing-localizations
* test-fixes
* additional-localizations-added
* comment-edit/date-format
* Switch to GitHub concurrency in CI (#10133)
* Switch to GitHub concurrency
* Rename the API CI workflow name
* Revert "Rename the API CI workflow name"
This reverts commit defe599bdcb16defa3d8589bdc7610d3c8a60279.
* send notifications after transaction (#10211)
* Fix Pipeline after #10211 (#10240)
* Fix initiatives count in initiatives index page (#10150)
* Multi content blocks with the same manifest for the same page and section content block for ToS (#10166)
* Multiple content blocks for landing page and add sections to static page
* Fix two-pane section view
* Fix rubocop offense and normalize locales
* Fix static page update method
* Add class to content blocks card
* Fix spec/system/admin_manages_static_page_content_blocks_spec.rb tests
* Fix spec/system/admin_manages_organization_homepage_spec.rb tests
* Fix spec/commands/decidim/admin/reorder_content_blocks_spec.rb tests
* Fix spec/forms/static_page_form_spec.rb tests
* Fix spec/system/admin/admin_manages_participatory_process_group_landing_page_spec.rb tests
* Add new tests for deleting content blocks and creating multiple with the same manifest on the same page
* Fix unused argument
* Suggestions after review applied
* Remove unused i18n keys
* Add summary content block seed only for terms-and-conditions page
* Fix where to show content blocks on tabbed view
* Configuration to allow content blocks on specific pages
* Move commands and concern into a new Decidim::Admin::ContentBlocks namespace
* Fix spec/commands/decidim/admin/reorder_content_blocks_spec.rb tests
* Fix spec/commands/decidim/admin/create_newsletter_spec.rb tests
* Fix commands tests
* Move content of page_blocks config_accessor to decidim-generators
* User's group endorsement no longer disappears after personal endorsement removed (#10223)
* Fixed group endorsement removal when personal endorsement removed & tests
* test-fixes
* Redesign: main header layout glitches (#10182)
* extract all CSS from main-bar to header CSS file
* do not override dropdown styles
* crop images to the circle bounds
* add hover interaction for home links
* add notification in dropdown
* add styles to notification
* typo
* responsive adjustments
* restore file from develop
* apply 12-cols pattern
* replace details-summary
* replace details-summary mobile
* fix a11y tests
* replace accordion with dropdown
* replace accordion with dropdown (mobile)
* fix avatar menu trigger
* Participatory processes manage content blocks (#10230)
* Add content blocks admin management for participatory processes
* Reuse html content blocks defined in process groups for processes also
* Define redesigned html content block
* Add shared tests for landing page admin and use them for groups and processes
* Fix tests
* Adapt management of content blocks for participatory processes landing page
* Update tests
* Redesign: menu breadcrumb (#10200)
* Add FooterMenuPresenter to display menu items in footer
* Set fixed links in redesigned_main_legal partial
* Fix translation call
* Define a cell for static_pages and topics configured to appear in footer
* Reorder elements in main links of footer and define links and texts
* Fix path method call
* Fix translation
* Replace h5 with h2 in footer pages cells topics titles
* Use redesigned participatory space layout with a content_for block
* Add dynamic breadcrumb root menu elements
* Recover menu
* Move content to partial
* Remove fixed text
* Allow passing options to activity cell from activities cell and define layout and author layout
* Define a cell for last activities in breadcrumb root
* Add comment
* Fix deprecated method use
* Allow action buttons in menu to be defined from participatory spaces layouts
* Allow definition of extra breadcrumb elements from participatory spaces
* Define current space item and dropdown from participatory processes
* Remove :participatory_space_menu content_for element
* Integrate menu breadcrumb for mobile and tablet
* Remove unused partials
* Fix link and translation
* Fix linter offense and indentation
* Avoid accessibility validation errors in mobile version when secondary dropdown is blank
* Add links to breadcrumbs when url defined
* Fix headers hierarchy
* Define generic participatory space dropdown metadata cell
* Inherit process_dropdown metadata cell from generic cell
* Define assembly dropdown metadata cell
* Define current_participatory_space_breadcrumb_item for assemblies
* Remove useless blank line
* Define conference dropdown metadata cell
* Define current_participatory_space_breadcrumb_item for conferences
* refactor breadcrumb desktop
* refacto main dropdown
* refactor secondary dropdown
* Reorder methods
* Use diferent id for repeated element of breadcrumb
* style glitches breadcrumb
* Remove layout in activities cell and include author
* Revert changes in activity cell
* generalize font size
* fix erblint
* fix a11y test
* replace details-summary mobile
* Use an option to hide participatory space on activities of secondary dropdown
* Use a different id prefix to cache and generate ids of activities depending on the participatory space
* Disable links on breadcrumb items when current path is the same
* Revert hide_participatory_space option in activity cell
The changes come from processes branch
* replace accordion with dropdown
* replace accordion with dropdown (mobile)
* remove dummy code
* Fix typo
Co-authored-by: Fernando Blat <fernando@blat.es>
* Mark partial to be integrated with redesign
* Add comment to explain current_participatory_space_breadcrumb_item
* fix user interaction glitches
---------
Co-authored-by: Hugoren Martinako <aumpfbahn@gmail.com>
Co-authored-by: Fernando Blat <fernando@blat.es>
* Rebase Develop branch into feature/redesign (#10322)
* Fix dependency resolver trying to fetch gem paths from lazy specifications (#10220)
* Ensure we are not returning lazy specifications
The lazy specification is not responding to the `#full_gem_path`
method which causes the dependency resolving to fail under newer
bundler versions and also in the situation that the newest
installed bundler version differs from the locked bundler version.
* Fix the expecation in the dependency resolver spec
* Added Reporting time in Global Moderation / Users (#10213)
* added-reported-time-to-user-moderations
* deleted-extra-line
* locale-changes
* fields reorder/contentmoderations - localizations revert
* fixed tests
* Removed "disabled" status from proposals' main categories (#10216)
* removed-main-category-disabling
* fixed-a-typo
* Fix double parentheses in the titled upload modal with existing attachment (#10221)
* Fix pipeline asset absolute URLs (#9597)
* Rename Decidim::AssetRouter to Decidim::AssetRouter::Storage
* Implement pipeline asset router
* Fetch the avatar default URLs through Decidim::AssetRouter::Pipeline
* Add specs for the avatar uploader
* Fix failing spec for NilPresenter
* Rubocop
* Fix spec after merge
* Fix the pipeline spec after merge
* Improve link handling of the redirect engine (#10235)
* Added links and nickname fields to User Group Admin panel (#10236)
* added-nickname-field-to-usergroups
* Added missing localizations (#10210)
* added-missing-localizations
* test-fixes
* additional-localizations-added
* comment-edit/date-format
* Switch to GitHub concurrency in CI (#10133)
* Switch to GitHub concurrency
* Rename the API CI workflow name
* Revert "Rename the API CI workflow name"
This reverts commit defe599bdcb16defa3d8589bdc7610d3c8a60279.
* send notifications after transaction (#10211)
* Fix Pipeline after #10211 (#10240)
* Fix initiatives count in initiatives index page (#10150)
* Multi content blocks with the same manifest for the same page and section content block for ToS (#10166)
* Multiple content blocks for landing page and add sections to static page
* Fix two-pane section view
* Fix rubocop offense and normalize locales
* Fix static page update method
* Add class to content blocks card
* Fix spec/system/admin_manages_static_page_content_blocks_spec.rb tests
* Fix spec/system/admin_manages_organization_homepage_spec.rb tests
* Fix spec/commands/decidim/admin/reorder_content_blocks_spec.rb tests
* Fix spec/forms/static_page_form_spec.rb tests
* Fix spec/system/admin/admin_manages_participatory_process_group_landing_page_spec.rb tests
* Add new tests for deleting content blocks and creating multiple with the same manifest on the same page
* Fix unused argument
* Suggestions after review applied
* Remove unused i18n keys
* Add summary content block seed only for terms-and-conditions page
* Fix where to show content blocks on tabbed view
* Configuration to allow content blocks on specific pages
* Move commands and concern into a new Decidim::Admin::ContentBlocks namespace
* Fix spec/commands/decidim/admin/reorder_content_blocks_spec.rb tests
* Fix spec/commands/decidim/admin/create_newsletter_spec.rb tests
* Fix commands tests
* Move content of page_blocks config_accessor to decidim-generators
* User's group endorsement no longer disappears after personal endorsement removed (#10223)
* Fixed group endorsement removal when personal endorsement removed & tests
* test-fixes
* Add Backports documentation process explanation (#10248)
* Add Backports documentation process explanation
* Add link to backporter script
* Fix typo
Suggested by code review
* Add example and documentation for backporter script
* Sync release branch with remote before backporting (#10222)
* Fix notifications page when vapid is not available (#10286)
* User's group endorsement no longer disappears after personal endorsement removed
* Fixed group endorsement removal when personal endorsement removed & tests
* test-fixes
* Fix the notification settings when vapid keys are not present
---------
Co-authored-by: JoonasAapro <110532525+JoonasAapro@users.noreply.github.com>
* Update picmo to 5.7.3 (#10291)
* Replace webpush with web-push to support OpenSSL V3 (#10207)
* Replace webpush with web-push to support OpenSSL V3
* Restore Ruby version
* Export proposal body without HTML tags (#9913)
* Remove HTML tags in proposal body in exports
* Light proposal serializer specs refactor
* Remove proposal body HTML tags using decidim_sanitize
* Implement HTMLToPlainText in proposal serializer
* Remove SanitizeHelper from proposal serializer
* Refactor proposal serializer spec
* Strip tags recursively for proposal body
* Refactor specs file
* Refactor proposal serializer service
* Prevent aria-describedby attribute being added to hidden inputs (#10022)
* Add ability to pass extra attributes for authorization creation (#10320)
---------
Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>
Co-authored-by: JoonasAapro <110532525+JoonasAapro@users.noreply.github.com>
Co-authored-by: Ivan Vergés <ivan@platoniq.net>
Co-authored-by: Heiner Sameisky <hei.sam@gmail.com>
Co-authored-by: Fran Bolívar <francisco.bolivar@nazaries.com>
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Co-authored-by: Quentin Champenois <26109239+Quentinchampenois@users.noreply.github.com>
* Redesign: tooltips (#10212)
* tooltip variations
* keep the tooltip visible on hover
* refactor tooltips logic and helper
* Update decidim-core/app/helpers/decidim/tooltip_helper.rb
Co-authored-by: Fernando Blat <fernando@blat.es>
* fix code reviews
* restore argument
---------
Co-authored-by: Fernando Blat <fernando@blat.es>
* Redesign: Content block - Hero (#10318)
* hero block styles
* fix erblint
* remove unnecessary specs, if there was no link, click_link will fail as now does
* set aspect-ratio for the hero image
* adapt test to allow multiple values
* ignore tests due to old design
* Redesign: Skip to content (#10317)
* include link in header to main content
* remove deprecated file
* restore default outline
---------
Co-authored-by: Fernando Blat <fernando@blat.es>
* Redesign: statistics as content-block (#10324)
* refactor statistics cell to be reusable
* move the container outside of the cell
* wrong file references
* fix specs after block modification
---------
Co-authored-by: Fernando Blat <fernando@blat.es>
* Redesign: last activities (#10327)
* refactor last activities views
* show empty message
* add vertical flow
* update dropdown when filtering is called
* fix i18n
* fix failing tests
* remove unnecessary class
* all items at first position
* Move activities filter to a cell and use it in user public profile and site activities
* Fix translation reference
* Fix translation
* Fix test
* Move mocked method
* Redefine method and avoid memoization
* Avoid exceptions when a constant name passed to resource_types_filter_cell is undefined
---------
Co-authored-by: Eduardo Martinez Echevarria <eduardomech@gmail.com>
* Feature/redesign revert drawers (#10329)
* Remove drawers and references to turbo
* Add comment for redesign in drawer layout
* Update selector in tests
* Update references to drawer in comments and names
* Don't change the cell name when redesign is disabled if redesigned_ prefix is used explicitly
* Recover test
* Unify tests to expect the same behavior with redesign enabled and not
* Fix selectors in tests
* Recover skipped tests working with redesign enabled and not
* Use redesigned cell version always and recover skipped tes
* Remove turbo gem dependency
* Remove turbo packages dependencies
* Remove turbo-rails gem from Gemfile.lock files in app-design and generators
* Add comments to remaining code using drawer term
* Move before block to context to ensure creation of group
* Ensure initialization on remote-modal:loaded event
* Avoid picmo regression
* Fix package version
---------
Co-authored-by: Fernando Blat <fernando@blat.es>
* Redesign: proposals block & card L (#10170)
* proposals block
* add space to span
* Normalize locales
* Add comments count and official? to card metadata cell
* Reorder methods
* Add endorsements count to default card metadata cell
* Allow calling a cell as card metadata item
* Add authorship items to card metadata cell
* Define metadata proposal card cell based on generic attributes
* Sanitize title ind card l cell
* Fix selectors in proposals cards tests
* Add an emendation label to card_metadata_cell
* Add state item to proposal metadata card
* Add an extra class to proposals l card
* Update tests
* replace CSS classes by ids
* Sanitize participatory space title in metadata item
* Reduce if-else nesting
* Update selectors in tests
* Skip maybe deprecated tests
* Remove methods duplicated after merge
---------
Co-authored-by: Eduardo Martinez Echevarria <eduardomech@gmail.com>
Co-authored-by: Fernando Blat <fernando@blat.es>
* Redesign: processes & assemblies (static blocks) (#10005)
* initial setup processes
* floating help styles
* isolate component, provide js functionality
* reuse cards for index
* add metadata to the cards
* responsive index titles
* use new layout for redesigned process
* include paginator
* remove debug code
* filters (mockup) index process
* cherry pick frontend rearrangement
* remove partial in favour of cell
* add callout flow
* main distribution in blocks
* process info metadata
* process metadata block
* phases modal
* phase steps connection line
* assets in show are loaded in their layout
* mobile introduction block
* navigation bar process
* Show only ToS acceptance when admin hasn't accepted it (#9907)
* Don't show the 'Activity' card in dashboard if admin didn't accepted the ToS
* Don't show the 'Global moderations' menu if admin didn't accepted the ToS
* Extract spec to a shared example
* Don't show the 'Participants' menu if admin didn't accepted the ToS
* Fix CTA button copy
* Don't show the 'Templates' menu if admin didn't accepted the ToS
* Don't show the 'Initiatives' menu if admin didn't accepted the ToS
* Add system spec
* Fix specs
* Add example for ToS acceptance in 'Global moderations'
* Fix spec
* Add example for ToS acceptance in 'Space moderations'
* Fix guard clause when admin is managing users
* Fix usages of sanitize helper methods for editable content provided by admins (#10007)
* Fix usages of sanitize helper methods for editable content provided by admins.
Related issue: https://github.com/decidim/decidim/issues/9927
Fixes usages of sanitize for `description` of `ParticipatoryProcess` and `ParticipatoryProcessGroup`.
* Fix usages of sanitize for `description` of assembly, conference and voting. Unify spec test.
* Fix usages of sanitize for `short_description` of conference.
* Always allow image upload in WYSWYG editor (#10011)
* Disable editor_images option in WYSWYG editor
* Correct rubocop offenses
* Fix running DB commands consecutively (#9607)
* Reset column information before seeds on loaded record classes
* Add spec for running db commands consecutively
* Load the templates engine in the surveys engine
Otherwise the templates migrations are not copied to the app
unless the templates module is define in the Gemfile, although
it is a requirement ofr surveys.
* Try sub-command without bundle exec in CI
* Revert "Try sub-command without bundle exec in CI"
This reverts commit 66e4361df6a5e423773b6c1ed2316d209dbaccb4.
* Try running sub-command with original env
* Fix ActiveRecord descendants checks for abstrac test classes
* New Crowdin updates (#9486)
* New translations en.yml (Italian)
* New translations en.yml (Hungarian)
* New translations en.yml (Japanese)
* New translations en.yml (Basque)
* New translations en.yml (Basque)
* New translations en.yml (Greek)
* New translations en.yml (German)
* New translations en.yml (Czech)
* New translations en.yml (Catalan)
* New translations en.yml (Arabic)
* New translations en.yml (Basque)
* New translations en.yml (Spanish)
* New translations en.yml (Latvian)
* New translations en.yml (Indonesian)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (French, Canada)
* New translations en.yml (Luxembourgish)
* New translations en.yml (Portuguese, Brazilian)
* New translations en.yml (Dutch)
* New translations en.yml (Galician)
* New translations en.yml (Chinese Simplified)
* New translations en.yml (Turkish)
* New translations en.yml (Swedish)
* New translations en.yml (Slovak)
* New translations en.yml (Portuguese)
* New translations en.yml (Polish)
* New translations en.yml (Norwegian)
* New translations en.yml (Lithuanian)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Finnish (plain))
* New translations en.yml (Finnish (plain))
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (Finnish)
* New translations en.yml (French)
* New translations en.yml (Japanese)
* New translations en.yml (French, Canada)
* New translations en.yml (Romanian)
* New translations en.yml (Dutch)
* New translations en.yml (Italian)
* New translations en.yml (Japanese)
* New translations en.yml (Japanese)
* New translations en.yml (Lithuanian)
* New translations en.yml (Lithuanian)
* New translations en.yml (Dutch)
* New translations en.yml (Norwegian)
* New translations en.yml (Hungarian)
* New translations en.yml (Polish)
* New translations en.yml (Romanian)
* New translations en.yml (Czech)
* New translations en.yml (French)
* New translations en.yml (French)
* New translations en.yml (Spanish)
* New translations en.yml (Spanish)
* New translations en.yml (Arabic)
* New translations en.yml (Bulgarian)
* New translations en.yml (Catalan)
* New translations en.yml (Catalan)
* New translations en.yml (Czech)
* New translations en.yml (Irish)
* New translations en.yml (Danish)
* New translations en.yml (German)
* New translations en.yml (Greek)
* New translations en.yml (Basque)
* New translations en.yml (Finnish)
* New translations en.yml (Finnish)
* New translations en.yml (Slovak)
* New translations en.yml (Portuguese)
* New translations en.yml (Swedish)
* New translations en.yml (Swedish)
* New translations en.yml (Slovenian)
* New translations en.yml (Chinese Simplified)
* New translations en.yml (Turkish)
* New translations en.yml (Galician)
* New translations en.yml (Portuguese, Brazilian)
* New translations en.yml (Galician)
* New translations en.yml (Icelandic)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Latvian)
* New translations en.yml (French, Canada)
* New translations en.yml (French, Canada)
* New translations en.yml (Luxembourgish)
* New translations en.yml (Sinhala)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Finnish (plain))
* New translations en.yml (Finnish (plain))
* New translations en.yml (French)
* New translations en.yml (French)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (French)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Czech)
* New translations en.yml (Guarani)
* New translations en.yml (Portuguese, Brazilian)
* New translations en.yml (Polish)
* New translations en.yml (Polish)
* New translations en.yml (Polish)
* New translations en.yml (Polish)
* New translations en.yml (Polish)
* New translations en.yml (Romanian)
* New translations en.yml (Spanish)
* New translations en.yml (French)
* New translations en.yml (Bulgarian)
* New translations en.yml (Arabic)
* New translations en.yml (Czech)
* New translations en.yml (Catalan)
* New translations en.yml (German)
* New translations en.yml (Danish)
* New translations en.yml (Greek)
* New translations en.yml (Basque)
* New translations en.yml (Irish)
* New translations en.yml (Finnish)
* New translations en.yml (Hungarian)
* New translations en.yml (Japanese)
* New translations en.yml (Italian)
* New translations en.yml (Lithuanian)
* New translations en.yml (Norwegian)
* New translations en.yml (Dutch)
* New translations en.yml (Portuguese)
* New translations en.yml (Polish)
* New translations en.yml (Slovak)
* New translations en.yml (Chinese Simplified)
* New translations en.yml (Turkish)
* New translations en.yml (Swedish)
* New translations en.yml (Icelandic)
* New translations en.yml (Galician)
* New translations en.yml (Indonesian)
* New translations en.yml (Portuguese, Brazilian)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Latvian)
* New translations en.yml (French, Canada)
* New translations en.yml (Luxembourgish)
* New translations en.yml (Serbian (Latin))
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Ukrainian with many plural form)
* New translations en.yml (Finnish (plain))
* New translations en.yml (Russian with many plural form)
* New translations en.yml (French)
* New translations en.yml (French, Canada)
* New translations en.yml (Swedish)
* New translations en.yml (Basque)
* New translations en.yml (Romanian)
* New translations en.yml (Galician)
* New translations en.yml (Portuguese, Brazilian)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (French, Canada)
* New translations en.yml (Luxembourgish)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Turkish)
* New translations en.yml (French)
* New translations en.yml (Spanish)
* New translations en.yml (Arabic)
* New translations en.yml (Catalan)
* New translations en.yml (Czech)
* New translations en.yml (German)
* New translations en.yml (Greek)
* New translations en.yml (Basque)
* New translations en.yml (Finnish)
* New translations en.yml (Hungarian)
* New translations en.yml (Swedish)
* New translations en.yml (Italian)
* New translations en.yml (Japanese)
* New translations en.yml (Lithuanian)
* New translations en.yml (Dutch)
* New translations en.yml (Norwegian)
* New translations en.yml (Polish)
* New translations en.yml (Portuguese)
* New translations en.yml (Finnish (plain))
* New translations en.yml (French)
* New translations en.yml (Basque)
* New translations en.yml (French, Canada)
* New translations en.yml (Romanian)
* New translations en.yml (Romanian)
* New translations en.yml (Romanian)
* New translations en.yml (Romanian)
* New translations en.yml (Romanian)
* New translations en.yml (Romanian)
* New translations en.yml (Romanian)
* New translations en.yml (Romanian)
* New translations en.yml (Romanian)
* New translations en.yml (Romanian)
* New translations en.yml (Romanian)
* New translations en.yml (Romanian)
* New translations en.yml (Spanish)
* New translations en.yml (Spanish)
* New translations en.yml (Spanish)
* New translations en.yml (Catalan)
* New translations en.yml (Catalan)
* New translations en.yml (Catalan)
* New translations en.yml (Spanish)
* New translations en.yml (Spanish)
* New translations en.yml (Spanish)
* New translations en.yml (Spanish)
* New translations en.yml (Spanish)
* New translations en.yml (Spanish)
* New translations en.yml (Catalan)
* New translations en.yml (Catalan)
* New translations en.yml (Catalan)
* New translations en.yml (Catalan)
* New translations en.yml (Catalan)
* New translations en.yml (Catalan)
* New translations en.yml (Catalan)
* New translations en.yml (Finnish)
* New translations en.yml (Finnish)
* New translations en.yml (Finnish)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Finnish (plain))
* New translations en.yml (Finnish (plain))
* New translations en.yml (Finnish (plain))
* Add note to merge the Crowdin PRs in all releases (#10076)
* Clarify the changelog instructions in the release process documentation (#10066)
* Redesign: upload modal (#9858)
* prepare update-modal cell
* clean conversations modal as of the shared styles
* shared html styles for modals
* workaround: redesign_enabled? not working on cells called from helper
* full refactor upload modal files
* fix linters
* fix styles dropzone
* handle asynchronous validations
* general fixes and new casuistics
* fix dragover highlight & remove files on cancel
* update dropzone when errors
* add space to files
* Prepare button to open login modal to work with redesigned and legacy layouts
* Split upload modal cell in legacy and redesigned versions and allow to call it passing a redesign option
* Call upload method passing the redesigned option based on the context
* Fix linter offense
* Normalize locale file
* eslint consistent-return
* eslint consistent-return
* Update test
* move action button to the right if it's the only child
* rearrangement frontend libraries
* fix upload modal after redesigned assets
* remove current image block (fix removal error)
* preview image
* good version files.erb
* Fix external_link initialization in legacy design index.js
* Force flaky test
* Fix attachment blob call
* Remove unused attachment label method
* Display default image if defined and no uploaded attachments
* Update test
* Update selector in test
* Revert "Force flaky test"
This reverts commit 075f6eb77d46193d0977d37d1e8e7942e08ca3c4.
* Improve deprecation after redesign documentation in js file
* overflow dropzone auto
* disabled form submit when there are erorrs on the files
* reset dropzone on cancel
* pass argument multiple
* update translation
* better looking responsive
* disable save only when errors & mark as removable
* include logic to remove the current uploaded item
* Delegate redesign_enabled? to template in form builder
* fixes frontend upload modal
* Fix form_builder spec to take redesign into account
* avoid drag flickering on webkit browsers
* Avoid errors in determine_filename when attachment class is ActionDispatch::Http::UploadedFile
* avoid string commas in errors array
Co-authored-by: Eduardo Martinez Echevarria <eduardomech@gmail.com>
* Implement ToS summary (#9222)
* feat(privacy_policy): Manage privacy policy as a content_block
* feat(privacy_policy): add summary to sign up
* chore(sign_up): privacy_policy link target blank
* fix rubocop issues
* fix: privacy_policy unused_manifests method
* feat(core): add seed for privacy policy summary
* feat(spec): add system/admin_manages_organization_privacy_policy_spec.rb
* refactor: move from settings to static_pages, rename to ToS
* chore(css): tweak sign_up ToS text styles
* fix(i18n): remove unused keys
* feat(seeds): add ToS summary content_block
* fix specs
* add summary content block to tabbed page view
* Fix rubocop offenses
* Add migration to move terms and conditions page content to content_block
* Keep the content of the tos page even with summary content block active
* Fix test
* Show summary section in ToS page
Co-authored-by: Francisco Bolívar <francisco.bolivar@nazaries.com>
* Run ERBlinter on modified files (#9868)
* boost the ERBlinter filtering the scanned files
* Test simpler setup
* Test another syntax
* handle no files exit code
* Get back the initial command
* Add erblint to package.json of design app
* remove linter from npm
* lint all views for merges
* Update run_erblint.sh
* Update .github/run_erblint.sh
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
* Update .github/run_erblint.sh
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Co-authored-by: Eduardo Martinez Echevarria <eduardomech@gmail.com>
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
* Improve the release_all rake task with multiple remotes (#10077)
- Add check that we have decidim/decidim as one of the remotes
- Fetch the existing tags before doing the release
- Define the release remote to the correct remote (decidim/decidim)
* Enable newsletters for admin on seeds (#10073)
* Enable newsletters for admin on seeds
* Enable newsletters for a couple more users on seeds
* Allow blocking a UserGroup (#10021)
* Fix comment (probably a copypasta)
* Make Users find compatible with UserGroups
* Add specs for blocking/unblocking a User or a UserGroup
* Recover user_name from extended_data when unblocking
* Redirect to users moderation panel instead of users/officializations
* Return 404 when the UserGroup is blocked
* Move the associations to the UserBaseEntity model
* Fix override of extended_data attribute in UserGroups factory
* Fix spec
* Add slash in PR linter configuration (#10074)
To only catch when someones leave the default title when working with
`hub` or `gh`, that's the default branch, and not when someone uses
"Refactor XXX" as title.
* Enhance templates engine (#10015)
* Refactor templates engine
* Running linters
* Apply review Recommendations
* Implement last review reccomendations
* Apply the latest recommendation changes
* Apply clarified review recommendations
* Fix wrong capitalization in i18n values and add missing keys (#10072)
* Fix wrong capitalization in i18n values
* Add missing i18n keys
* Replace 'Weight' with 'Order position'
So its consistent in all the forms.
* Fix key for meeting agenda item
* Remove unused attribute for show_embedded_iframe
* Fix key for scope
* Normalize :en locale
* Fix spec
* Fix typo
Suggested by code review
Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>
* Fix column reference on Topic
Suggested by code review
Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>
Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>
* merge item-list into card css component
* remove redesigned card cell (deprecated)
* landing processes
* give some margin to any sibling of a callout
* do not style dynamic content inside the cards
* floating help default status as tip, not block
* add card "G" cell for process card grids
* set content blocks for processes & accountability
* Revert "remove redesigned card cell (deprecated)"
This reverts commit 9300a1af2d7f2f6000cf747fc0290f71ac73e57b.
* Remove redesigned_process cell and define process size l card
* add reference code to the bototm
* block activity (pending integration)
* blog section
* missing block title
* handle full layout html block
* reduce description characters
* create post_g cell
* set color only to the title, not the whole block
* don't use custom editor text for card descriptions
* update markup modal steps
* add process description page
* add metrics content block
* prepare assemblies assets (orgchart removed)
* fix hover floating help
* update index files dependencies
* assembly cell type G
* move new filters view to shared
* mark as deprecated
* move results to partials
* update tests & references
* update js returned results
* assemblies show
* replace attachments_for with atomic content
* set margins for container
* add link to index in assemblies
* remove helper for assemblies
* refactor the way to draw the charts
* demo cell activities
* move activity styles from profile to independent component
* replace custom css with component class
* fix erblint
* update the floating help for conferneces from processes
* Fix key used to get url in process_nav_item partial
* include author conditionally
* don't enforce font-size on component
* remove spaces from the component, set them in the container
* Use an option to hide participatory space on activities cell
* Adapt test selectors
* Unify method changing behavior with redesign and adapt shared example to both cases
* Skip test pending of integration of breadcrumb
* Recover partial used by legacy design
* Fix linter offenses
* Skip some tests deprecated after redesign
* Remove deprecated partials en assemblies and processes
* Remove unused translations
* Add redesign pending comments
* Fix nav items generation in assembly space
* Use snippets to include assets in cell
* Remove unused translations
* remove old code
* hide endorsers on mobile
* style glitches
* Remove unused translations
* switch flex to grid for responsiveness
* grow time container
---------
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Co-authored-by: Sergei Krylov <sergei.krylov@yahoo.com>
Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>
Co-authored-by: decidim-bot <decidim-bot@users.noreply.github.com>
Co-authored-by: Eduardo Martinez Echevarria <eduardomech@gmail.com>
Co-authored-by: Agusti B.R <agustibr@users.noreply.github.com>
Co-authored-by: Francisco Bolívar <francisco.bolivar@nazaries.com>
Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
* Feature/redesign proposals tests fixes (#10377)
* Fix test
* Use a data-author attribute in redesigned author cell
* Force the use of redesigned author cell in other cells using it
* Update have_author matcher in test
* Update selectors in test
* Use presenter version of title on proposal l cell
* Skip temporarily tests related with proposals votes
REDESIGN_PENDING - The mechanism to vote proposals from index is pending
and also the metadata displaying the votes count
* Exclude file with TODOs in decidim_app-design from codeclimate checks
* Change selector in tests
* Update have_author matchers in tests
* Change selector of author in cells tests
* Change test to check proposals block inside a process
* Skip test of redesign pending behaviour
* Remove Turbo references
* Add missing locale
* Fix pending comment
* Update test selectors
* Update keys sent to server
* Redesign: timeout modal (#10373)
* adapt timeout controller to use new dialogs library
* duplicate files to avoid error on admin part
---------
Co-authored-by: Fernando Blat <fernando@blat.es>
* Offense
* Adjust specs
* Offenses
* Skip debates and proposals report spec
* Redesign: fonts (#10417)
* include the updated file fonts (new glyphs)
* fix stylelint
* move the flag modal outside of the comment header
* Skip tests until redesign is enabled
* replace details-summary into a11y component
* better design comments
* better mobile comments
* opinion on comments
* override default styles
* update html markup on tests
* avoid external link when polling is triggered
* Fix focusGuard setup on scoped elements
* add explanations for a future development
* Redesign: Newsletter modal (#10428)
* ensure tos modal
* add a11y description
* remove linebreaks
* Redesign: cookies (#10366)
* update & adapt application layout from develop
* floating bottom banner
* handle click cookies banner
* refactor cookies modal
* set cursor only to the accordion trigger
* footer triggers cookie modal
* make the title + arrow clickable
* change structure to a11y
* fix stylelint
* do not include a div inside button
* do not use button
* better responsiveness for modal actions
* fix stylelint
* fix core tests (skip for redesigning)
* fix rubocop
* fix tests
* Fix spec
* Update selector
* Fix var name, use redesigned assets
* remove transition needless
* Fix test
---------
Co-authored-by: Fernando Blat <fernando@blat.es>
Co-authored-by: Eduardo Martinez Echevarria <eduardomech@gmail.com>
* Redesign: floating tip turns into modal (#10388)
* fix odd positioning tip
* adapt tip to the button styles & fix mobile position
* turns tip helper into a modal
* place tip relative to data-content block
* Redesign: map popup (#10335)
* include custom popup content for meetings
* increase map size on mobile
* overwrite custom styles for leaflet popup
* keep the map icons setup simple (remove legacy stuff)
* show disfferent texts based on the meeting duration
* fix icon anchor position
* fix linter
* fix i18n
* use decidim date formats
* Include DateHelper in the correct cell
* Fix calculation of progress value
* Move dates and duration item to generic metadata cell
* Add tests for card-l and card_metadata cells
* let the popup transition by default
* wrap elements in leaflet popup
---------
Co-authored-by: Eduardo Martinez Echevarria <eduardomech@gmail.com>
* Offense
* Ignore visible check
* Skip test when redesign is disabled, because causes a JS error
* Skip tests for old design
* move the opinion block into the form
* add space between label-opinion and comment
* add text-decoration:underline if user select neutral opinion
* styles edited comment
* add dispatchEvent to add a comment
* remove profile and cell author
* remove a[href*=/users/sign_] styles
* add type="button" to opinion buttons to avoid the form submit when clicking on them
* replace div with button and remove tabindex
* clean duplicated class
* Redesign: Refuse TOS modal (#10431)
* style refuse tos modal
* fix i18n
* overwrite modal defaults
* Fix locale
---------
Co-authored-by: Fernando Blat <fernando@blat.es>
* Participatory spaces landing page content blocks (#10234)
* initial setup processes
* floating help styles
* isolate component, provide js functionality
* reuse cards for index
* add metadata to the cards
* responsive index titles
* use new layout for redesigned process
* include paginator
* remove debug code
* filters (mockup) index process
* cherry pick frontend rearrangement
* remove partial in favour of cell
* add callout flow
* main distribution in blocks
* process info metadata
* process metadata block
* phases modal
* phase steps connection line
* assets in show are loaded in their layout
* mobile introduction block
* navigation bar process
* Show only ToS acceptance when admin hasn't accepted it (#9907)
* Don't show the 'Activity' card in dashboard if admin didn't accepted the ToS
* Don't show the 'Global moderations' menu if admin didn't accepted the ToS
* Extract spec to a shared example
* Don't show the 'Participants' menu if admin didn't accepted the ToS
* Fix CTA button copy
* Don't show the 'Templates' menu if admin didn't accepted the ToS
* Don't show the 'Initiatives' menu if admin didn't accepted the ToS
* Add system spec
* Fix specs
* Add example for ToS acceptance in 'Global moderations'
* Fix spec
* Add example for ToS acceptance in 'Space moderations'
* Fix guard clause when admin is managing users
* Fix usages of sanitize helper methods for editable content provided by admins (#10007)
* Fix usages of sanitize helper methods for editable content provided by admins.
Related issue: https://github.com/decidim/decidim/issues/9927
Fixes usages of sanitize for `description` of `ParticipatoryProcess` and `ParticipatoryProcessGroup`.
* Fix usages of sanitize for `description` of assembly, conference and voting. Unify spec test.
* Fix usages of sanitize for `short_description` of conference.
* Always allow image upload in WYSWYG editor (#10011)
* Disable editor_images option in WYSWYG editor
* Correct rubocop offenses
* Fix running DB commands consecutively (#9607)
* Reset column information before seeds on loaded record classes
* Add spec for running db commands consecutively
* Load the templates engine in the surveys engine
Otherwise the templates migrations are not copied to the app
unless the templates module is define in the Gemfile, although
it is a requirement ofr surveys.
* Try sub-command without bundle exec in CI
* Revert "Try sub-command without bundle exec in CI"
This reverts commit 66e4361df6a5e423773b6c1ed2316d209dbaccb4.
* Try running sub-command with original env
* Fix ActiveRecord descendants checks for abstrac test classes
* New Crowdin updates (#9486)
* New translations en.yml (Italian)
* New translations en.yml (Hungarian)
* New translations en.yml (Japanese)
* New translations en.yml (Basque)
* New translations en.yml (Basque)
* New translations en.yml (Greek)
* New translations en.yml (German)
* New translations en.yml (Czech)
* New translations en.yml (Catalan)
* New translations en.yml (Arabic)
* New translations en.yml (Basque)
* New translations en.yml (Spanish)
* New translations en.yml (Latvian)
* New translations en.yml (Indonesian)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (French, Canada)
* New translations en.yml (Luxembourgish)
* New translations en.yml (Portuguese, Brazilian)
* New translations en.yml (Dutch)
* New translations en.yml (Galician)
* New translations en.yml (Chinese Simplified)
* New translations en.yml (Turkish)
* New translations en.yml (Swedish)
* New translations en.yml (Slovak)
* New translations en.yml (Portuguese)
* New translations en.yml (Polish)
* New translations en.yml (Norwegian)
* New translations en.yml (Lithuanian)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Finnish (plain))
* New translations en.yml (Finnish (plain))
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (Finnish)
* New translations en.yml (French)
* New translations en.yml (Japanese)
* New translations en.yml (French, Canada)
* New translations en.yml (Romanian)
* New translations en.yml (Dutch)
* New translations en.yml (Italian)
* New translations en.yml (Japanese)
* New translations en.yml (Japanese)
* New translations en.yml (Lithuanian)
* New translations en.yml (Lithuanian)
* New translations en.yml (Dutch)
* New translations en.yml (Norwegian)
* New translations en.yml (Hungarian)
* New translations en.yml (Polish)
* New translations en.yml (Romanian)
* New translations en.yml (Czech)
* New translations en.yml (French)
* New translations en.yml (French)
* New translations en.yml (Spanish)
* New translations en.yml (Spanish)
* New translations en.yml (Arabic)
* New translations en.yml (Bulgarian)
* New translations en.yml (Catalan)
* New translations en.yml (Catalan)
* New translations en.yml (Czech)
* New translations en.yml (Irish)
* New translations en.yml (Danish)
* New translations en.yml (German)
* New translations en.yml (Greek)
* New translations en.yml (Basque)
* New translations en.yml (Finnish)
* New translations en.yml (Finnish)
* New translations en.yml (Slovak)
* New translations en.yml (Portuguese)
* New translations en.yml (Swedish)
* New translations en.yml (Swedish)
* New translations en.yml (Slovenian)
* New translations en.yml (Chinese Simplified)
* New translations en.yml (Turkish)
* New translations en.yml (Galician)
* New translations en.yml (Portuguese, Brazilian)
* New translations en.yml (Galician)
* New translations en.yml (Icelandic)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Latvian)
* New translations en.yml (French, Canada)
* New translations en.yml (French, Canada)
* New translations en.yml (Luxembourgish)
* New translations en.yml (Sinhala)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Finnish (plain))
* New translations en.yml (Finnish (plain))
* New translations en.yml (French)
* New translations en.yml (French)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (French)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Czech)
* New translations en.yml (Guarani)
* New translations en.yml (Portuguese, Brazilian)
* New translations en.yml (Polish)
* New translations en.yml (Polish)
* New translations en.yml (Polish)
* New translations en.yml (Polish)
* New translations en.yml (Polish)
* New translations en.yml (Romanian)
* New translations en.yml (Spanish)
* New translations en.yml (French)
* New translations en.yml (Bulgarian)
* New translations en.yml (Arabic)
* New translations en.yml (Czech)
* New translations en.yml (Catalan)
* New translations en.yml (German)
* New translations en.yml (Danish)
* New translations en.yml (Greek)
* New translations en.yml (Basque)
* New translations en.yml (Irish)
* New translations en.yml (Finnish)
* New translations en.yml (Hungarian)
* New translations en.yml (Japanese)
* New translations en.yml (Italian)
* New translations en.yml (Lithuanian)
* New translations en.yml (Norwegian)
* New translations en.yml (Dutch)
* New translations en.yml (Portuguese)
* New translations en.yml (Polish)
* New translations en.yml (Slovak)
* New translations en.yml (Chinese Simplified)
* New translations en.yml (Turkish)
* New translations en.yml (Swedish)
* New translations en.yml (Icelandic)
* New translations en.yml (Galician)
* New translations en.yml (Indonesian)
* New translations en.yml (Portuguese, Brazilian)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Latvian)
* New translations en.yml (French, Canada)
* New tran…
* Update JS tests
* Apply initializer to changed comments from polling
* Proper JS reprocessing when create comment
* Safer execution
* Prevent multiple execution of external links
* Trailing space
* create a fake id for accorions and dropdown if has none
* Typo
* Typo
* better paddings to dropdown items
* extract the styles from modal to modal_flag
* Offense
* Remove unused translations
* Redesign: meetings (#9830)
* Use version date in author cell
* Link to the last version show from meeting
* Remove index action on versions of meetings
* Simplify code and remove unused methods in versions cells
* turn the partial month into a cell
* include map in meetings block
* remove sticky from filter-container component
* Add a callback to replace url con drawer close event
* Allow passing a path argument to diff cell
* Use turbo to update diff view selection options
* Change method not present yet
* Add icons support to highlighted_meetings_for_component_cell
* Add path to year calendar inside component to cell
* Refactor meeting_month cell and update params
* Define year param and use it in year_calendar partial
* Update link
* Allow to redefine the item list default class
* Define meeting_l card and use it in lists
* Remove wrong file
* move logic to fuction
* Define duration of meeting metadata
* Display official metadata only when required
* Update meeting metadata in show action
* Extract dates and map of show to a cell
* Remove deprecations
* Fix announcement messages in meetings index
* Add redesigned filter form builder to generate redesigned filters, including nested ones
* Change the way to pass filter options to templates
* Integrate shared filters template
* Update values for filters in meetings index to use icons
* Fix value of root input hidden element
* Move filters list generation
* Fix generation of checkboxes_tree_id
* update item-list* classes with card__list*
* merge item-list into card css component
* Don't enable dropdown behaviour for blank root component of an item
* Put depending elements at the same level if the main leaf is blank ('all' option)
* Prevent errors if filter_text_form is called from a not redesinged part of application
* Add icons to filters options in meetings and general
* Setup meetings filters for index both in component and directory
* Remove unused partial
* Refactor month cell
* Fix id for panel-dropdown behavior at first level in filters
* Clean deprecations
* clean meetings content-block
* Fix year_calendar to work both in global and component context
* truncate large categories
* filters duplication on redesign
* Make data conditional in dropdown_label
* adapt script y markup to check/uncheck children
* Define a helper method to build a tree of checkboxes an array of values and labels
* Use trees for filter options in directory
* Fix linters and clean code
* Change default
* Use turbo_frames in meetings show
* better js-doc
* Define a Decidim::TurboHelper and use turbo in versions show view
* Refresh versions views using turbo
* Add missing translations to duration metadata format
* Avoid using filter_params in close filtered path of drawer when no params for filter exist
* filters checkbox recursives & indeterminates
* Fix element to refresh in filters
* Recover par page hidden field tag
* include note about the funtionality
* Remove commented turbo frame tag
* Remove not required turbo_frame_tag
* Add tabs to meeting drawer
* Add missing translations
* refactor images component
* Avoid errors if result l card is called from other component
* Use card_l on linked resources of accountability results
* Refactor generation of items
* Use meeting_l card on linked_meetings template
* Change translations and icons of tabs
* Add calendar modal (styles pending)
* Add styles to calendar modal
* duplicate layout live meetings
* live meetings header
* use the redesigned scripts
* Remove jQuery from script
* Move javascript to head to prevent Turbo issue
* Move foot scripts to body
* Remove broken links
* set max height for images
* Unify origin values for meetings filters
* Avoid initialize twice on turbo events
* Avoid initialize twice on turbo events
* Wrap drawer content inside a frame
* Wrap drawer content inside a frame
* Improve navigation between projects inside frames
* Launch a visit on onClose event of drawer
* Launch a visit on onClose event of drawer
* Change target frame on meetings navigation inside a drawer
* Move meeting frame from index to partial
* edit form inside live events
* Fix call to partial from cell
* fix registration modal markup
* fix cancelation modal markup
* editor content spans to max space
* change order cookies and stuff
* Move images and documents tabs content to cells to be shared in decidim-core
* Use unique ids for calendar share modals
* Update class of private meeting badge
* responsive drawer
* mark links in dynamic content
* increase calendar lg width
* create new meeting form
* Remove calendar link
* Avoid visit after drawer close
* Remove preview in meetings
* Set main frame
* Don't use a in close drawer element
* make form element block when they're surrounded by form__wrapper class
* adapt scripts to the head due to #10090
* add space after map
* minimal fixes live events
* Fix linter offenses
* block background scroll #10135
* fix scss lint
* fix stylelint
* Remove unused translations
* Add ignored keys to i18n-tasks
* Refactor highlighted meeetings content block to show past meetings and hide calendar link
* Fix translations calls
* actions flow meeting drawer aside
* close meeting form
* add more space desktop
* discard blocking the page when the drawer is open
* handle special case moving out of the drawer through links
* Disable turbo on meetings filter
* fix admin bar answer live event
* replace missing styles
* Move method to appropriate helper
* Consider redesign in test
* replace missing styles
* Add extra param required by decidim/version cell
* Fix tests of diff cell
* Fix tests of diff partials on some modules [WIP]
Updated on:
* Accountability
* Debates
* Initiatives
* Fix test about meetings in initiatives
* Normalize locales
* Fix package tests
* remove dummy map
* update read-only condition
* Fix expected selector in meeting_cell spec
* Add category metadata to meeting cell
* Remove disable_dynamic_change data option in meetings filter
* Replace url_calendar_url to share on refresh instead of removing modal
* Adapt tests in explore_meeting_directory
* Skip some tests when redesign is not fully enabled
* Adapt tests to redesign in meetings exploration
* Fix accountability tests
* Display correctly author of version when added as string
* Skip test with redesign disabled
* Move redesign_prepared skips to a helper
* Quick fix for filters with 'All' option marked
* Fix minutes format
* Fix tests and skip redesign dependent ones
* Fix selector in tests
* hide creation date on author
* remove border calendar small
* Skip redesign dependent tests
* Add comments count and withdrawn badge to metadata
* Enable redesign explicitly in meetings controllers
* Recover withdrawn feature in meetings list
* Add withdraw meeting button in meeting drawer
* Remove duplicated visits
* Create tests for attachments in drawers
* Fix selector in tests
* Skip redesign dependent tests
* Fix tests
* Remove deprecated test
* Remove unnecessary content_for
* Move js_content to body
* Remove preview of results
* Wrap results index in main frame
* Replace document with element in redesigned_index.js
* Move meeting_frame out of main_frame
* Move project_frame out of main_frame
* Update filtered path on index update
* Update filtered path on index update
* update filtered path on index.js
* avoid duplicates & ignore children if parent checked
* Update URL on results filter changes
* Add turbo_stream_action tag when main_frame is updated with filters to refresh filtered path and clear drawer
* Revert "Quick fix for filters with 'All' option marked"
This reverts commit 8fd154e526f7c6dcfd6a4b7aebaf32fd15d2f6b2.
* Remove unused translation
* Skip redesign dependent tests
* Update selectors
* Remove deprecated test
* Add missing dependency
* Allow calling diff cell without a path
* Add some test skips dependant of redesign
* Fix selectors in tests and remove deprecated ones
* Add some skips related with redesign
* Prevent errors ordering versions when calculated as an array instead of a relation
* Adapt proposals versions tests
* Fix tests
* Recover announcement callout in meetings index
* Disable Turbo when switching to admin
* Restore service worker pack
* Avoid visit after drawer close
* Don't refresh filter when index is called from show action
* Update test
* Ignore comments tests in meetings drawer pending of redesign integration
* Adapt meetings versions tests
* Update selector in test
* Update selectors in tests
* Fix tests of meetings edition
* Disable test pending of integration
* Fix tests
* Fix selector in test
* Fix tests
* Skip tests dependant of redesign
* Fix tests
* Skip deprecated tests
* Skip redesign pending tests about reporting in meetings drawer
* update translation
* Rename comments_count item in card metadata
* update tests with new literal
* fix meetings tests
* fix meetings tests
* Change header
* Display component name in meetings aside partial when the index refers to a component
* Use correct partial to display documents inside a meeting drawer
* add button for withdrawn meetings
* fulfill a11y
* Rename partial to be used in cells also
* fix overflowing mobile
* fix tests
* fix tests accountability
* fix tests meetings
Co-authored-by: Eduardo Martinez Echevarria <eduardomech@gmail.com>
Co-authored-by: Fernando Blat <fernando@blat.es>
* Implement card g (#10219)
* Define card_g cell
* Define progress item in metadata
* Define processes g cell
* Define post grid card
* Adjust description in card g cell
* Improve id generation in card g cell
* Hide metadata block from card_g if not defined or empty
* Define assemblies g cell
* Define conferences g cell
* Leave interactions item pending in process metadata
* Use highlighted card g for promoted assemblies conferences and processes in their indexes
* Correct PostGCell inheritance
* Don't use sanitize_editor on description
* avoid tailwind purging
* Fix linter offense
* Simplify progress span
* Enable process and process_group g cells and force it on promoted items of index
* Skip redesign pending accesibility tests
* Skip deprecated tests
* Fix tests in processes
* Enable assembly g cell and force it on promoted items of index
* Fix assembly test for highlighted items in index
* Fix conferences test for highlighted items in index
* Remove unused translations
* Fix typo
Co-authored-by: Fernando Blat <fernando@blat.es>
* Rename method to make purpose clearer
* Update decidim-assemblies/app/cells/decidim/assemblies/assembly_metadata_g_cell.rb
Co-authored-by: Fernando Blat <fernando@blat.es>
* Add deprecation redesign comments
* Revert delegation
* Use date instead of time for current date in metadata
* Remove wrong parentheses
* Delegate method
* Simplify method
* Remove partials
* Remove redundant condition
* Move values to constants
* Remove partials and invoke card-g from views directly
Co-authored-by: Hugoren Martinako <aumpfbahn@gmail.com>
Co-authored-by: Fernando Blat <fernando@blat.es>
* Fix dependency resolver trying to fetch gem paths from lazy specifications (#10220)
* Ensure we are not returning lazy specifications
The lazy specification is not responding to the `#full_gem_path`
method which causes the dependency resolving to fail under newer
bundler versions and also in the situation that the newest
installed bundler version differs from the locked bundler version.
* Fix the expecation in the dependency resolver spec
* Added Reporting time in Global Moderation / Users (#10213)
* added-reported-time-to-user-moderations
* deleted-extra-line
* locale-changes
* fields reorder/contentmoderations - localizations revert
* fixed tests
* Removed "disabled" status from proposals' main categories (#10216)
* removed-main-category-disabling
* fixed-a-typo
* Fix double parentheses in the titled upload modal with existing attachment (#10221)
* Fix pipeline asset absolute URLs (#9597)
* Rename Decidim::AssetRouter to Decidim::AssetRouter::Storage
* Implement pipeline asset router
* Fetch the avatar default URLs through Decidim::AssetRouter::Pipeline
* Add specs for the avatar uploader
* Fix failing spec for NilPresenter
* Rubocop
* Fix spec after merge
* Fix the pipeline spec after merge
* Improve link handling of the redirect engine (#10235)
* Added links and nickname fields to User Group Admin panel (#10236)
* added-nickname-field-to-usergroups
* Added missing localizations (#10210)
* added-missing-localizations
* test-fixes
* additional-localizations-added
* comment-edit/date-format
* Switch to GitHub concurrency in CI (#10133)
* Switch to GitHub concurrency
* Rename the API CI workflow name
* Revert "Rename the API CI workflow name"
This reverts commit defe599bdcb16defa3d8589bdc7610d3c8a60279.
* send notifications after transaction (#10211)
* Fix Pipeline after #10211 (#10240)
* Fix initiatives count in initiatives index page (#10150)
* Multi content blocks with the same manifest for the same page and section content block for ToS (#10166)
* Multiple content blocks for landing page and add sections to static page
* Fix two-pane section view
* Fix rubocop offense and normalize locales
* Fix static page update method
* Add class to content blocks card
* Fix spec/system/admin_manages_static_page_content_blocks_spec.rb tests
* Fix spec/system/admin_manages_organization_homepage_spec.rb tests
* Fix spec/commands/decidim/admin/reorder_content_blocks_spec.rb tests
* Fix spec/forms/static_page_form_spec.rb tests
* Fix spec/system/admin/admin_manages_participatory_process_group_landing_page_spec.rb tests
* Add new tests for deleting content blocks and creating multiple with the same manifest on the same page
* Fix unused argument
* Suggestions after review applied
* Remove unused i18n keys
* Add summary content block seed only for terms-and-conditions page
* Fix where to show content blocks on tabbed view
* Configuration to allow content blocks on specific pages
* Move commands and concern into a new Decidim::Admin::ContentBlocks namespace
* Fix spec/commands/decidim/admin/reorder_content_blocks_spec.rb tests
* Fix spec/commands/decidim/admin/create_newsletter_spec.rb tests
* Fix commands tests
* Move content of page_blocks config_accessor to decidim-generators
* User's group endorsement no longer disappears after personal endorsement removed (#10223)
* Fixed group endorsement removal when personal endorsement removed & tests
* test-fixes
* Redesign: main header layout glitches (#10182)
* extract all CSS from main-bar to header CSS file
* do not override dropdown styles
* crop images to the circle bounds
* add hover interaction for home links
* add notification in dropdown
* add styles to notification
* typo
* responsive adjustments
* restore file from develop
* apply 12-cols pattern
* replace details-summary
* replace details-summary mobile
* fix a11y tests
* replace accordion with dropdown
* replace accordion with dropdown (mobile)
* fix avatar menu trigger
* Participatory processes manage content blocks (#10230)
* Add content blocks admin management for participatory processes
* Reuse html content blocks defined in process groups for processes also
* Define redesigned html content block
* Add shared tests for landing page admin and use them for groups and processes
* Fix tests
* Adapt management of content blocks for participatory processes landing page
* Update tests
* Redesign: menu breadcrumb (#10200)
* Add FooterMenuPresenter to display menu items in footer
* Set fixed links in redesigned_main_legal partial
* Fix translation call
* Define a cell for static_pages and topics configured to appear in footer
* Reorder elements in main links of footer and define links and texts
* Fix path method call
* Fix translation
* Replace h5 with h2 in footer pages cells topics titles
* Use redesigned participatory space layout with a content_for block
* Add dynamic breadcrumb root menu elements
* Recover menu
* Move content to partial
* Remove fixed text
* Allow passing options to activity cell from activities cell and define layout and author layout
* Define a cell for last activities in breadcrumb root
* Add comment
* Fix deprecated method use
* Allow action buttons in menu to be defined from participatory spaces layouts
* Allow definition of extra breadcrumb elements from participatory spaces
* Define current space item and dropdown from participatory processes
* Remove :participatory_space_menu content_for element
* Integrate menu breadcrumb for mobile and tablet
* Remove unused partials
* Fix link and translation
* Fix linter offense and indentation
* Avoid accessibility validation errors in mobile version when secondary dropdown is blank
* Add links to breadcrumbs when url defined
* Fix headers hierarchy
* Define generic participatory space dropdown metadata cell
* Inherit process_dropdown metadata cell from generic cell
* Define assembly dropdown metadata cell
* Define current_participatory_space_breadcrumb_item for assemblies
* Remove useless blank line
* Define conference dropdown metadata cell
* Define current_participatory_space_breadcrumb_item for conferences
* refactor breadcrumb desktop
* refacto main dropdown
* refactor secondary dropdown
* Reorder methods
* Use diferent id for repeated element of breadcrumb
* style glitches breadcrumb
* Remove layout in activities cell and include author
* Revert changes in activity cell
* generalize font size
* fix erblint
* fix a11y test
* replace details-summary mobile
* Use an option to hide participatory space on activities of secondary dropdown
* Use a different id prefix to cache and generate ids of activities depending on the participatory space
* Disable links on breadcrumb items when current path is the same
* Revert hide_participatory_space option in activity cell
The changes come from processes branch
* replace accordion with dropdown
* replace accordion with dropdown (mobile)
* remove dummy code
* Fix typo
Co-authored-by: Fernando Blat <fernando@blat.es>
* Mark partial to be integrated with redesign
* Add comment to explain current_participatory_space_breadcrumb_item
* fix user interaction glitches
---------
Co-authored-by: Hugoren Martinako <aumpfbahn@gmail.com>
Co-authored-by: Fernando Blat <fernando@blat.es>
* Rebase Develop branch into feature/redesign (#10322)
* Fix dependency resolver trying to fetch gem paths from lazy specifications (#10220)
* Ensure we are not returning lazy specifications
The lazy specification is not responding to the `#full_gem_path`
method which causes the dependency resolving to fail under newer
bundler versions and also in the situation that the newest
installed bundler version differs from the locked bundler version.
* Fix the expecation in the dependency resolver spec
* Added Reporting time in Global Moderation / Users (#10213)
* added-reported-time-to-user-moderations
* deleted-extra-line
* locale-changes
* fields reorder/contentmoderations - localizations revert
* fixed tests
* Removed "disabled" status from proposals' main categories (#10216)
* removed-main-category-disabling
* fixed-a-typo
* Fix double parentheses in the titled upload modal with existing attachment (#10221)
* Fix pipeline asset absolute URLs (#9597)
* Rename Decidim::AssetRouter to Decidim::AssetRouter::Storage
* Implement pipeline asset router
* Fetch the avatar default URLs through Decidim::AssetRouter::Pipeline
* Add specs for the avatar uploader
* Fix failing spec for NilPresenter
* Rubocop
* Fix spec after merge
* Fix the pipeline spec after merge
* Improve link handling of the redirect engine (#10235)
* Added links and nickname fields to User Group Admin panel (#10236)
* added-nickname-field-to-usergroups
* Added missing localizations (#10210)
* added-missing-localizations
* test-fixes
* additional-localizations-added
* comment-edit/date-format
* Switch to GitHub concurrency in CI (#10133)
* Switch to GitHub concurrency
* Rename the API CI workflow name
* Revert "Rename the API CI workflow name"
This reverts commit defe599bdcb16defa3d8589bdc7610d3c8a60279.
* send notifications after transaction (#10211)
* Fix Pipeline after #10211 (#10240)
* Fix initiatives count in initiatives index page (#10150)
* Multi content blocks with the same manifest for the same page and section content block for ToS (#10166)
* Multiple content blocks for landing page and add sections to static page
* Fix two-pane section view
* Fix rubocop offense and normalize locales
* Fix static page update method
* Add class to content blocks card
* Fix spec/system/admin_manages_static_page_content_blocks_spec.rb tests
* Fix spec/system/admin_manages_organization_homepage_spec.rb tests
* Fix spec/commands/decidim/admin/reorder_content_blocks_spec.rb tests
* Fix spec/forms/static_page_form_spec.rb tests
* Fix spec/system/admin/admin_manages_participatory_process_group_landing_page_spec.rb tests
* Add new tests for deleting content blocks and creating multiple with the same manifest on the same page
* Fix unused argument
* Suggestions after review applied
* Remove unused i18n keys
* Add summary content block seed only for terms-and-conditions page
* Fix where to show content blocks on tabbed view
* Configuration to allow content blocks on specific pages
* Move commands and concern into a new Decidim::Admin::ContentBlocks namespace
* Fix spec/commands/decidim/admin/reorder_content_blocks_spec.rb tests
* Fix spec/commands/decidim/admin/create_newsletter_spec.rb tests
* Fix commands tests
* Move content of page_blocks config_accessor to decidim-generators
* User's group endorsement no longer disappears after personal endorsement removed (#10223)
* Fixed group endorsement removal when personal endorsement removed & tests
* test-fixes
* Add Backports documentation process explanation (#10248)
* Add Backports documentation process explanation
* Add link to backporter script
* Fix typo
Suggested by code review
* Add example and documentation for backporter script
* Sync release branch with remote before backporting (#10222)
* Fix notifications page when vapid is not available (#10286)
* User's group endorsement no longer disappears after personal endorsement removed
* Fixed group endorsement removal when personal endorsement removed & tests
* test-fixes
* Fix the notification settings when vapid keys are not present
---------
Co-authored-by: JoonasAapro <110532525+JoonasAapro@users.noreply.github.com>
* Update picmo to 5.7.3 (#10291)
* Replace webpush with web-push to support OpenSSL V3 (#10207)
* Replace webpush with web-push to support OpenSSL V3
* Restore Ruby version
* Export proposal body without HTML tags (#9913)
* Remove HTML tags in proposal body in exports
* Light proposal serializer specs refactor
* Remove proposal body HTML tags using decidim_sanitize
* Implement HTMLToPlainText in proposal serializer
* Remove SanitizeHelper from proposal serializer
* Refactor proposal serializer spec
* Strip tags recursively for proposal body
* Refactor specs file
* Refactor proposal serializer service
* Prevent aria-describedby attribute being added to hidden inputs (#10022)
* Add ability to pass extra attributes for authorization creation (#10320)
---------
Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>
Co-authored-by: JoonasAapro <110532525+JoonasAapro@users.noreply.github.com>
Co-authored-by: Ivan Vergés <ivan@platoniq.net>
Co-authored-by: Heiner Sameisky <hei.sam@gmail.com>
Co-authored-by: Fran Bolívar <francisco.bolivar@nazaries.com>
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Co-authored-by: Quentin Champenois <26109239+Quentinchampenois@users.noreply.github.com>
* Redesign: tooltips (#10212)
* tooltip variations
* keep the tooltip visible on hover
* refactor tooltips logic and helper
* Update decidim-core/app/helpers/decidim/tooltip_helper.rb
Co-authored-by: Fernando Blat <fernando@blat.es>
* fix code reviews
* restore argument
---------
Co-authored-by: Fernando Blat <fernando@blat.es>
* Redesign: Content block - Hero (#10318)
* hero block styles
* fix erblint
* remove unnecessary specs, if there was no link, click_link will fail as now does
* set aspect-ratio for the hero image
* adapt test to allow multiple values
* ignore tests due to old design
* Redesign: Skip to content (#10317)
* include link in header to main content
* remove deprecated file
* restore default outline
---------
Co-authored-by: Fernando Blat <fernando@blat.es>
* Redesign: statistics as content-block (#10324)
* refactor statistics cell to be reusable
* move the container outside of the cell
* wrong file references
* fix specs after block modification
---------
Co-authored-by: Fernando Blat <fernando@blat.es>
* Redesign: last activities (#10327)
* refactor last activities views
* show empty message
* add vertical flow
* update dropdown when filtering is called
* fix i18n
* fix failing tests
* remove unnecessary class
* all items at first position
* Move activities filter to a cell and use it in user public profile and site activities
* Fix translation reference
* Fix translation
* Fix test
* Move mocked method
* Redefine method and avoid memoization
* Avoid exceptions when a constant name passed to resource_types_filter_cell is undefined
---------
Co-authored-by: Eduardo Martinez Echevarria <eduardomech@gmail.com>
* Feature/redesign revert drawers (#10329)
* Remove drawers and references to turbo
* Add comment for redesign in drawer layout
* Update selector in tests
* Update references to drawer in comments and names
* Don't change the cell name when redesign is disabled if redesigned_ prefix is used explicitly
* Recover test
* Unify tests to expect the same behavior with redesign enabled and not
* Fix selectors in tests
* Recover skipped tests working with redesign enabled and not
* Use redesigned cell version always and recover skipped tes
* Remove turbo gem dependency
* Remove turbo packages dependencies
* Remove turbo-rails gem from Gemfile.lock files in app-design and generators
* Add comments to remaining code using drawer term
* Move before block to context to ensure creation of group
* Ensure initialization on remote-modal:loaded event
* Avoid picmo regression
* Fix package version
---------
Co-authored-by: Fernando Blat <fernando@blat.es>
* Redesign: proposals block & card L (#10170)
* proposals block
* add space to span
* Normalize locales
* Add comments count and official? to card metadata cell
* Reorder methods
* Add endorsements count to default card metadata cell
* Allow calling a cell as card metadata item
* Add authorship items to card metadata cell
* Define metadata proposal card cell based on generic attributes
* Sanitize title ind card l cell
* Fix selectors in proposals cards tests
* Add an emendation label to card_metadata_cell
* Add state item to proposal metadata card
* Add an extra class to proposals l card
* Update tests
* replace CSS classes by ids
* Sanitize participatory space title in metadata item
* Reduce if-else nesting
* Update selectors in tests
* Skip maybe deprecated tests
* Remove methods duplicated after merge
---------
Co-authored-by: Eduardo Martinez Echevarria <eduardomech@gmail.com>
Co-authored-by: Fernando Blat <fernando@blat.es>
* Redesign: processes & assemblies (static blocks) (#10005)
* initial setup processes
* floating help styles
* isolate component, provide js functionality
* reuse cards for index
* add metadata to the cards
* responsive index titles
* use new layout for redesigned process
* include paginator
* remove debug code
* filters (mockup) index process
* cherry pick frontend rearrangement
* remove partial in favour of cell
* add callout flow
* main distribution in blocks
* process info metadata
* process metadata block
* phases modal
* phase steps connection line
* assets in show are loaded in their layout
* mobile introduction block
* navigation bar process
* Show only ToS acceptance when admin hasn't accepted it (#9907)
* Don't show the 'Activity' card in dashboard if admin didn't accepted the ToS
* Don't show the 'Global moderations' menu if admin didn't accepted the ToS
* Extract spec to a shared example
* Don't show the 'Participants' menu if admin didn't accepted the ToS
* Fix CTA button copy
* Don't show the 'Templates' menu if admin didn't accepted the ToS
* Don't show the 'Initiatives' menu if admin didn't accepted the ToS
* Add system spec
* Fix specs
* Add example for ToS acceptance in 'Global moderations'
* Fix spec
* Add example for ToS acceptance in 'Space moderations'
* Fix guard clause when admin is managing users
* Fix usages of sanitize helper methods for editable content provided by admins (#10007)
* Fix usages of sanitize helper methods for editable content provided by admins.
Related issue: https://github.com/decidim/decidim/issues/9927
Fixes usages of sanitize for `description` of `ParticipatoryProcess` and `ParticipatoryProcessGroup`.
* Fix usages of sanitize for `description` of assembly, conference and voting. Unify spec test.
* Fix usages of sanitize for `short_description` of conference.
* Always allow image upload in WYSWYG editor (#10011)
* Disable editor_images option in WYSWYG editor
* Correct rubocop offenses
* Fix running DB commands consecutively (#9607)
* Reset column information before seeds on loaded record classes
* Add spec for running db commands consecutively
* Load the templates engine in the surveys engine
Otherwise the templates migrations are not copied to the app
unless the templates module is define in the Gemfile, although
it is a requirement ofr surveys.
* Try sub-command without bundle exec in CI
* Revert "Try sub-command without bundle exec in CI"
This reverts commit 66e4361df6a5e423773b6c1ed2316d209dbaccb4.
* Try running sub-command with original env
* Fix ActiveRecord descendants checks for abstrac test classes
* New Crowdin updates (#9486)
* New translations en.yml (Italian)
* New translations en.yml (Hungarian)
* New translations en.yml (Japanese)
* New translations en.yml (Basque)
* New translations en.yml (Basque)
* New translations en.yml (Greek)
* New translations en.yml (German)
* New translations en.yml (Czech)
* New translations en.yml (Catalan)
* New translations en.yml (Arabic)
* New translations en.yml (Basque)
* New translations en.yml (Spanish)
* New translations en.yml (Latvian)
* New translations en.yml (Indonesian)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (French, Canada)
* New translations en.yml (Luxembourgish)
* New translations en.yml (Portuguese, Brazilian)
* New translations en.yml (Dutch)
* New translations en.yml (Galician)
* New translations en.yml (Chinese Simplified)
* New translations en.yml (Turkish)
* New translations en.yml (Swedish)
* New translations en.yml (Slovak)
* New translations en.yml (Portuguese)
* New translations en.yml (Polish)
* New translations en.yml (Norwegian)
* New translations en.yml (Lithuanian)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Finnish (plain))
* New translations en.yml (Finnish (plain))
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (Finnish)
* New translations en.yml (French)
* New translations en.yml (Japanese)
* New translations en.yml (French, Canada)
* New translations en.yml (Romanian)
* New translations en.yml (Dutch)
* New translations en.yml (Italian)
* New translations en.yml (Japanese)
* New translations en.yml (Japanese)
* New translations en.yml (Lithuanian)
* New translations en.yml (Lithuanian)
* New translations en.yml (Dutch)
* New translations en.yml (Norwegian)
* New translations en.yml (Hungarian)
* New translations en.yml (Polish)
* New translations en.yml (Romanian)
* New translations en.yml (Czech)
* New translations en.yml (French)
* New translations en.yml (French)
* New translations en.yml (Spanish)
* New translations en.yml (Spanish)
* New translations en.yml (Arabic)
* New translations en.yml (Bulgarian)
* New translations en.yml (Catalan)
* New translations en.yml (Catalan)
* New translations en.yml (Czech)
* New translations en.yml (Irish)
* New translations en.yml (Danish)
* New translations en.yml (German)
* New translations en.yml (Greek)
* New translations en.yml (Basque)
* New translations en.yml (Finnish)
* New translations en.yml (Finnish)
* New translations en.yml (Slovak)
* New translations en.yml (Portuguese)
* New translations en.yml (Swedish)
* New translations en.yml (Swedish)
* New translations en.yml (Slovenian)
* New translations en.yml (Chinese Simplified)
* New translations en.yml (Turkish)
* New translations en.yml (Galician)
* New translations en.yml (Portuguese, Brazilian)
* New translations en.yml (Galician)
* New translations en.yml (Icelandic)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Latvian)
* New translations en.yml (French, Canada)
* New translations en.yml (French, Canada)
* New translations en.yml (Luxembourgish)
* New translations en.yml (Sinhala)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Finnish (plain))
* New translations en.yml (Finnish (plain))
* New translations en.yml (French)
* New translations en.yml (French)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (French)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Czech)
* New translations en.yml (Guarani)
* New translations en.yml (Portuguese, Brazilian)
* New translations en.yml (Polish)
* New translations en.yml (Polish)
* New translations en.yml (Polish)
* New translations en.yml (Polish)
* New translations en.yml (Polish)
* New translations en.yml (Romanian)
* New translations en.yml (Spanish)
* New translations en.yml (French)
* New translations en.yml (Bulgarian)
* New translations en.yml (Arabic)
* New translations en.yml (Czech)
* New translations en.yml (Catalan)
* New translations en.yml (German)
* New translations en.yml (Danish)
* New translations en.yml (Greek)
* New translations en.yml (Basque)
* New translations en.yml (Irish)
* New translations en.yml (Finnish)
* New translations en.yml (Hungarian)
* New translations en.yml (Japanese)
* New translations en.yml (Italian)
* New translations en.yml (Lithuanian)
* New translations en.yml (Norwegian)
* New translations en.yml (Dutch)
* New translations en.yml (Portuguese)
* New translations en.yml (Polish)
* New translations en.yml (Slovak)
* New translations en.yml (Chinese Simplified)
* New translations en.yml (Turkish)
* New translations en.yml (Swedish)
* New translations en.yml (Icelandic)
* New translations en.yml (Galician)
* New translations en.yml (Indonesian)
* New translations en.yml (Portuguese, Brazilian)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Latvian)
* New translations en.yml (French, Canada)
* New translations en.yml (Luxembourgish)
* New translations en.yml (Serbian (Latin))
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Ukrainian with many plural form)
* New translations en.yml (Finnish (plain))
* New translations en.yml (Russian with many plural form)
* New translations en.yml (French)
* New translations en.yml (French, Canada)
* New translations en.yml (Swedish)
* New translations en.yml (Basque)
* New translations en.yml (Romanian)
* New translations en.yml (Galician)
* New translations en.yml (Portuguese, Brazilian)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (French, Canada)
* New translations en.yml (Luxembourgish)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Turkish)
* New translations en.yml (French)
* New translations en.yml (Spanish)
* New translations en.yml (Arabic)
* New translations en.yml (Catalan)
* New translations en.yml (Czech)
* New translations en.yml (German)
* New translations en.yml (Greek)
* New translations en.yml (Basque)
* New translations en.yml (Finnish)
* New translations en.yml (Hungarian)
* New translations en.yml (Swedish)
* New translations en.yml (Italian)
* New translations en.yml (Japanese)
* New translations en.yml (Lithuanian)
* New translations en.yml (Dutch)
* New translations en.yml (Norwegian)
* New translations en.yml (Polish)
* New translations en.yml (Portuguese)
* New translations en.yml (Finnish (plain))
* New translations en.yml (French)
* New translations en.yml (Basque)
* New translations en.yml (French, Canada)
* New translations en.yml (Romanian)
* New translations en.yml (Romanian)
* New translations en.yml (Romanian)
* New translations en.yml (Romanian)
* New translations en.yml (Romanian)
* New translations en.yml (Romanian)
* New translations en.yml (Romanian)
* New translations en.yml (Romanian)
* New translations en.yml (Romanian)
* New translations en.yml (Romanian)
* New translations en.yml (Romanian)
* New translations en.yml (Romanian)
* New translations en.yml (Spanish)
* New translations en.yml (Spanish)
* New translations en.yml (Spanish)
* New translations en.yml (Catalan)
* New translations en.yml (Catalan)
* New translations en.yml (Catalan)
* New translations en.yml (Spanish)
* New translations en.yml (Spanish)
* New translations en.yml (Spanish)
* New translations en.yml (Spanish)
* New translations en.yml (Spanish)
* New translations en.yml (Spanish)
* New translations en.yml (Catalan)
* New translations en.yml (Catalan)
* New translations en.yml (Catalan)
* New translations en.yml (Catalan)
* New translations en.yml (Catalan)
* New translations en.yml (Catalan)
* New translations en.yml (Catalan)
* New translations en.yml (Finnish)
* New translations en.yml (Finnish)
* New translations en.yml (Finnish)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Finnish (plain))
* New translations en.yml (Finnish (plain))
* New translations en.yml (Finnish (plain))
* Add note to merge the Crowdin PRs in all releases (#10076)
* Clarify the changelog instructions in the release process documentation (#10066)
* Redesign: upload modal (#9858)
* prepare update-modal cell
* clean conversations modal as of the shared styles
* shared html styles for modals
* workaround: redesign_enabled? not working on cells called from helper
* full refactor upload modal files
* fix linters
* fix styles dropzone
* handle asynchronous validations
* general fixes and new casuistics
* fix dragover highlight & remove files on cancel
* update dropzone when errors
* add space to files
* Prepare button to open login modal to work with redesigned and legacy layouts
* Split upload modal cell in legacy and redesigned versions and allow to call it passing a redesign option
* Call upload method passing the redesigned option based on the context
* Fix linter offense
* Normalize locale file
* eslint consistent-return
* eslint consistent-return
* Update test
* move action button to the right if it's the only child
* rearrangement frontend libraries
* fix upload modal after redesigned assets
* remove current image block (fix removal error)
* preview image
* good version files.erb
* Fix external_link initialization in legacy design index.js
* Force flaky test
* Fix attachment blob call
* Remove unused attachment label method
* Display default image if defined and no uploaded attachments
* Update test
* Update selector in test
* Revert "Force flaky test"
This reverts commit 075f6eb77d46193d0977d37d1e8e7942e08ca3c4.
* Improve deprecation after redesign documentation in js file
* overflow dropzone auto
* disabled form submit when there are erorrs on the files
* reset dropzone on cancel
* pass argument multiple
* update translation
* better looking responsive
* disable save only when errors & mark as removable
* include logic to remove the current uploaded item
* Delegate redesign_enabled? to template in form builder
* fixes frontend upload modal
* Fix form_builder spec to take redesign into account
* avoid drag flickering on webkit browsers
* Avoid errors in determine_filename when attachment class is ActionDispatch::Http::UploadedFile
* avoid string commas in errors array
Co-authored-by: Eduardo Martinez Echevarria <eduardomech@gmail.com>
* Implement ToS summary (#9222)
* feat(privacy_policy): Manage privacy policy as a content_block
* feat(privacy_policy): add summary to sign up
* chore(sign_up): privacy_policy link target blank
* fix rubocop issues
* fix: privacy_policy unused_manifests method
* feat(core): add seed for privacy policy summary
* feat(spec): add system/admin_manages_organization_privacy_policy_spec.rb
* refactor: move from settings to static_pages, rename to ToS
* chore(css): tweak sign_up ToS text styles
* fix(i18n): remove unused keys
* feat(seeds): add ToS summary content_block
* fix specs
* add summary content block to tabbed page view
* Fix rubocop offenses
* Add migration to move terms and conditions page content to content_block
* Keep the content of the tos page even with summary content block active
* Fix test
* Show summary section in ToS page
Co-authored-by: Francisco Bolívar <francisco.bolivar@nazaries.com>
* Run ERBlinter on modified files (#9868)
* boost the ERBlinter filtering the scanned files
* Test simpler setup
* Test another syntax
* handle no files exit code
* Get back the initial command
* Add erblint to package.json of design app
* remove linter from npm
* lint all views for merges
* Update run_erblint.sh
* Update .github/run_erblint.sh
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
* Update .github/run_erblint.sh
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Co-authored-by: Eduardo Martinez Echevarria <eduardomech@gmail.com>
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
* Improve the release_all rake task with multiple remotes (#10077)
- Add check that we have decidim/decidim as one of the remotes
- Fetch the existing tags before doing the release
- Define the release remote to the correct remote (decidim/decidim)
* Enable newsletters for admin on seeds (#10073)
* Enable newsletters for admin on seeds
* Enable newsletters for a couple more users on seeds
* Allow blocking a UserGroup (#10021)
* Fix comment (probably a copypasta)
* Make Users find compatible with UserGroups
* Add specs for blocking/unblocking a User or a UserGroup
* Recover user_name from extended_data when unblocking
* Redirect to users moderation panel instead of users/officializations
* Return 404 when the UserGroup is blocked
* Move the associations to the UserBaseEntity model
* Fix override of extended_data attribute in UserGroups factory
* Fix spec
* Add slash in PR linter configuration (#10074)
To only catch when someones leave the default title when working with
`hub` or `gh`, that's the default branch, and not when someone uses
"Refactor XXX" as title.
* Enhance templates engine (#10015)
* Refactor templates engine
* Running linters
* Apply review Recommendations
* Implement last review reccomendations
* Apply the latest recommendation changes
* Apply clarified review recommendations
* Fix wrong capitalization in i18n values and add missing keys (#10072)
* Fix wrong capitalization in i18n values
* Add missing i18n keys
* Replace 'Weight' with 'Order position'
So its consistent in all the forms.
* Fix key for meeting agenda item
* Remove unused attribute for show_embedded_iframe
* Fix key for scope
* Normalize :en locale
* Fix spec
* Fix typo
Suggested by code review
Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>
* Fix column reference on Topic
Suggested by code review
Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>
Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>
* merge item-list into card css component
* remove redesigned card cell (deprecated)
* landing processes
* give some margin to any sibling of a callout
* do not style dynamic content inside the cards
* floating help default status as tip, not block
* add card "G" cell for process card grids
* set content blocks for processes & accountability
* Revert "remove redesigned card cell (deprecated)"
This reverts commit 9300a1af2d7f2f6000cf747fc0290f71ac73e57b.
* Remove redesigned_process cell and define process size l card
* add reference code to the bototm
* block activity (pending integration)
* blog section
* missing block title
* handle full layout html block
* reduce description characters
* create post_g cell
* set color only to the title, not the whole block
* don't use custom editor text for card descriptions
* update markup modal steps
* add process description page
* add metrics content block
* prepare assemblies assets (orgchart removed)
* fix hover floating help
* update index files dependencies
* assembly cell type G
* move new filters view to shared
* mark as deprecated
* move results to partials
* update tests & references
* update js returned results
* assemblies show
* replace attachments_for with atomic content
* set margins for container
* add link to index in assemblies
* remove helper for assemblies
* refactor the way to draw the charts
* demo cell activities
* move activity styles from profile to independent component
* replace custom css with component class
* fix erblint
* update the floating help for conferneces from processes
* Fix key used to get url in process_nav_item partial
* include author conditionally
* don't enforce font-size on component
* remove spaces from the component, set them in the container
* Use an option to hide participatory space on activities cell
* Adapt test selectors
* Unify method changing behavior with redesign and adapt shared example to both cases
* Skip test pending of integration of breadcrumb
* Recover partial used by legacy design
* Fix linter offenses
* Skip some tests deprecated after redesign
* Remove deprecated partials en assemblies and processes
* Remove unused translations
* Add redesign pending comments
* Fix nav items generation in assembly space
* Use snippets to include assets in cell
* Remove unused translations
* remove old code
* hide endorsers on mobile
* style glitches
* Remove unused translations
* switch flex to grid for responsiveness
* grow time container
---------
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Co-authored-by: Sergei Krylov <sergei.krylov@yahoo.com>
Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>
Co-authored-by: decidim-bot <decidim-bot@users.noreply.github.com>
Co-authored-by: Eduardo Martinez Echevarria <eduardomech@gmail.com>
Co-authored-by: Agusti B.R <agustibr@users.noreply.github.com>
Co-authored-by: Francisco Bolívar <francisco.bolivar@nazaries.com>
Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
* Feature/redesign proposals tests fixes (#10377)
* Fix test
* Use a data-author attribute in redesigned author cell
* Force the use of redesigned author cell in other cells using it
* Update have_author matcher in test
* Update selectors in test
* Use presenter version of title on proposal l cell
* Skip temporarily tests related with proposals votes
REDESIGN_PENDING - The mechanism to vote proposals from index is pending
and also the metadata displaying the votes count
* Exclude file with TODOs in decidim_app-design from codeclimate checks
* Change selector in tests
* Update have_author matchers in tests
* Change selector of author in cells tests
* Change test to check proposals block inside a process
* Skip test of redesign pending behaviour
* Remove Turbo references
* Add missing locale
* Fix pending comment
* Update test selectors
* Update keys sent to server
* Redesign: timeout modal (#10373)
* adapt timeout controller to use new dialogs library
* duplicate files to avoid error on admin part
---------
Co-authored-by: Fernando Blat <fernando@blat.es>
* Offense
* Adjust specs
* Offenses
* Skip debates and proposals report spec
* Redesign: fonts (#10417)
* include the updated file fonts (new glyphs)
* fix stylelint
* move the flag modal outside of the comment header
* Skip tests until redesign is enabled
* replace details-summary into a11y component
* better design comments
* better mobile comments
* opinion on comments
* override default styles
* update html markup on tests
* avoid external link when polling is triggered
* Fix focusGuard setup on scoped elements
* add explanations for a future development
* Redesign: Newsletter modal (#10428)
* ensure tos modal
* add a11y description
* remove linebreaks
* Redesign: cookies (#10366)
* update & adapt application layout from develop
* floating bottom banner
* handle click cookies banner
* refactor cookies modal
* set cursor only to the accordion trigger
* footer triggers cookie modal
* make the title + arrow clickable
* change structure to a11y
* fix stylelint
* do not include a div inside button
* do not use button
* better responsiveness for modal actions
* fix stylelint
* fix core tests (skip for redesigning)
* fix rubocop
* fix tests
* Fix spec
* Update selector
* Fix var name, use redesigned assets
* remove transition needless
* Fix test
---------
Co-authored-by: Fernando Blat <fernando@blat.es>
Co-authored-by: Eduardo Martinez Echevarria <eduardomech@gmail.com>
* Redesign: floating tip turns into modal (#10388)
* fix odd positioning tip
* adapt tip to the button styles & fix mobile position
* turns tip helper into a modal
* place tip relative to data-content block
* Redesign: map popup (#10335)
* include custom popup content for meetings
* increase map size on mobile
* overwrite custom styles for leaflet popup
* keep the map icons setup simple (remove legacy stuff)
* show disfferent texts based on the meeting duration
* fix icon anchor position
* fix linter
* fix i18n
* use decidim date formats
* Include DateHelper in the correct cell
* Fix calculation of progress value
* Move dates and duration item to generic metadata cell
* Add tests for card-l and card_metadata cells
* let the popup transition by default
* wrap elements in leaflet popup
---------
Co-authored-by: Eduardo Martinez Echevarria <eduardomech@gmail.com>
* Offense
* Ignore visible check
* Skip test when redesign is disabled, because causes a JS error
* Skip tests for old design
* move the opinion block into the form
* add space between label-opinion and comment
* add text-decoration:underline if user select neutral opinion
* styles edited comment
* add dispatchEvent to add a comment
* remove profile and cell author
* remove a[href*=/users/sign_] styles
* add type="button" to opinion buttons to avoid the form submit when clicking on them
* replace div with button and remove tabindex
* clean duplicated class
* Redesign: Refuse TOS modal (#10431)
* style refuse tos modal
* fix i18n
* overwrite modal defaults
* Fix locale
---------
Co-authored-by: Fernando Blat <fernando@blat.es>
* Participatory spaces landing page content blocks (#10234)
* initial setup processes
* floating help styles
* isolate component, provide js functionality
* reuse cards for index
* add metadata to the cards
* responsive index titles
* use new layout for redesigned process
* include paginator
* remove debug code
* filters (mockup) index process
* cherry pick frontend rearrangement
* remove partial in favour of cell
* add callout flow
* main distribution in blocks
* process info metadata
* process metadata block
* phases modal
* phase steps connection line
* assets in show are loaded in their layout
* mobile introduction block
* navigation bar process
* Show only ToS acceptance when admin hasn't accepted it (#9907)
* Don't show the 'Activity' card in dashboard if admin didn't accepted the ToS
* Don't show the 'Global moderations' menu if admin didn't accepted the ToS
* Extract spec to a shared example
* Don't show the 'Participants' menu if admin didn't accepted the ToS
* Fix CTA button copy
* Don't show the 'Templates' menu if admin didn't accepted the ToS
* Don't show the 'Initiatives' menu if admin didn't accepted the ToS
* Add system spec
* Fix specs
* Add example for ToS acceptance in 'Global moderations'
* Fix spec
* Add example for ToS acceptance in 'Space moderations'
* Fix guard clause when admin is managing users
* Fix usages of sanitize helper methods for editable content provided by admins (#10007)
* Fix usages of sanitize helper methods for editable content provided by admins.
Related issue: https://github.com/decidim/decidim/issues/9927
Fixes usages of sanitize for `description` of `ParticipatoryProcess` and `ParticipatoryProcessGroup`.
* Fix usages of sanitize for `description` of assembly, conference and voting. Unify spec test.
* Fix usages of sanitize for `short_description` of conference.
* Always allow image upload in WYSWYG editor (#10011)
* Disable editor_images option in WYSWYG editor
* Correct rubocop offenses
* Fix running DB commands consecutively (#9607)
* Reset column information before seeds on loaded record classes
* Add spec for running db commands consecutively
* Load the templates engine in the surveys engine
Otherwise the templates migrations are not copied to the app
unless the templates module is define in the Gemfile, although
it is a requirement ofr surveys.
* Try sub-command without bundle exec in CI
* Revert "Try sub-command without bundle exec in CI"
This reverts commit 66e4361df6a5e423773b6c1ed2316d209dbaccb4.
* Try running sub-command with original env
* Fix ActiveRecord descendants checks for abstrac test classes
* New Crowdin updates (#9486)
* New translations en.yml (Italian)
* New translations en.yml (Hungarian)
* New translations en.yml (Japanese)
* New translations en.yml (Basque)
* New translations en.yml (Basque)
* New translations en.yml (Greek)
* New translations en.yml (German)
* New translations en.yml (Czech)
* New translations en.yml (Catalan)
* New translations en.yml (Arabic)
* New translations en.yml (Basque)
* New translations en.yml (Spanish)
* New translations en.yml (Latvian)
* New translations en.yml (Indonesian)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (French, Canada)
* New translations en.yml (Luxembourgish)
* New translations en.yml (Portuguese, Brazilian)
* New translations en.yml (Dutch)
* New translations en.yml (Galician)
* New translations en.yml (Chinese Simplified)
* New translations en.yml (Turkish)
* New translations en.yml (Swedish)
* New translations en.yml (Slovak)
* New translations en.yml (Portuguese)
* New translations en.yml (Polish)
* New translations en.yml (Norwegian)
* New translations en.yml (Lithuanian)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Finnish (plain))
* New translations en.yml (Finnish (plain))
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (Finnish)
* New translations en.yml (French)
* New translations en.yml (Japanese)
* New translations en.yml (French, Canada)
* New translations en.yml (Romanian)
* New translations en.yml (Dutch)
* New translations en.yml (Italian)
* New translations en.yml (Japanese)
* New translations en.yml (Japanese)
* New translations en.yml (Lithuanian)
* New translations en.yml (Lithuanian)
* New translations en.yml (Dutch)
* New translations en.yml (Norwegian)
* New translations en.yml (Hungarian)
* New translations en.yml (Polish)
* New translations en.yml (Romanian)
* New translations en.yml (Czech)
* New translations en.yml (French)
* New translations en.yml (French)
* New translations en.yml (Spanish)
* New translations en.yml (Spanish)
* New translations en.yml (Arabic)
* New translations en.yml (Bulgarian)
* New translations en.yml (Catalan)
* New translations en.yml (Catalan)
* New translations en.yml (Czech)
* New translations en.yml (Irish)
* New translations en.yml (Danish)
* New translations en.yml (German)
* New translations en.yml (Greek)
* New translations en.yml (Basque)
* New translations en.yml (Finnish)
* New translations en.yml (Finnish)
* New translations en.yml (Slovak)
* New translations en.yml (Portuguese)
* New translations en.yml (Swedish)
* New translations en.yml (Swedish)
* New translations en.yml (Slovenian)
* New translations en.yml (Chinese Simplified)
* New translations en.yml (Turkish)
* New translations en.yml (Galician)
* New translations en.yml (Portuguese, Brazilian)
* New translations en.yml (Galician)
* New translations en.yml (Icelandic)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Latvian)
* New translations en.yml (French, Canada)
* New translations en.yml (French, Canada)
* New translations en.yml (Luxembourgish)
* New translations en.yml (Sinhala)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Finnish (plain))
* New translations en.yml (Finnish (plain))
* New translations en.yml (French)
* New translations en.yml (French)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (French)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Guarani)
* New translations en.yml (Czech)
* New translations en.yml (Guarani)
* New translations en.yml (Portuguese, Brazilian)
* New translations en.yml (Polish)
* New translations en.yml (Polish)
* New translations en.yml (Polish)
* New translations en.yml (Polish)
* New translations en.yml (Polish)
* New translations en.yml (Romanian)
* New translations en.yml (Spanish)
* New translations en.yml (French)
* New translations en.yml (Bulgarian)
* New translations en.yml (Arabic)
* New translations en.yml (Czech)
* New translations en.yml (Catalan)
* New translations en.yml (German)
* New translations en.yml (Danish)
* New translations en.yml (Greek)
* New translations en.yml (Basque)
* New translations en.yml (Irish)
* New translations en.yml (Finnish)
* New translations en.yml (Hungarian)
* New translations en.yml (Japanese)
* New translations en.yml (Italian)
* New translations en.yml (Lithuanian)
* New translations en.yml (Norwegian)
* New translations en.yml (Dutch)
* New translations en.yml (Portuguese)
* New translations en.yml (Polish)
* New translations en.yml (Slovak)
* New translations en.yml (Chinese Simplified)
* New translations en.yml (Turkish)
* New translations en.yml (Swedish)
* New translations en.yml (Icelandic)
* New translations en.yml (Galician)
* New translations en.yml (Indonesian)
* New translations en.yml (Portuguese, Brazilian)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Latvian)
* New translations en.yml (French, Canada)
* New tran…
🎩 What? Why?
New screens for meetings
Closes #10095
Closes #10101
Closes #10097
Closes #10098
Closes #10099
Closes #10135
Closes #10156
📷 Screenshots
1 Design displayed in the proto cannot be done due to a needed refactorization of the decidim forms (which is a transversal element). Such technical impediment makes really hard to work with them. What's done here is applying the new forms styles to the legacy HTML