Conversation
|
@decidim/product all your feedback from #10468 has been implemented or delegated to another issue. Please make another review and feel free to open new issues, this PR is frozen except for critical bugs |
|
@alecslupu when that happens, you need to restart |
@Crashillo I am not using de the webpack dev server ... I just checked out the branch, removed the asset folder in my public, ran decidim:upgrade , restared the webserver ... |
|
In any case, comments is a branch who introduces a new pack (decidim_comments), so every single time you switch among branches, you'll have to restart the assets compiler, otherwise the manifest file won't have such entries. When we develop, we run two tabs up: |
|
running webpack-dev-server ... i get this error: I will reinstall my webpacker, to make sure is not that the root cause of my errors. |
|
If you re-create the development_app it works, maybe you should try. Anyway we have an issue with the commit 9f4ccd7 which broke many tests, we are fixing it right now. |
I got it working ... was a Mishap on my end ( I use multiple containers and something got mangled by a config) ... |
|
@alecslupu ready to review again |
| # | ||
| # require "spec_helper" | ||
| # | ||
| # describe "Report a debate", type: :system do |
There was a problem hiding this comment.
I would like to remove this comment, even though it means failing pipeline
There was a problem hiding this comment.
Thanks for your work. Overall a good PR, with few requests.
- Please make sure you do not remove unnecessary specs.
- In the action menu of comments you have 2 ifs checking the same thing, and maybe you could put in a single statement
- Also make sure the comment moderated is in the right place.
decidim-comments/spec/cells/decidim/comments/comment_thread_cell_spec.rb
Show resolved
Hide resolved
That's something solved in staging, don't have to worry: https://decidim-redesign.populate.tools/processes/smile-cutting/f/19/posts/10 |
@ferblape this is NOT solved ... Check here : https://decidim-redesign.populate.tools/processes/smile-cutting/f/19/posts/10 |
|
Ready to re-review @alecslupu, ping me if you want clarification about the commented specs you want to remove |
|
@alecslupu could you review this today? we need some stuff from this PR in the filters branch |
|
Hello!
Yes, i will put it on my list for today.
On Fri, 24 Mar 2023 at 07:03, Fernando Blat ***@***.***> wrote:
@alecslupu <https://github.com/alecslupu> could you review this today? we
need some stuff from this PR in the filters branch
—
Reply to this email directly, view it on GitHub
<#9898 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAZZU4HMGQJREVI5EQOYRDW5UTKZANCNFSM6AAAAAARFBHR5A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Sent from Gmail Mobile
|
|
Team, thanks for the work already done. There are some improvements that could be done:
Screencast.from.24.03.2023.09.43.41.webm |




🎩 What? Why?
Closes #10102
Closes #10459
This PR applies the redesign to the comments module.
Also fixes a couple of bugs:
Pending stuff:
📷 Screenshots