Skip to content

Fix incorrect expecations after change of allowed file extensions#9877

Merged
andreslucena merged 1 commit intodecidim:developfrom
mainio:fix/incorrect-file-expectations
Oct 5, 2022
Merged

Fix incorrect expecations after change of allowed file extensions#9877
andreslucena merged 1 commit intodecidim:developfrom
mainio:fix/incorrect-file-expectations

Conversation

@ahukkanen
Copy link
Copy Markdown
Contributor

🎩 What? Why?

The build is broken after merging #9663 because #9641 before that changed the allowed file types.

This fixes the broken specs.

📌 Related Issues

Testing

See the CI is green.

Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm merging this one without the approval from @fblupi as the build is broken and that means that other PRs are broken for this (and potentially the new ones that start from develop)

@andreslucena andreslucena merged commit 9cbfa0c into decidim:develop Oct 5, 2022
@ahukkanen ahukkanen deleted the fix/incorrect-file-expectations branch October 5, 2022 07:24
entantoencuanto added a commit that referenced this pull request Oct 5, 2022
* feature/redesign-turbo:
  Install turbo-rails
  Fix incorrect expecations after change of allowed file extensions (#9877)
  Update `@joeattardi/emoji-button` to `@picmo/popup-picker` (#9667)
  Address Crowdin feedback (#9678)
  Fix cryptic file validation errors (#9663)
  Fix disappearing sub-lists in rich text editors (#9867)
  Implement authorization data recovery for deleted users (#9463)
  Redesigned: admin bar (#9874)
eliegaboriau pushed a commit to eliegaboriau/decidim that referenced this pull request Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: internal PRs that aren't necessary to add to the CHANGELOG for implementers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants