Conversation
rober-gd
suggested changes
Sep 30, 2022
There was a problem hiding this comment.
- Hide user rol in small screens to let more space to action buttons. Also in responsive, group buttons to the left because in this administration bar, in addition to the edit button there can be more actions depending on the role and the type of content (withdraw proposal, edit initiative...). These actions are added to the bar and it will grow naturally:
ahukkanen
approved these changes
Oct 3, 2022
Contributor
ahukkanen
left a comment
There was a problem hiding this comment.
Looks great!
Tested it and works well on all screen sizes with the redesigned layout. The link was also pointing to the correct page from the pages, so I trust it works elsewhere too as it used to.
entantoencuanto
added a commit
that referenced
this pull request
Oct 5, 2022
* feature/redesign-turbo: Install turbo-rails Fix incorrect expecations after change of allowed file extensions (#9877) Update `@joeattardi/emoji-button` to `@picmo/popup-picker` (#9667) Address Crowdin feedback (#9678) Fix cryptic file validation errors (#9663) Fix disappearing sub-lists in rich text editors (#9867) Implement authorization data recovery for deleted users (#9463) Redesigned: admin bar (#9874)
eliegaboriau
pushed a commit
to eliegaboriau/decidim
that referenced
this pull request
Oct 25, 2022
* new admin bar redesigned * Fix linter offense * Use a different version of admin_links when redesign is disabled to ensure accessibility * Update expected icon in test * Update selector in test * Remove unused custom class in navbar admin link cell * wrap items on mobile & rearrange items Co-authored-by: Eduardo Martinez Echevarria <eduardomech@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Bring back admin bar redesigned
📌 Related Issues
📷 Screenshots
(user: decidim / pwd: staging123)