Address Crowdin feedback#9678
Merged
andreslucena merged 8 commits intodecidim:developfrom Oct 4, 2022
Merged
Conversation
andreslucena
approved these changes
Sep 30, 2022
Member
andreslucena
left a comment
There was a problem hiding this comment.
Tried locally the bulk budget selection change 👌🏽
The rest are minor changes and shouldn't be a problem.
entantoencuanto
added a commit
that referenced
this pull request
Oct 5, 2022
* feature/redesign-turbo: Install turbo-rails Fix incorrect expecations after change of allowed file extensions (#9877) Update `@joeattardi/emoji-button` to `@picmo/popup-picker` (#9667) Address Crowdin feedback (#9678) Fix cryptic file validation errors (#9663) Fix disappearing sub-lists in rich text editors (#9867) Implement authorization data recovery for deleted users (#9463) Redesigned: admin bar (#9874)
eliegaboriau
pushed a commit
to eliegaboriau/decidim
that referenced
this pull request
Oct 25, 2022
* Address Crowdin feedback * Fix passing the interpolation arguments to amendable errors * Omit hash value with the same key * Generalize the "access codes for census" wording * Correct capitalization of string * Adjust the texts according to the changes in the specs
This was referenced Oct 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
There are some issues in the source strings posted through Crowdin that this PR addresses.
Testing
See the strings.
There is also a small logic change in Budgets to be able to provide different translations for different selected states. You can test this using the bulk actions in the Budgets component.