Skip to content

Add Markdown linter CI workflow#9446

Merged
verarojman merged 39 commits intodevelopfrom
chore/markdown-linter
Aug 8, 2022
Merged

Add Markdown linter CI workflow#9446
verarojman merged 39 commits intodevelopfrom
chore/markdown-linter

Conversation

@andreslucena
Copy link
Copy Markdown
Member

🎩 What? Why?

While working in the CHANGELOG.md in another PR, I noticed that we had multiple errors there. I saw that we already had a markdown linter in our dependencies, so this PR adds this to our linter workflow.

As an alternative, we could use a GitHub Action for this, but I like using this gem as it's easier to troubleshoot locally.

Testing

This should:

  1. Initially fail, but that means that it's working correctly 😄.
  2. After that, I'd need to address all the found offenses

♥️ Thank you!

@andreslucena andreslucena marked this pull request as draft June 16, 2022 18:28
@andreslucena andreslucena force-pushed the chore/markdown-linter branch from b4f3eee to c0ed937 Compare June 29, 2022 13:29
@andreslucena
Copy link
Copy Markdown
Member Author

andreslucena commented Jun 29, 2022

You'll see that I introduced a logic to ignore particular files and rules at the rake task:

# These rules will be ignored for only this file.

Basically, the problem is with the participatory text example document. It's breaking the rule "MD025 - Multiple top level headers in the same document".

I have lots of doubts if this is actually something that we want or if it's clear. It smells a bit hackish (even for me! 🙈 ). What I don't like is that if you run it with the mdl command line, you'll see the rule broken:

$ mdl decidim-proposals/app/packs/documents/decidim/proposals/participatory_texts/participatory_text.md
decidim-proposals/app/packs/documents/decidim/proposals/participatory_texts/participatory_text.md:33: MD025 Multiple top level headers in the same document
decidim-proposals/app/packs/documents/decidim/proposals/participatory_texts/participatory_text.md:51: MD025 Multiple top level headers in the same document

So, alternatives:

  1. We could solve this problem by implementing our own rule that skips this file . This would be interpreted transparently with the mdl CLI; although I don't know if it's something that's easily discoverable for others.

  2. Another solution could be to disable this rule globally (we already do it for other rules, see .mdl_style.rb, but this is actually something that I think is good to enforce.

  3. The third solution would be to change the file and also change the logic of the consumer of these files (see markdown_to_proposals.rb and spec). This would be the best solution IMHO, as it's the one fixing the root problem, but the problem is that I wasn't sure what would be the new expected behavior. Should we treat h1 and h2 as section titles and h3 as sub-sections? It sounds a bit weird.

So, that's how I reached to ignore_rules_for_file logic. I'm not specially fond of it, and I'm open to suggestions on better alternatives.

@andreslucena andreslucena force-pushed the chore/markdown-linter branch from c728cea to 17130ac Compare June 29, 2022 17:27
@andreslucena andreslucena force-pushed the chore/markdown-linter branch from 17130ac to 48486f6 Compare June 29, 2022 17:54
@andreslucena andreslucena force-pushed the chore/markdown-linter branch from 48486f6 to 653743d Compare June 30, 2022 06:43
@andreslucena andreslucena requested a review from microstudi June 30, 2022 07:14
@andreslucena andreslucena marked this pull request as ready for review June 30, 2022 07:29
@andreslucena andreslucena requested review from ahukkanen and removed request for microstudi June 30, 2022 07:29
@andreslucena andreslucena added the type: internal PRs that aren't necessary to add to the CHANGELOG for implementers label Jun 30, 2022
@ahukkanen
Copy link
Copy Markdown
Contributor

Basically, the problem is with the participatory text example document. It's breaking the rule "MD025 - Multiple top level headers in the same document".

I have lots of doubts if this is actually something that we want or if it's clear. It smells a bit hackish (even for me! see_no_evil ). What I don't like is that if you run it with the mdl command line, you'll see the rule broken:

I actually think this rule (MD025) is pretty important and IMO it should be there, after going through the a11y issues in Decidim and fixing issues like #7745. I think this same convention should apply to the documentation too as we generate HTML pages out of many of these files.

So, alternatives:

  1. We could solve this problem by implementing our own rule that skips this file . This would be interpreted transparently with the mdl CLI; although I don't know if it's something that's easily discoverable for others.
  2. Another solution could be to disable this rule globally (we already do it for other rules, see .mdl_style.rb, but this is actually something that I think is good to enforce.
  3. The third solution would be to change the file and also change the logic of the consumer of these files (see markdown_to_proposals.rb and spec). This would be the best solution IMHO, as it's the one fixing the root problem, but the problem is that I wasn't sure what would be the new expected behavior. Should we treat h1 and h2 as section titles and h3 as sub-sections? It sounds a bit weird.

So, that's how I reached to ignore_rules_for_file logic. I'm not specially fond of it, and I'm open to suggestions on better alternatives.

I would also prefer if MDL supported file specific rules the same way as ESLint/Rubocop but after a bit of investigation, it does not seem to be supported, as you've also probably noticed. This has been also suggested at the MDL repo as #16, #418 and related conversations such as markdownlint/markdownlint#167 (comment).

One option would be to switch over to the markdownlint-cli NPM package which relies on markdownlint. This package would allow specifying inline comments such as <!-- markdownlint-disable-file MD025 --> to disable rules for a particular file or a particular code block.

But if you want to keep the Ruby implementation, I think the current approach is just fine that you have implemented.

@andreslucena
Copy link
Copy Markdown
Member Author

I would also prefer if MDL supported file specific rules the same way as ESLint/Rubocop but after a bit of investigation, it does not seem to be supported, as you've also probably noticed. This has been also suggested at the MDL repo as #16, #418 and related conversations such as markdownlint/markdownlint#167 (comment).

Yes, I've seen those too, but sadly they aren't implemented.

One option would be to switch over to the markdownlint-cli NPM package which relies on markdownlint. This package would allow specifying inline comments such as to disable rules for a particular file or a particular code block.

The problem with this approach is that pollutes the file, and the file that started it all (https://github.com/decidim/decidim/blob/develop/decidim-proposals/app/packs/documents/decidim/proposals/participatory_texts/participatory_text.md) is actually used by admins as a template to import Participatory Texts. So,

  1. We should also take that into account during the import process.
  2. I personally prefer to not add more noise with a comment like that, but maybe it isn't that problematic. I'd like to hear @carolromero opinion on this, because maybe it's not too big of an issue, and as a solution is cleaner and easier to find what's happening when debugging.

But if you want to keep the Ruby implementation, I think the current approach is just fine that you have implemented.

On this case, as it's a utility only for developers, I don't have any concern on using tools from other languages.

@andreslucena
Copy link
Copy Markdown
Member Author

Just talked with @carolromero to explain to her the problem and to brainstorm possible solutions. This is the consensus we reached:

  1. To migrate to the markdownlint-cli NPM package
  2. To apply the rules' exclusion on those files with the inline comments
  3. In another PR, to handle the necessary changes in the Participatory Texts to fix the root problem so we can drop that comment there
  4. In the other files, if they're easy to fix then fix them, but if not we can leave with those comments on files that are for testing purposes or for developers

@andreslucena andreslucena marked this pull request as draft July 14, 2022 14:19
If not, I have this exception when calling it directly:

$ bin/rspec spec/webpacker_spec.rb

(...)
NameError:
  uninitialized constant FileUtils
  Did you mean?  FileTest
(...)
@ahukkanen
Copy link
Copy Markdown
Contributor

  1. To apply the rules' exclusion on those files with the inline comments
  2. In another PR, to handle the necessary changes in the Participatory Texts to fix the root problem so we can drop that comment there

If the decision was made to switch over to markdownlint-cli, I think this could be also solved with a special rules file .markdownlintrc in this particular directory only. I believe it supports this too.

This way no changes would be needed in the participatory texts.

@ahukkanen
Copy link
Copy Markdown
Contributor

Regarding my previous comment, I investigated and the described .markdownlintrc approach won't work because it's not checked per file, it's only checked from the running directory and any directories above that.

I have made some finalization to this PR, most importantly changed the script name to markdownlint, fixed the glob pattern (because it was not scanning all the files at least for me) and moved the emphasis and strong style exclusion rules only for the participatory texts as that was the only file where they failed.

I'll mark this ready for review once the CI shows green.

@ahukkanen ahukkanen marked this pull request as ready for review July 20, 2022 11:48
@ahukkanen ahukkanen requested review from verarojman and removed request for ahukkanen July 20, 2022 11:48
Copy link
Copy Markdown
Contributor

@verarojman verarojman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @andreslucena, @ahukkanen and @carolromero :)

@verarojman verarojman merged commit d7a0a32 into develop Aug 8, 2022
@verarojman verarojman deleted the chore/markdown-linter branch August 8, 2022 11:59
Crashillo pushed a commit that referenced this pull request Aug 10, 2022
* Add Markdown linter rake task

* Add 'Lint Markdown files' step in CI

* Add excluded files on markdown linter task

* Fix heading levels

* Specify language in fenced code block

* Fix unordered list styles

* Fix ordered list prefixes

* Escape HTML tag

* Simplify system admin creation documentation on generated README

* Ignore the 'Multiple top level headers' rule in Participatory Texts example doc

* Add ignore_rules_for_file logic in markdown linter

* Ignore the 'Multiple top level headers' rule in Participatory Texts seed example

* Ignore the 'First header should be a top level header' rule in GraphQL API doc

* Remove mdl gem and configuration

* Add markdownlint-cli NPM package and configuration

* Change mdl references to markdownlint-cli

* Fix linter offenses

* Remove codeclimate markdownlint plugin

* Add inline ignore rules in Participatory Texts examples

* Ignore HTML comments when importing Markdown files

* Fix HTML tags on spec

* Reintroduce wrongly deleted stylelint script

* Explicitly add fileutils as requirement

If not, I have this exception when calling it directly:

$ bin/rspec spec/webpacker_spec.rb

(...)
NameError:
  uninitialized constant FileUtils
  Did you mean?  FileTest
(...)

* Sync npm packages files

* Update spec to remove HTML comments

* Fix the decidim-packs ignore from markdownlint

* Change the markdownlint script name and the glob match pattern

* Fix the disable file inline comment

* Move the strong style and emphasis style excludes to correct file

* Move the markdownlint-cli package to the distributed dev package

* Fix the markdownlint script name in the github action

* Remove unnecessary added linebreak from the Rakefile

* Rename the markdownlint.yml config file extension for consistency

* Fix missing markdownlint

* Exclude link-fragments rule for the API usage.md

* Add examples how to lint and fix markdownlint issues

* Rake bundle

Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>
eliegaboriau pushed a commit to eliegaboriau/decidim that referenced this pull request Oct 25, 2022
* Add Markdown linter rake task

* Add 'Lint Markdown files' step in CI

* Add excluded files on markdown linter task

* Fix heading levels

* Specify language in fenced code block

* Fix unordered list styles

* Fix ordered list prefixes

* Escape HTML tag

* Simplify system admin creation documentation on generated README

* Ignore the 'Multiple top level headers' rule in Participatory Texts example doc

* Add ignore_rules_for_file logic in markdown linter

* Ignore the 'Multiple top level headers' rule in Participatory Texts seed example

* Ignore the 'First header should be a top level header' rule in GraphQL API doc

* Remove mdl gem and configuration

* Add markdownlint-cli NPM package and configuration

* Change mdl references to markdownlint-cli

* Fix linter offenses

* Remove codeclimate markdownlint plugin

* Add inline ignore rules in Participatory Texts examples

* Ignore HTML comments when importing Markdown files

* Fix HTML tags on spec

* Reintroduce wrongly deleted stylelint script

* Explicitly add fileutils as requirement

If not, I have this exception when calling it directly:

$ bin/rspec spec/webpacker_spec.rb

(...)
NameError:
  uninitialized constant FileUtils
  Did you mean?  FileTest
(...)

* Sync npm packages files

* Update spec to remove HTML comments

* Fix the decidim-packs ignore from markdownlint

* Change the markdownlint script name and the glob match pattern

* Fix the disable file inline comment

* Move the strong style and emphasis style excludes to correct file

* Move the markdownlint-cli package to the distributed dev package

* Fix the markdownlint script name in the github action

* Remove unnecessary added linebreak from the Rakefile

* Rename the markdownlint.yml config file extension for consistency

* Fix missing markdownlint

* Exclude link-fragments rule for the API usage.md

* Add examples how to lint and fix markdownlint issues

* Rake bundle

Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>
ahukkanen added a commit that referenced this pull request Dec 22, 2022
* preparation conference assets

* highlight conferences block

* card grid

* differenciate between index & show

* fix ruby lint

* create reverse layout

* conferences show and partners

* refactor address cells repeated, extracted to component

* reformat map section

* conferences hero block

* conferences navigation

* add no-external-link, simplify partial

* fix erb lint

* create layout 2col

* add future boxes when they're ready

* conference speakers dekstop

* mobile tuning

* Fix account update without password change (#9582)

* Handle password change properly at the account form

When the user tried to update their account without changing their
password, they could not submit the form due to the front-end
validations.

Fix this issue by marking those fields required only when they
are visible on the form.

* Make sure the spec checks the encrypted password is not changed

When account is updated without providing a password, the
encrypted password shouldn't change.

* Do not autofill the password on the account form

In tests, the user record responds to `.password` which causes
the account form updates to work differently in tests than they do
for actual users.

* Apply feedback from the code review

* Add also password and password confirmation errors on the form

In case the password update failed, the user doesn't get any
feedback. This fixes that issue.

* Fix order when filtering Meetings (#9505)

* Change date meetings filters checkboxes to radio buttons

* Fix default upcoming filter on meetings' controller

* Order filtered meetings by start_time

* Use Faker::Date in meetings' seeds

* Convert let definitions to one line blocks

* Fix typo

* Add default filter specs for Upcoming meetings

* Add specs for 'date filters' on meetings

* Reintroduces the 'All' filter for meetings dates

* Remove uneceessary instance variable

Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>

* Fix for 500 errors on static maps

* Preserve the currently selected per_page value with filter forms

* Fix the broken specs due to changes in the per_page configuration

* Do not use concat in helpers that are used in cells

* Rubocop

Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>

* Fix admin autocomplete with extra URL parameters (e.g. locale) (#9650)

* Fix issues with daily and weekly notifications (#9599)

* Fix notification daily and weekly status

* Fix notification digest sending decider to check from the end of the day

* Rubocop

* Fix blocked user nickname and avatar in user presenter (#9659)

* modify nickname and avatar in user presenter

* add spec

* modify nickname

* Fix data consent expiry (#9570)

* Rename cookie_consent to data_consent

* Rename the data consent entry point to index.js

* Fix the data consent entry point definition (wrong naming)

* Fix the reference to the consent manager

* Set the expiry period for the data consent cookie to 365 days

* Add the secure flag to the cookie when under https

* Add the domain and SameSite to the consent cookie

* Add possibility to use HTTPS in development and tests

* Add jest tests to test the cookie flags for the consent manager

* Add system spec for the data consent

* Add CI action for testing some of the system specs under HTTPS

* Rename cookie_consent to data_consent and cookie_details to details

In order not to confuse implementors that the data consent is not
only about cookies.

* Remove further references to cookies from the translations and code

* Update docs with the latest code changes and remove references to cookies

* Rename "cookies" doc page to "data_consent" and add relevant changes

Add a note that the data consent is not only about cookies.

* Add the review suggestions to the data consent docs

* Update the documentation regarding testing under SSL

* ESLint

* Rename cookie_consent_warning partial to data_consent_warning

* Fix the translation key for data_consent_settings

* Fix the translation keys for data consent warning

* Refine the JS code comments not to refer particularly to cookie consent

* Rename the "cookies" system specs to "data_consent"

* Move the data consent cookie flags test to the "data_consent" folder

* Update the reference to the correct test in the core system SSL action

* Update the action name for better ordering in the list

* Change the cookie-consent SCSS file name to data-consent

* Update the reference to data-consent SCSS in the docs

* Update the capybara helper to data_consent and the related module name

* Fix partial name in meetings

* Fix the comments in the initializer template

* Fix the domain and flags in the default consent cookie

After introducing the new flags and setting the domain for the
cookie, the Capybara cookie was overriding the cookie set by JS
because it had incorrect domain (JS allows also subdomains).

Also add the extra flags to the default cookie that were added to
the JS for consistency and to avoid potential side effects.

* Fix the organization data consent spec after the default cookie changes

* Fix the default cookie if the domain is localhost

* Improve the expectation for the cookie expiry

* Change `cookie` to `dataconsent` in the CSS class names

* Rename `cc-` prefix to `dc-` in the data consent HTML IDs and classes

* Update the development app notes

* Update ruby version for the SSL tests

* Apply modifications to the cookie consent description based on review

* Add Markdown linter CI workflow (#9446)

* Add Markdown linter rake task

* Add 'Lint Markdown files' step in CI

* Add excluded files on markdown linter task

* Fix heading levels

* Specify language in fenced code block

* Fix unordered list styles

* Fix ordered list prefixes

* Escape HTML tag

* Simplify system admin creation documentation on generated README

* Ignore the 'Multiple top level headers' rule in Participatory Texts example doc

* Add ignore_rules_for_file logic in markdown linter

* Ignore the 'Multiple top level headers' rule in Participatory Texts seed example

* Ignore the 'First header should be a top level header' rule in GraphQL API doc

* Remove mdl gem and configuration

* Add markdownlint-cli NPM package and configuration

* Change mdl references to markdownlint-cli

* Fix linter offenses

* Remove codeclimate markdownlint plugin

* Add inline ignore rules in Participatory Texts examples

* Ignore HTML comments when importing Markdown files

* Fix HTML tags on spec

* Reintroduce wrongly deleted stylelint script

* Explicitly add fileutils as requirement

If not, I have this exception when calling it directly:

$ bin/rspec spec/webpacker_spec.rb

(...)
NameError:
  uninitialized constant FileUtils
  Did you mean?  FileTest
(...)

* Sync npm packages files

* Update spec to remove HTML comments

* Fix the decidim-packs ignore from markdownlint

* Change the markdownlint script name and the glob match pattern

* Fix the disable file inline comment

* Move the strong style and emphasis style excludes to correct file

* Move the markdownlint-cli package to the distributed dev package

* Fix the markdownlint script name in the github action

* Remove unnecessary added linebreak from the Rakefile

* Rename the markdownlint.yml config file extension for consistency

* Fix missing markdownlint

* Exclude link-fragments rule for the API usage.md

* Add examples how to lint and fix markdownlint issues

* Rake bundle

Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>

* Fix broken link in the data consent documentation (#9665)

* Fix uninitialized constant errors with custom set of modules (#9577)

* Fix uninitialized constant errors for unexisting modules

* Add specs for the dependency resolver

* Document the method without documentation

* Remove unnecessary commented code

* DRY comments

* Reset the resolver cache during the tests

* Add debug messages for CI

* More debug

* Try relative paths to the git gems in the custom Gemfile

* Print out the generated Gemfile.lock

* Revert "Try relative paths to the git gems in the custom Gemfile"

This reverts commit bb2f675.

* Print out the root dirs in the test debug

* Revert "Print out the root dirs in the test debug"

This reverts commit 06983f1.

* Move debug to its own spec

* Print out bundle(r) and gem related ENV vars

* More debug logging

* Remove the unnecessary yield argument

* Fix syntax error

* Add debug for the dummy lockfile generation

* Report bundle not frozen during the custom Gemfile specs

* Remove the debug output from the custom Gemfile specs

* Add specs for `Decidim.module_installed?`

* Add missing return value YARD docs

* Rubocop auto-correct

* Fix PWA install prompt keeps appearing more than once (#9603)

* Prevent the PWA install notification after user has seen it

* Add the new local storage item to the essential local data

* Refactor the install prompt prevention to a2hs.js at the sw folder

* Redesign: blogs (#9436)

* two-columns layout

* card blog

* layout index blog

* one column layout + decorator

* blog post show prose

* Enable explicitly redesign on posts controller

* replace locals by content_for block

* single post botton bar

* fix bg-color new tailwind setup

* remove unnecessary css class

* restore post description

* add filter component (non-functional)

* fix blog glitches

* adapt blogs show to new layout

* Fix presenter detection of author on blogs

* Refactor actions on author cell

* Remove unused partial

* Recover id in follow_button to allow ajax refresh

* Remove unused translations

* Update selector in posts tests

* Use paginable concern in posts controller

* Fix pagination test in posts

* Remove deprecated test

The back button dissapear in the redesign

* Remove deprecated test

The most commented section is removed in the redesign

* Replace TODOs with REDESIGN PENDING

* Revert comment

* Integrate endorsers list

* Allow to define which context actions may appear in author cell

* Split endorsements_button in redesigned and legacy design versions

* Fix js endorsements template to take into account redesign

* Define profile from cell in redesigned author cell

* Update test to take into account redesign in endorsements feature

* Sanitize title in debates card

* Split follow button in redesigned and legacy versions

* Remove read more link from blog descriptions in index

* export layout 2 columns

* fixes on blog lists

* fix glitches blog show

* fix lint

* Allow definition of a layout in redesigned author cell

* Include layouct and context actions in cache key of redesigned author cell

* alternative design blog author

* set generic layouts

* Refactor author compact display

* endorsers list toggler

* update buttons classes

* blog buttons

* apply button updates

* avoid tailwind compilation

* Allow to provide options to redesigned_follow_button from helper using it

* Allow redesigned author to display only avatar image

* Define full list view in endorsers_list cell and use avatar version of redesigned author cell

* set fixed bottom space

* Allow to provide options to redesigned_follow_button from helper using it

* Fix translation

* restore script

* set gradient stops

* fix lint

* Fix linter offense

* responsive 2col layout

* icon to endorsements

* restore h4

* replace button and hide links

* fix actions menu mobile

* Update default tail for html truncation

* Use default tail chars

* Fix specs

* close endorsements as button

* skip links

* remove unnecessary role

Co-authored-by: Eduardo Martinez Echevarria <eduardomech@gmail.com>
Co-authored-by: Fernando Blat <fernando@blat.es>

* fixes conferences mobile

* conference registration desktop

* hide temporary banner

* resposive registration

* desktop conference program w/ interaction

* fix tailwind compilation

* split large file into minor ones

* duplicate time events

* fix style issues

* Update test selectors and expected texts

* Update selector in test

* Remove conferences from entrypoints test

The conferences.scss file is no longer loaded through
Decidim::Webpacker.register_stylesheet_import mechanism and is imported
directly from decidim_conferences javascript file

* Fix linter offenses

* Remove unused translations

* Update test selectors and expected texts

* Fix linter offense

* Wrap conference data in show view in a div for tests

* Fix some tests selectors and expected texts

* Update test

* Restrict redesign_participatory_space_layout to show action and include contextual help in index view

* rename partials

* fix tests

* Update tests

* Fix text

* Fix expected texts

* Add redesigned conference participatory space layout

* Define redesigned participatory_space context layout correctly

* Fix test and avoid ambiguities

* Update conferences cells tests

* move resources to the layout

* Allow setting fallback layout when there are participatory_space_layout definitions

* Set layout for controllers not using participatory_space_layout in conferences

* general fixes in conference module

* implement speakers modal 🎉

* implement modal for registration

* implement modal for registration

* program mobile version

* Test helper to generate modals

* modal helper generalization

* use item_list component styles for listing

* Extract items of navigation menu of a conference to a helper

* Revert "use item_list component styles for listing"

The reverted commit produced compilation errors

This reverts commit 780815a.

* Fix linter offense

* Fix test

* Recover text argument in link_to call

* Remove unused translation

* allow modal to have id

* style login modal form

* fix common classes

* missing dialog-title (a11y)

* Disable default class on login modal form

* Remove unused translation

* Hide attributes which can generate accesibility issues

REDESIGN_PENDING See the comment

* Avoid accessibility errors with old layout

* conditionally append the aria tagging for optional attributes

* Split login modal in legacy and redesigned versions

* Prepare button to open login modal to work with redesigned and legacy layouts

* Change selectors in tests

* Recover authorize before action in redesgin_participatory_space_layout

* Fix selector in text

* Update expected text in test

* Allow skipping before_action on redesign_participatory_space_layout in favor of other filters

* Fix selector in tests

* add new font size for heros

* apply the font-size hero to conferences

* simplify flash position: always on top

* simplify test markup

* add generic button css classes

* update cell buttons with the new defaults classes

* fix registration button style

* responsive margins on register

* replace lateral menu with dropdown on mobile

* fix modal

* underline links & test button truncate

* Don't pass options to layout in redesign_participatory_space_layout

* extract dropdown common css to file

* enable login boxes

* linked resources block

* fix bad assignment

* hide the dropdown mobile by default (no jumping effect)

* remove floating help

* hide temporary the spaces help

* show the floating help to avoid tests fails

* fix external_icon to use redesidnged icon lib

* conferences media view: links & photos

* conferences media view: documents (separated component)

* conferences media view: responsive

* remove unused locales

* fix onmiauth buttons

* fix design glitches program view

* fix media design glitches

* Fix selectors in tests

* unbind tests from css classes

* extract card grid/highlight from conferences to core

* Fix selectors in tests

* add id to resources in order to specify capybara tests

* fix selectors in tests

* Skip test

* add metadata styles to the cards

* adjustments responsive cards

* add min width to buttons, in order to apply truncate props

* Edit text

* handle conference map (if enable or not)

* force scroll in modal contents if so large

* the modal cannot be inside the modal trigger

* distinguish conference programs

* place floating_help

* fix a11y

* rescue original participatory_space_floating_help methods

* restore link text to component_name instead of program

* set gap in content blocks

* fix glitches in mobile & code reviews

* small css glitch

* add changes from #10007

* move CSS specification to its own file

* fixes a11y

* avoid foundation [data-open] throws error

* merge item-list into card css component

* update item-list* classes with card__list*

* adapt login modal to follow a regular markup

* don't allow custom htl text on descriptions

* remove cursor pointer on hover

* add title to content-block component

* tune documents partial

* add note

* don't hover if not clickable

* limit size conference media sections

* add border when sibling

* simplify card grid text container

* remove literal

* remove price if it's empty or zero

* disable also in registration (specifity)

* extract photos cell from conferences to core

* remove the title from the partials (it should be added by the container)

* remove the margin-top for components since its their container who sets that up

* align left if only child

* update i18n key

* update tests for attachments

* more specific css component rule

* make link specific css

* add span style as component part

* wrap button text contents

Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Co-authored-by: eliegaboriau <93646702+eliegaboriau@users.noreply.github.com>
Co-authored-by: Eduardo Martinez Echevarria <eduardomech@gmail.com>
Co-authored-by: Fernando Blat <fernando@blat.es>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: internal PRs that aren't necessary to add to the CHANGELOG for implementers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants