Skip to content

Redesign: blogs#9436

Merged
ahukkanen merged 70 commits intodevelopfrom
feature/redesign-blogs
Aug 10, 2022
Merged

Redesign: blogs#9436
ahukkanen merged 70 commits intodevelopfrom
feature/redesign-blogs

Conversation

@Crashillo
Copy link
Copy Markdown
Contributor

@Crashillo Crashillo commented Jun 14, 2022

🎩 What? Why?

Redesign blog pages. It includes the blog list (index) and the blog post (show)

📌 Related Issues

This PR has built on top of #9340

📷 Screenshots

♥️ Thank you!

@entantoencuanto entantoencuanto force-pushed the feature/redesign-main-layout branch from 181ffdf to 0e98e7b Compare June 14, 2022 16:18
@entantoencuanto entantoencuanto force-pushed the feature/redesign-blogs branch 2 times, most recently from d3483f3 to 787992f Compare June 15, 2022 09:54
@Crashillo Crashillo force-pushed the feature/redesign-blogs branch from 787992f to b8c41d2 Compare June 15, 2022 10:31
@entantoencuanto entantoencuanto force-pushed the feature/redesign-blogs branch from b8c41d2 to 476af8a Compare June 15, 2022 12:08
@entantoencuanto entantoencuanto force-pushed the feature/redesign-main-layout branch from e15f338 to 3b20bc1 Compare June 15, 2022 17:35
@entantoencuanto entantoencuanto force-pushed the feature/redesign-blogs branch from 5cdf082 to 7f16784 Compare June 15, 2022 18:47
@Crashillo Crashillo force-pushed the feature/redesign-blogs branch 2 times, most recently from 5cb8704 to 792735d Compare June 16, 2022 11:57
@entantoencuanto entantoencuanto force-pushed the feature/redesign-blogs branch from 792735d to 8842667 Compare June 16, 2022 15:02
@entantoencuanto entantoencuanto force-pushed the feature/redesign-main-layout branch from 2ca28a0 to cfbf446 Compare June 16, 2022 15:42
@entantoencuanto entantoencuanto force-pushed the feature/redesign-blogs branch from 8842667 to 231eff4 Compare June 16, 2022 15:51
@Crashillo Crashillo changed the base branch from feature/redesign-main-layout to feature/redesign-components June 16, 2022 16:27
@Crashillo Crashillo force-pushed the feature/redesign-blogs branch from 231eff4 to e01f738 Compare June 16, 2022 17:27
@entantoencuanto entantoencuanto force-pushed the feature/redesign-blogs branch from d14acf5 to f08b416 Compare June 17, 2022 09:14
@Crashillo Crashillo force-pushed the feature/redesign-blogs branch 2 times, most recently from fb31443 to 0f96a30 Compare June 17, 2022 15:09
@entantoencuanto entantoencuanto force-pushed the feature/redesign-components branch from 81a9cb4 to 6275947 Compare June 17, 2022 19:04
@entantoencuanto entantoencuanto force-pushed the feature/redesign-blogs branch from 0f96a30 to 9fefb26 Compare June 17, 2022 19:13
@Crashillo Crashillo force-pushed the feature/redesign-components branch from 6275947 to 7d748f6 Compare June 20, 2022 11:21
@entantoencuanto entantoencuanto force-pushed the feature/redesign-components branch from 7d748f6 to 1e068e4 Compare June 20, 2022 14:38
@entantoencuanto entantoencuanto force-pushed the feature/redesign-blogs branch from 9fefb26 to 6ee9ec0 Compare June 20, 2022 20:20
@andreslucena andreslucena added project: redesign Barcelona City Council contract and removed contract: lot: px labels Jun 21, 2022
@Crashillo Crashillo force-pushed the feature/redesign-blogs branch from 6ee9ec0 to dbe122e Compare June 21, 2022 09:56
Base automatically changed from feature/redesign-components to feature/redesign-main-layout June 21, 2022 11:44
@entantoencuanto entantoencuanto force-pushed the feature/redesign-blogs branch 2 times, most recently from 80ccb13 to eae629e Compare June 27, 2022 16:54
@Crashillo Crashillo force-pushed the feature/redesign-blogs branch from de219f8 to 55f0468 Compare June 28, 2022 15:48
@Crashillo
Copy link
Copy Markdown
Contributor Author

Crashillo commented Aug 5, 2022

I would like to pull out some missing features of this PR, due to the issue I commented here, in order to an easier development process. That is, to focus in merging this kind of PRs, even they're kind of incomplete, since they contain common stuff useful for the another branches, and it's being a real struggle to make them work properly.

We're already tracking those missing features in different issues.

@ahukkanen
Copy link
Copy Markdown
Contributor

I would like to pull out some missing features of this PR, due to the issue I commented here, in order to an easier development process. That is, to focus in merging this kind of PRs, even they're kind of incomplete, since they contain common stuff useful for the another branches, and it's being a real struggle to make them work properly.

We're already tracking those missing features in different issues.

This is all fine for me, it's also difficult to review these piece by piece as I have no idea what is supposed to work and what is not supposed to work. I am basically testing them out blindfolded of the whole redesign process and just reporting any issues I am able to find.

It is fine to merge these already beforehand but I understand that the "login & signup" was the priority PR that should be merged first as we discussed in the last few PX meetings. For that I have few kind requests:

  • The build should not break due to the redesign changes and it is currently broken in that PR (a couple of specs, don't worry about the flaky ones, I am rerunning them as they fail)
  • The simple change requests should be addressed prior to merging, such as changing the default tail (which by the way might also require some changes in the related specs or alternatively just go with the legacy default to avoid breaking specs and change the tail after the redesign is fully completed)

Also we need to consider few things as we are breaking the old designs piece-by-piece when we merge these:

  • It should be crystal clear for everyone related that we are "breaking" the nightly builds piece by piece, we've already got a couple of bug reports regarding these changes so clearly not everyone is aware of this (even those who are aware of the ongoing redesign process)
  • The maintainers are not the ones keeping track of the issues raised in the PR comments if we merge them before they are resolved. So I hope you will create issues internally (as you mentioned) for all of the unresolved review comments as otherwise it will become really hard to manage and finally we will have to make the same remarks for a second time, causing extra work.

Just saying out loud what's in my head, all with good intention. I am all for moving this forward quickly, because that will make the job easier for everyone at the later stages.

@ferblape
Copy link
Copy Markdown
Contributor

ferblape commented Aug 9, 2022

@ahukkanen totally agree with your concerns and your comments. I spoke yesterday with @Crashillo and he would like to prioritize the merging of this PR because contains layout changes that affect other PRs.

Would you be happy if I create an issue (in this repo) with the "Follow button" error and you prioritize the merging of this one?

On the other side, we spoke to create this pending issues in this repository, not in our private repo anymore @Crashillo

@ahukkanen
Copy link
Copy Markdown
Contributor

@ahukkanen totally agree with your concerns and your comments. I spoke yesterday with @Crashillo and he would like to prioritize the merging of this PR because contains layout changes that affect other PRs.

Sure, I'll have another look at this then shortly.

Would you be happy if I create an issue (in this repo) with the "Follow button" error and you prioritize the merging of this one?

On the other side, we spoke to create this pending issues in this repository, not in our private repo anymore @Crashillo

Yes please, that would be perfect. Just tag them accordingly so that it's easy to see which ones are related to redesign.

Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just gave this another spin and all the issues have been resolved from the previous review.

There are still some problems that I've noticed after giving it another spin. They are listed below for the specific locations where the issues appear.

@Crashillo @ferblape Do you want me to merge this anyways even when there are still these issues? Will you create separate issues for those that will be handled later?

</div>
<% end %>

<div class="blogs__list-item__content">
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still few problems with the blog post links on the index page:

  1. The description does not link anywhere
  2. There are multiple links to the same target URL next to each other (as indicated with the red boxes in the image)
    Blog post links

I know that in the second point the bottom links are linking to different anchor positions on the page but this is problematic especially for blind keyboard users who will now browse through 4 links to the same target when browsing the site. Please see:
https://www.w3.org/WAI/WCAG21/Techniques/html/H2
https://www.hawaii.edu/access/2019/04/17/19-adjacent-links-used-for-same-destination/

For the first point, it would be important that the whole element is clickable especially for people browsing the site using touch devices. Otherwise they probably think that the site is not working as when they click a blog post they are unable to enter the blog post page (when clicking the description of the post). This is just a general usability issue but it should be fixed by following the accessibility guidelines as stated in the second point.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the new design, the item's metadata (author, endorsements, comments) are not links, so we'll remove them and make the entire item clickable.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed to #9671. It's not straight-forward

<%= stylesheet_pack_tag "decidim_blogs", media: "all" %>
<% end %>

<%= render layout: "layouts/decidim/shared/layout_center" do %>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One general issue I still noticed is that there is not back link on the single blog post page to get back to the posts listing. I understand the redesign introduces the breadcrumbs navigation that would help with this but it would still be important to always have the back link to the listing page to make it easier to navigate the site.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you say, the idea is to use breadcrumb navigation to move between sections, but there are sections where the link may be necessary. We'll check it out later

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find those back links useful myself when browsing a website + sometimes they can help people landing on these pages through search engines to discover more content. In this sense, they should not actually be labelled as "back" links but rather something like "Show all articles" in this situation with an icon indicating it is going one level up.

Many blogging services show links like "Read more from N.N.", "Read these next", "See all from X", some examples include:

https://medium.com/airbnbmag/the-insiders-guide-to-barcelona-555b0cfa2804
More from author

https://www.linkedin.com/pulse/mapping-end-malaria-bill-gates
More articles from this author

https://dev.to/michaeltharrington/can-code-be-poetic-4l1i
Read next

These links increase the time users spend on the site as they find possibly more interesting content. We don't have to go as far as these services but just to support my point of bringing the "show all articles" link back.

This does not only apply to blog posts but other similar places, such as proposals, meetings, etc. where we have the "back" links currently.

But I'll leave that for your consideration, so I'd appreciate if you could look into this later.

@ahukkanen
Copy link
Copy Markdown
Contributor

Also I noticed this scaling issue with the smaller sizes when I scale the view down:

decidim-blogs-listing-scaling-issue.mp4

While the mobile screens are getting bigger and bigger these days, I think we should still assume the smallest possible screen width at 320px for maximum compatibility. There are still devices with this screen size especially at the emerging markets.

Right now it starts hiding part of the content around 400px width (as shown in the video).

@Crashillo
Copy link
Copy Markdown
Contributor Author

Do you want me to merge this anyways even when there are still these issues? Will you create separate issues for those that will be handled later?

There are some minor fixes I can attach straight here, I'll mark them as resolved once done. The rest will be addressed

@Crashillo
Copy link
Copy Markdown
Contributor Author

Crashillo commented Aug 10, 2022

I think we should still assume the smallest possible screen width at 320px for maximum compatibility

I presume this won't be longer a problem from we'll apply the "Allow to hide only the texts" pending point on.

So, anything else can be done here, we can merge it 👍 ✌️

Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you still do a small change not to leave a bad example laying around? See below.

After this, let's merge it and leave the other pending issues at #9671.

@Crashillo Crashillo requested a review from ahukkanen August 10, 2022 13:38
Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the remaining issues listed at #9671.

There was one more point which was discussed with @rober-gd regarding the "back" links which was not added to the pending issues but I hope he reads through the conversation above.

@ahukkanen ahukkanen merged commit 4b87e1c into develop Aug 10, 2022
@ahukkanen ahukkanen deleted the feature/redesign-blogs branch August 10, 2022 14:17
Crashillo added a commit that referenced this pull request Aug 10, 2022
* two-columns layout

* card blog

* layout index blog

* one column layout + decorator

* blog post show prose

* Enable explicitly redesign on posts controller

* replace locals by content_for block

* single post botton bar

* fix bg-color new tailwind setup

* remove unnecessary css class

* restore post description

* add filter component (non-functional)

* fix blog glitches

* adapt blogs show to new layout

* Fix presenter detection of author on blogs

* Refactor actions on author cell

* Remove unused partial

* Recover id in follow_button to allow ajax refresh

* Remove unused translations

* Update selector in posts tests

* Use paginable concern in posts controller

* Fix pagination test in posts

* Remove deprecated test

The back button dissapear in the redesign

* Remove deprecated test

The most commented section is removed in the redesign

* Replace TODOs with REDESIGN PENDING

* Revert comment

* Integrate endorsers list

* Allow to define which context actions may appear in author cell

* Split endorsements_button in redesigned and legacy design versions

* Fix js endorsements template to take into account redesign

* Define profile from cell in redesigned author cell

* Update test to take into account redesign in endorsements feature

* Sanitize title in debates card

* Split follow button in redesigned and legacy versions

* Remove read more link from blog descriptions in index

* export layout 2 columns

* fixes on blog lists

* fix glitches blog show

* fix lint

* Allow definition of a layout in redesigned author cell

* Include layouct and context actions in cache key of redesigned author cell

* alternative design blog author

* set generic layouts

* Refactor author compact display

* endorsers list toggler

* update buttons classes

* blog buttons

* apply button updates

* avoid tailwind compilation

* Allow to provide options to redesigned_follow_button from helper using it

* Allow redesigned author to display only avatar image

* Define full list view in endorsers_list cell and use avatar version of redesigned author cell

* set fixed bottom space

* Allow to provide options to redesigned_follow_button from helper using it

* Fix translation

* restore script

* set gradient stops

* fix lint

* Fix linter offense

* responsive 2col layout

* icon to endorsements

* restore h4

* replace button and hide links

* fix actions menu mobile

* Update default tail for html truncation

* Use default tail chars

* Fix specs

* close endorsements as button

* skip links

* remove unnecessary role

Co-authored-by: Eduardo Martinez Echevarria <eduardomech@gmail.com>
Co-authored-by: Fernando Blat <fernando@blat.es>
eliegaboriau pushed a commit to eliegaboriau/decidim that referenced this pull request Oct 25, 2022
* two-columns layout

* card blog

* layout index blog

* one column layout + decorator

* blog post show prose

* Enable explicitly redesign on posts controller

* replace locals by content_for block

* single post botton bar

* fix bg-color new tailwind setup

* remove unnecessary css class

* restore post description

* add filter component (non-functional)

* fix blog glitches

* adapt blogs show to new layout

* Fix presenter detection of author on blogs

* Refactor actions on author cell

* Remove unused partial

* Recover id in follow_button to allow ajax refresh

* Remove unused translations

* Update selector in posts tests

* Use paginable concern in posts controller

* Fix pagination test in posts

* Remove deprecated test

The back button dissapear in the redesign

* Remove deprecated test

The most commented section is removed in the redesign

* Replace TODOs with REDESIGN PENDING

* Revert comment

* Integrate endorsers list

* Allow to define which context actions may appear in author cell

* Split endorsements_button in redesigned and legacy design versions

* Fix js endorsements template to take into account redesign

* Define profile from cell in redesigned author cell

* Update test to take into account redesign in endorsements feature

* Sanitize title in debates card

* Split follow button in redesigned and legacy versions

* Remove read more link from blog descriptions in index

* export layout 2 columns

* fixes on blog lists

* fix glitches blog show

* fix lint

* Allow definition of a layout in redesigned author cell

* Include layouct and context actions in cache key of redesigned author cell

* alternative design blog author

* set generic layouts

* Refactor author compact display

* endorsers list toggler

* update buttons classes

* blog buttons

* apply button updates

* avoid tailwind compilation

* Allow to provide options to redesigned_follow_button from helper using it

* Allow redesigned author to display only avatar image

* Define full list view in endorsers_list cell and use avatar version of redesigned author cell

* set fixed bottom space

* Allow to provide options to redesigned_follow_button from helper using it

* Fix translation

* restore script

* set gradient stops

* fix lint

* Fix linter offense

* responsive 2col layout

* icon to endorsements

* restore h4

* replace button and hide links

* fix actions menu mobile

* Update default tail for html truncation

* Use default tail chars

* Fix specs

* close endorsements as button

* skip links

* remove unnecessary role

Co-authored-by: Eduardo Martinez Echevarria <eduardomech@gmail.com>
Co-authored-by: Fernando Blat <fernando@blat.es>
ahukkanen added a commit that referenced this pull request Dec 22, 2022
* preparation conference assets

* highlight conferences block

* card grid

* differenciate between index & show

* fix ruby lint

* create reverse layout

* conferences show and partners

* refactor address cells repeated, extracted to component

* reformat map section

* conferences hero block

* conferences navigation

* add no-external-link, simplify partial

* fix erb lint

* create layout 2col

* add future boxes when they're ready

* conference speakers dekstop

* mobile tuning

* Fix account update without password change (#9582)

* Handle password change properly at the account form

When the user tried to update their account without changing their
password, they could not submit the form due to the front-end
validations.

Fix this issue by marking those fields required only when they
are visible on the form.

* Make sure the spec checks the encrypted password is not changed

When account is updated without providing a password, the
encrypted password shouldn't change.

* Do not autofill the password on the account form

In tests, the user record responds to `.password` which causes
the account form updates to work differently in tests than they do
for actual users.

* Apply feedback from the code review

* Add also password and password confirmation errors on the form

In case the password update failed, the user doesn't get any
feedback. This fixes that issue.

* Fix order when filtering Meetings (#9505)

* Change date meetings filters checkboxes to radio buttons

* Fix default upcoming filter on meetings' controller

* Order filtered meetings by start_time

* Use Faker::Date in meetings' seeds

* Convert let definitions to one line blocks

* Fix typo

* Add default filter specs for Upcoming meetings

* Add specs for 'date filters' on meetings

* Reintroduces the 'All' filter for meetings dates

* Remove uneceessary instance variable

Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>

* Fix for 500 errors on static maps

* Preserve the currently selected per_page value with filter forms

* Fix the broken specs due to changes in the per_page configuration

* Do not use concat in helpers that are used in cells

* Rubocop

Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>

* Fix admin autocomplete with extra URL parameters (e.g. locale) (#9650)

* Fix issues with daily and weekly notifications (#9599)

* Fix notification daily and weekly status

* Fix notification digest sending decider to check from the end of the day

* Rubocop

* Fix blocked user nickname and avatar in user presenter (#9659)

* modify nickname and avatar in user presenter

* add spec

* modify nickname

* Fix data consent expiry (#9570)

* Rename cookie_consent to data_consent

* Rename the data consent entry point to index.js

* Fix the data consent entry point definition (wrong naming)

* Fix the reference to the consent manager

* Set the expiry period for the data consent cookie to 365 days

* Add the secure flag to the cookie when under https

* Add the domain and SameSite to the consent cookie

* Add possibility to use HTTPS in development and tests

* Add jest tests to test the cookie flags for the consent manager

* Add system spec for the data consent

* Add CI action for testing some of the system specs under HTTPS

* Rename cookie_consent to data_consent and cookie_details to details

In order not to confuse implementors that the data consent is not
only about cookies.

* Remove further references to cookies from the translations and code

* Update docs with the latest code changes and remove references to cookies

* Rename "cookies" doc page to "data_consent" and add relevant changes

Add a note that the data consent is not only about cookies.

* Add the review suggestions to the data consent docs

* Update the documentation regarding testing under SSL

* ESLint

* Rename cookie_consent_warning partial to data_consent_warning

* Fix the translation key for data_consent_settings

* Fix the translation keys for data consent warning

* Refine the JS code comments not to refer particularly to cookie consent

* Rename the "cookies" system specs to "data_consent"

* Move the data consent cookie flags test to the "data_consent" folder

* Update the reference to the correct test in the core system SSL action

* Update the action name for better ordering in the list

* Change the cookie-consent SCSS file name to data-consent

* Update the reference to data-consent SCSS in the docs

* Update the capybara helper to data_consent and the related module name

* Fix partial name in meetings

* Fix the comments in the initializer template

* Fix the domain and flags in the default consent cookie

After introducing the new flags and setting the domain for the
cookie, the Capybara cookie was overriding the cookie set by JS
because it had incorrect domain (JS allows also subdomains).

Also add the extra flags to the default cookie that were added to
the JS for consistency and to avoid potential side effects.

* Fix the organization data consent spec after the default cookie changes

* Fix the default cookie if the domain is localhost

* Improve the expectation for the cookie expiry

* Change `cookie` to `dataconsent` in the CSS class names

* Rename `cc-` prefix to `dc-` in the data consent HTML IDs and classes

* Update the development app notes

* Update ruby version for the SSL tests

* Apply modifications to the cookie consent description based on review

* Add Markdown linter CI workflow (#9446)

* Add Markdown linter rake task

* Add 'Lint Markdown files' step in CI

* Add excluded files on markdown linter task

* Fix heading levels

* Specify language in fenced code block

* Fix unordered list styles

* Fix ordered list prefixes

* Escape HTML tag

* Simplify system admin creation documentation on generated README

* Ignore the 'Multiple top level headers' rule in Participatory Texts example doc

* Add ignore_rules_for_file logic in markdown linter

* Ignore the 'Multiple top level headers' rule in Participatory Texts seed example

* Ignore the 'First header should be a top level header' rule in GraphQL API doc

* Remove mdl gem and configuration

* Add markdownlint-cli NPM package and configuration

* Change mdl references to markdownlint-cli

* Fix linter offenses

* Remove codeclimate markdownlint plugin

* Add inline ignore rules in Participatory Texts examples

* Ignore HTML comments when importing Markdown files

* Fix HTML tags on spec

* Reintroduce wrongly deleted stylelint script

* Explicitly add fileutils as requirement

If not, I have this exception when calling it directly:

$ bin/rspec spec/webpacker_spec.rb

(...)
NameError:
  uninitialized constant FileUtils
  Did you mean?  FileTest
(...)

* Sync npm packages files

* Update spec to remove HTML comments

* Fix the decidim-packs ignore from markdownlint

* Change the markdownlint script name and the glob match pattern

* Fix the disable file inline comment

* Move the strong style and emphasis style excludes to correct file

* Move the markdownlint-cli package to the distributed dev package

* Fix the markdownlint script name in the github action

* Remove unnecessary added linebreak from the Rakefile

* Rename the markdownlint.yml config file extension for consistency

* Fix missing markdownlint

* Exclude link-fragments rule for the API usage.md

* Add examples how to lint and fix markdownlint issues

* Rake bundle

Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>

* Fix broken link in the data consent documentation (#9665)

* Fix uninitialized constant errors with custom set of modules (#9577)

* Fix uninitialized constant errors for unexisting modules

* Add specs for the dependency resolver

* Document the method without documentation

* Remove unnecessary commented code

* DRY comments

* Reset the resolver cache during the tests

* Add debug messages for CI

* More debug

* Try relative paths to the git gems in the custom Gemfile

* Print out the generated Gemfile.lock

* Revert "Try relative paths to the git gems in the custom Gemfile"

This reverts commit bb2f675.

* Print out the root dirs in the test debug

* Revert "Print out the root dirs in the test debug"

This reverts commit 06983f1.

* Move debug to its own spec

* Print out bundle(r) and gem related ENV vars

* More debug logging

* Remove the unnecessary yield argument

* Fix syntax error

* Add debug for the dummy lockfile generation

* Report bundle not frozen during the custom Gemfile specs

* Remove the debug output from the custom Gemfile specs

* Add specs for `Decidim.module_installed?`

* Add missing return value YARD docs

* Rubocop auto-correct

* Fix PWA install prompt keeps appearing more than once (#9603)

* Prevent the PWA install notification after user has seen it

* Add the new local storage item to the essential local data

* Refactor the install prompt prevention to a2hs.js at the sw folder

* Redesign: blogs (#9436)

* two-columns layout

* card blog

* layout index blog

* one column layout + decorator

* blog post show prose

* Enable explicitly redesign on posts controller

* replace locals by content_for block

* single post botton bar

* fix bg-color new tailwind setup

* remove unnecessary css class

* restore post description

* add filter component (non-functional)

* fix blog glitches

* adapt blogs show to new layout

* Fix presenter detection of author on blogs

* Refactor actions on author cell

* Remove unused partial

* Recover id in follow_button to allow ajax refresh

* Remove unused translations

* Update selector in posts tests

* Use paginable concern in posts controller

* Fix pagination test in posts

* Remove deprecated test

The back button dissapear in the redesign

* Remove deprecated test

The most commented section is removed in the redesign

* Replace TODOs with REDESIGN PENDING

* Revert comment

* Integrate endorsers list

* Allow to define which context actions may appear in author cell

* Split endorsements_button in redesigned and legacy design versions

* Fix js endorsements template to take into account redesign

* Define profile from cell in redesigned author cell

* Update test to take into account redesign in endorsements feature

* Sanitize title in debates card

* Split follow button in redesigned and legacy versions

* Remove read more link from blog descriptions in index

* export layout 2 columns

* fixes on blog lists

* fix glitches blog show

* fix lint

* Allow definition of a layout in redesigned author cell

* Include layouct and context actions in cache key of redesigned author cell

* alternative design blog author

* set generic layouts

* Refactor author compact display

* endorsers list toggler

* update buttons classes

* blog buttons

* apply button updates

* avoid tailwind compilation

* Allow to provide options to redesigned_follow_button from helper using it

* Allow redesigned author to display only avatar image

* Define full list view in endorsers_list cell and use avatar version of redesigned author cell

* set fixed bottom space

* Allow to provide options to redesigned_follow_button from helper using it

* Fix translation

* restore script

* set gradient stops

* fix lint

* Fix linter offense

* responsive 2col layout

* icon to endorsements

* restore h4

* replace button and hide links

* fix actions menu mobile

* Update default tail for html truncation

* Use default tail chars

* Fix specs

* close endorsements as button

* skip links

* remove unnecessary role

Co-authored-by: Eduardo Martinez Echevarria <eduardomech@gmail.com>
Co-authored-by: Fernando Blat <fernando@blat.es>

* fixes conferences mobile

* conference registration desktop

* hide temporary banner

* resposive registration

* desktop conference program w/ interaction

* fix tailwind compilation

* split large file into minor ones

* duplicate time events

* fix style issues

* Update test selectors and expected texts

* Update selector in test

* Remove conferences from entrypoints test

The conferences.scss file is no longer loaded through
Decidim::Webpacker.register_stylesheet_import mechanism and is imported
directly from decidim_conferences javascript file

* Fix linter offenses

* Remove unused translations

* Update test selectors and expected texts

* Fix linter offense

* Wrap conference data in show view in a div for tests

* Fix some tests selectors and expected texts

* Update test

* Restrict redesign_participatory_space_layout to show action and include contextual help in index view

* rename partials

* fix tests

* Update tests

* Fix text

* Fix expected texts

* Add redesigned conference participatory space layout

* Define redesigned participatory_space context layout correctly

* Fix test and avoid ambiguities

* Update conferences cells tests

* move resources to the layout

* Allow setting fallback layout when there are participatory_space_layout definitions

* Set layout for controllers not using participatory_space_layout in conferences

* general fixes in conference module

* implement speakers modal 🎉

* implement modal for registration

* implement modal for registration

* program mobile version

* Test helper to generate modals

* modal helper generalization

* use item_list component styles for listing

* Extract items of navigation menu of a conference to a helper

* Revert "use item_list component styles for listing"

The reverted commit produced compilation errors

This reverts commit 780815a.

* Fix linter offense

* Fix test

* Recover text argument in link_to call

* Remove unused translation

* allow modal to have id

* style login modal form

* fix common classes

* missing dialog-title (a11y)

* Disable default class on login modal form

* Remove unused translation

* Hide attributes which can generate accesibility issues

REDESIGN_PENDING See the comment

* Avoid accessibility errors with old layout

* conditionally append the aria tagging for optional attributes

* Split login modal in legacy and redesigned versions

* Prepare button to open login modal to work with redesigned and legacy layouts

* Change selectors in tests

* Recover authorize before action in redesgin_participatory_space_layout

* Fix selector in text

* Update expected text in test

* Allow skipping before_action on redesign_participatory_space_layout in favor of other filters

* Fix selector in tests

* add new font size for heros

* apply the font-size hero to conferences

* simplify flash position: always on top

* simplify test markup

* add generic button css classes

* update cell buttons with the new defaults classes

* fix registration button style

* responsive margins on register

* replace lateral menu with dropdown on mobile

* fix modal

* underline links & test button truncate

* Don't pass options to layout in redesign_participatory_space_layout

* extract dropdown common css to file

* enable login boxes

* linked resources block

* fix bad assignment

* hide the dropdown mobile by default (no jumping effect)

* remove floating help

* hide temporary the spaces help

* show the floating help to avoid tests fails

* fix external_icon to use redesidnged icon lib

* conferences media view: links & photos

* conferences media view: documents (separated component)

* conferences media view: responsive

* remove unused locales

* fix onmiauth buttons

* fix design glitches program view

* fix media design glitches

* Fix selectors in tests

* unbind tests from css classes

* extract card grid/highlight from conferences to core

* Fix selectors in tests

* add id to resources in order to specify capybara tests

* fix selectors in tests

* Skip test

* add metadata styles to the cards

* adjustments responsive cards

* add min width to buttons, in order to apply truncate props

* Edit text

* handle conference map (if enable or not)

* force scroll in modal contents if so large

* the modal cannot be inside the modal trigger

* distinguish conference programs

* place floating_help

* fix a11y

* rescue original participatory_space_floating_help methods

* restore link text to component_name instead of program

* set gap in content blocks

* fix glitches in mobile & code reviews

* small css glitch

* add changes from #10007

* move CSS specification to its own file

* fixes a11y

* avoid foundation [data-open] throws error

* merge item-list into card css component

* update item-list* classes with card__list*

* adapt login modal to follow a regular markup

* don't allow custom htl text on descriptions

* remove cursor pointer on hover

* add title to content-block component

* tune documents partial

* add note

* don't hover if not clickable

* limit size conference media sections

* add border when sibling

* simplify card grid text container

* remove literal

* remove price if it's empty or zero

* disable also in registration (specifity)

* extract photos cell from conferences to core

* remove the title from the partials (it should be added by the container)

* remove the margin-top for components since its their container who sets that up

* align left if only child

* update i18n key

* update tests for attachments

* more specific css component rule

* make link specific css

* add span style as component part

* wrap button text contents

Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Co-authored-by: eliegaboriau <93646702+eliegaboriau@users.noreply.github.com>
Co-authored-by: Eduardo Martinez Echevarria <eduardomech@gmail.com>
Co-authored-by: Fernando Blat <fernando@blat.es>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

project: redesign Barcelona City Council contract

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

7 participants