Skip to content

Redesign: conferences#9658

Merged
ahukkanen merged 192 commits intodevelopfrom
feature/redesign-conferences
Dec 22, 2022
Merged

Redesign: conferences#9658
ahukkanen merged 192 commits intodevelopfrom
feature/redesign-conferences

Conversation

@Crashillo
Copy link
Copy Markdown
Contributor

@Crashillo Crashillo commented Aug 3, 2022

🎩 What? Why?

Redesign conferences

Closes #10138

📷 Screenshots

❗ Caveats

1 There's a console error on the program page, when clicking the date buttons or the categories. It's a conflict with Foundation, as it's using a data-open attribute, required to toggle the views (part of a11y-accordion-component lib). Once Foundation will be removed, the error won't longer happen. Preview error: Uncaught Error: Syntax error, unrecognized expression: #

♥️ Thank you!

@Crashillo Crashillo added the project: redesign Barcelona City Council contract label Aug 3, 2022
@Crashillo Crashillo requested a review from rober-gd August 5, 2022 13:05
Crashillo and others added 13 commits August 10, 2022 15:33
* Handle password change properly at the account form

When the user tried to update their account without changing their
password, they could not submit the form due to the front-end
validations.

Fix this issue by marking those fields required only when they
are visible on the form.

* Make sure the spec checks the encrypted password is not changed

When account is updated without providing a password, the
encrypted password shouldn't change.

* Do not autofill the password on the account form

In tests, the user record responds to `.password` which causes
the account form updates to work differently in tests than they do
for actual users.

* Apply feedback from the code review

* Add also password and password confirmation errors on the form

In case the password update failed, the user doesn't get any
feedback. This fixes that issue.
* Change date meetings filters checkboxes to radio buttons

* Fix default upcoming filter on meetings' controller

* Order filtered meetings by start_time

* Use Faker::Date in meetings' seeds

* Convert let definitions to one line blocks

* Fix typo

* Add default filter specs for Upcoming meetings

* Add specs for 'date filters' on meetings

* Reintroduces the 'All' filter for meetings dates

* Remove uneceessary instance variable

Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>

* Fix for 500 errors on static maps

* Preserve the currently selected per_page value with filter forms

* Fix the broken specs due to changes in the per_page configuration

* Do not use concat in helpers that are used in cells

* Rubocop

Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>
* Fix notification daily and weekly status

* Fix notification digest sending decider to check from the end of the day

* Rubocop
* modify nickname and avatar in user presenter

* add spec

* modify nickname
* Rename cookie_consent to data_consent

* Rename the data consent entry point to index.js

* Fix the data consent entry point definition (wrong naming)

* Fix the reference to the consent manager

* Set the expiry period for the data consent cookie to 365 days

* Add the secure flag to the cookie when under https

* Add the domain and SameSite to the consent cookie

* Add possibility to use HTTPS in development and tests

* Add jest tests to test the cookie flags for the consent manager

* Add system spec for the data consent

* Add CI action for testing some of the system specs under HTTPS

* Rename cookie_consent to data_consent and cookie_details to details

In order not to confuse implementors that the data consent is not
only about cookies.

* Remove further references to cookies from the translations and code

* Update docs with the latest code changes and remove references to cookies

* Rename "cookies" doc page to "data_consent" and add relevant changes

Add a note that the data consent is not only about cookies.

* Add the review suggestions to the data consent docs

* Update the documentation regarding testing under SSL

* ESLint

* Rename cookie_consent_warning partial to data_consent_warning

* Fix the translation key for data_consent_settings

* Fix the translation keys for data consent warning

* Refine the JS code comments not to refer particularly to cookie consent

* Rename the "cookies" system specs to "data_consent"

* Move the data consent cookie flags test to the "data_consent" folder

* Update the reference to the correct test in the core system SSL action

* Update the action name for better ordering in the list

* Change the cookie-consent SCSS file name to data-consent

* Update the reference to data-consent SCSS in the docs

* Update the capybara helper to data_consent and the related module name

* Fix partial name in meetings

* Fix the comments in the initializer template

* Fix the domain and flags in the default consent cookie

After introducing the new flags and setting the domain for the
cookie, the Capybara cookie was overriding the cookie set by JS
because it had incorrect domain (JS allows also subdomains).

Also add the extra flags to the default cookie that were added to
the JS for consistency and to avoid potential side effects.

* Fix the organization data consent spec after the default cookie changes

* Fix the default cookie if the domain is localhost

* Improve the expectation for the cookie expiry

* Change `cookie` to `dataconsent` in the CSS class names

* Rename `cc-` prefix to `dc-` in the data consent HTML IDs and classes

* Update the development app notes

* Update ruby version for the SSL tests

* Apply modifications to the cookie consent description based on review
* Add Markdown linter rake task

* Add 'Lint Markdown files' step in CI

* Add excluded files on markdown linter task

* Fix heading levels

* Specify language in fenced code block

* Fix unordered list styles

* Fix ordered list prefixes

* Escape HTML tag

* Simplify system admin creation documentation on generated README

* Ignore the 'Multiple top level headers' rule in Participatory Texts example doc

* Add ignore_rules_for_file logic in markdown linter

* Ignore the 'Multiple top level headers' rule in Participatory Texts seed example

* Ignore the 'First header should be a top level header' rule in GraphQL API doc

* Remove mdl gem and configuration

* Add markdownlint-cli NPM package and configuration

* Change mdl references to markdownlint-cli

* Fix linter offenses

* Remove codeclimate markdownlint plugin

* Add inline ignore rules in Participatory Texts examples

* Ignore HTML comments when importing Markdown files

* Fix HTML tags on spec

* Reintroduce wrongly deleted stylelint script

* Explicitly add fileutils as requirement

If not, I have this exception when calling it directly:

$ bin/rspec spec/webpacker_spec.rb

(...)
NameError:
  uninitialized constant FileUtils
  Did you mean?  FileTest
(...)

* Sync npm packages files

* Update spec to remove HTML comments

* Fix the decidim-packs ignore from markdownlint

* Change the markdownlint script name and the glob match pattern

* Fix the disable file inline comment

* Move the strong style and emphasis style excludes to correct file

* Move the markdownlint-cli package to the distributed dev package

* Fix the markdownlint script name in the github action

* Remove unnecessary added linebreak from the Rakefile

* Rename the markdownlint.yml config file extension for consistency

* Fix missing markdownlint

* Exclude link-fragments rule for the API usage.md

* Add examples how to lint and fix markdownlint issues

* Rake bundle

Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>
* Fix uninitialized constant errors for unexisting modules

* Add specs for the dependency resolver

* Document the method without documentation

* Remove unnecessary commented code

* DRY comments

* Reset the resolver cache during the tests

* Add debug messages for CI

* More debug

* Try relative paths to the git gems in the custom Gemfile

* Print out the generated Gemfile.lock

* Revert "Try relative paths to the git gems in the custom Gemfile"

This reverts commit bb2f675.

* Print out the root dirs in the test debug

* Revert "Print out the root dirs in the test debug"

This reverts commit 06983f1.

* Move debug to its own spec

* Print out bundle(r) and gem related ENV vars

* More debug logging

* Remove the unnecessary yield argument

* Fix syntax error

* Add debug for the dummy lockfile generation

* Report bundle not frozen during the custom Gemfile specs

* Remove the debug output from the custom Gemfile specs

* Add specs for `Decidim.module_installed?`

* Add missing return value YARD docs

* Rubocop auto-correct
* Prevent the PWA install notification after user has seen it

* Add the new local storage item to the essential local data

* Refactor the install prompt prevention to a2hs.js at the sw folder
* two-columns layout

* card blog

* layout index blog

* one column layout + decorator

* blog post show prose

* Enable explicitly redesign on posts controller

* replace locals by content_for block

* single post botton bar

* fix bg-color new tailwind setup

* remove unnecessary css class

* restore post description

* add filter component (non-functional)

* fix blog glitches

* adapt blogs show to new layout

* Fix presenter detection of author on blogs

* Refactor actions on author cell

* Remove unused partial

* Recover id in follow_button to allow ajax refresh

* Remove unused translations

* Update selector in posts tests

* Use paginable concern in posts controller

* Fix pagination test in posts

* Remove deprecated test

The back button dissapear in the redesign

* Remove deprecated test

The most commented section is removed in the redesign

* Replace TODOs with REDESIGN PENDING

* Revert comment

* Integrate endorsers list

* Allow to define which context actions may appear in author cell

* Split endorsements_button in redesigned and legacy design versions

* Fix js endorsements template to take into account redesign

* Define profile from cell in redesigned author cell

* Update test to take into account redesign in endorsements feature

* Sanitize title in debates card

* Split follow button in redesigned and legacy versions

* Remove read more link from blog descriptions in index

* export layout 2 columns

* fixes on blog lists

* fix glitches blog show

* fix lint

* Allow definition of a layout in redesigned author cell

* Include layouct and context actions in cache key of redesigned author cell

* alternative design blog author

* set generic layouts

* Refactor author compact display

* endorsers list toggler

* update buttons classes

* blog buttons

* apply button updates

* avoid tailwind compilation

* Allow to provide options to redesigned_follow_button from helper using it

* Allow redesigned author to display only avatar image

* Define full list view in endorsers_list cell and use avatar version of redesigned author cell

* set fixed bottom space

* Allow to provide options to redesigned_follow_button from helper using it

* Fix translation

* restore script

* set gradient stops

* fix lint

* Fix linter offense

* responsive 2col layout

* icon to endorsements

* restore h4

* replace button and hide links

* fix actions menu mobile

* Update default tail for html truncation

* Use default tail chars

* Fix specs

* close endorsements as button

* skip links

* remove unnecessary role

Co-authored-by: Eduardo Martinez Echevarria <eduardomech@gmail.com>
Co-authored-by: Fernando Blat <fernando@blat.es>
@furilo furilo requested a review from NilHomedes December 15, 2022 08:57
@Crashillo Crashillo force-pushed the feature/redesign-conferences branch from 7b7ba02 to cafd46a Compare December 15, 2022 17:00
furilo
furilo previously approved these changes Dec 19, 2022
@furilo
Copy link
Copy Markdown
Contributor

furilo commented Dec 19, 2022

@decidim/product all pending issues are extracted or done, can you review so we can move forward? tx!

@NilHomedes
Copy link
Copy Markdown
Member

Everything looks good to me. Even though, I've detected that I can not click on the days of the program, so it's not possible to switch between days. The same happens between meeting categories in the program. See video:

AwesomeScreenshot-19_12_202217.34.37.mp4

@Crashillo
Copy link
Copy Markdown
Contributor Author

Crashillo commented Dec 20, 2022

Everything looks good to me. Even though, I've detected that I can not click on the days of the program, so it's not possible to switch between days. The same happens between meeting categories in the program. See video:

This error was introduced by another branch. We've cleaned the kitchen a bit so such issue no longer happens, you may test it here

NilHomedes
NilHomedes previously approved these changes Dec 20, 2022
Copy link
Copy Markdown
Member

@NilHomedes NilHomedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok @Crashillo then I will approve this PR to move forward.

@Crashillo Crashillo linked an issue Dec 21, 2022 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go for me.

There are some things broken at the redesign app, such as the above mentioned conference dates and also the registrations were not working there for me (at least when signed out, could not click the buttons). But locally these both work fine, so I guess it's related to some other PR.

I also noticed the same z-index error with the header as with accountability that I have already reported at #9669. I added there that it also applies to conferences.

I also found one glitch regarding the CSS styling hover/active states at registrations that I have reported to #9679.

Apart from those issues, I did not find any further issues. I also went through the previous comments of which most were fixed and the rest were moved to the pending issues.

Great work! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

project: redesign Barcelona City Council contract

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Buttons should go to two lines Polish Documents component

10 participants