Remove the threads limit from the Capybara Puma server#9422
Merged
andreslucena merged 4 commits intodecidim:developfrom Jun 16, 2022
Merged
Remove the threads limit from the Capybara Puma server#9422andreslucena merged 4 commits intodecidim:developfrom
andreslucena merged 4 commits intodecidim:developfrom
Conversation
12 tasks
ahukkanen
commented
Jun 14, 2022
Contributor
Author
ahukkanen
left a comment
There was a problem hiding this comment.
Note for the reviewer:
If you are wondering why I disabled the queue_requests option.
andreslucena
approved these changes
Jun 16, 2022
andreslucena
pushed a commit
that referenced
this pull request
Jul 6, 2022
* Remove the threads limit from the Capybara Puma server * Disable Puma queue_requests option for the Capybara server
eliegaboriau
pushed a commit
to eliegaboriau/decidim
that referenced
this pull request
Oct 25, 2022
* Remove the threads limit from the Capybara Puma server * Disable Puma queue_requests option for the Capybara server
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
In the past we added the min-max threads limit as 1:1 to the puma server running during the "system" / E2E tests at #7366.
The reason was that there were specific tests that were constantly timing out and we figured we could fix this issue by limiting the threads to 1:1 allowing the tests to finish properly.
The particular test that was freezing was related to the admin newsletters view. Later during Ruby 3 upgrade, we figured out that there was actually a thread safety issue with Webpacker which caused the newsletters view to fail when using more than a single thread. This was fixed at #9203.
So I believe after #9203 the original issue described at #7366 no longer exists which means we can remove the threads limit.
I'm not expecting any major benefits from this but I feel it might be a good idea to also run the tests in multi-threaded mode so that we can identify possible further thread safety issues when they arise.
📌 Related Issues
Testing
📋 Checklist
docs/.