Skip to content

Configure capybara puma maximum threads to 1#7366

Merged
mrcasals merged 1 commit intodecidim:developfrom
mainio:fix/admin-specs-timeouts
Feb 13, 2021
Merged

Configure capybara puma maximum threads to 1#7366
mrcasals merged 1 commit intodecidim:developfrom
mainio:fix/admin-specs-timeouts

Conversation

@ahukkanen
Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen commented Feb 12, 2021

🎩 What? Why?

There is a somewhat concurrent timeout error in the system specs that test the views with iframes.

The issue seems to relate to puma server threads in the Capybara server configuration.

The issue seems to be resolved when we set the minimum and maximum threads to 1.

Here is information about configuring the puma threads:
https://github.com/puma/puma#thread-pool

Example test run that timed out:
https://github.com/decidim/decidim/pull/7362/checks?check_run_id=1889105872

Testing

This seems to happen quite constantly when running the admin newsletter templates system spec, so try try running:

$ cd decidim-admin
$ bundle exec rspec spec/system/admin_manages_newsletter_templates_spec.rb

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

@ahukkanen ahukkanen changed the title Configure puma capybara maximum threads to 1 Configure capybara puma maximum threads to 1 Feb 12, 2021
Copy link
Copy Markdown
Contributor

@mrcasals mrcasals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMGGGG @ahukkanen thank you so much for this!!!

@mrcasals mrcasals merged commit bec7a6a into decidim:develop Feb 13, 2021
@ahukkanen ahukkanen deleted the fix/admin-specs-timeouts branch February 13, 2021 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants