Configure capybara puma maximum threads to 1#7366
Merged
mrcasals merged 1 commit intodecidim:developfrom Feb 13, 2021
Merged
Conversation
mrcasals
approved these changes
Feb 13, 2021
Contributor
mrcasals
left a comment
There was a problem hiding this comment.
OMGGGG @ahukkanen thank you so much for this!!!
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
There is a somewhat concurrent timeout error in the system specs that test the views with iframes.
The issue seems to relate to puma server threads in the Capybara server configuration.
The issue seems to be resolved when we set the minimum and maximum threads to 1.
Here is information about configuring the puma threads:
https://github.com/puma/puma#thread-pool
Example test run that timed out:
https://github.com/decidim/decidim/pull/7362/checks?check_run_id=1889105872
Testing
This seems to happen quite constantly when running the admin newsletter templates system spec, so try try running:
$ cd decidim-admin $ bundle exec rspec spec/system/admin_manages_newsletter_templates_spec.rb📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.