Fix webpacker thread safety#9203
Merged
andreslucena merged 2 commits intodecidim:developfrom Apr 29, 2022
Merged
Conversation
Merged
andreslucena
approved these changes
Apr 29, 2022
Member
andreslucena
left a comment
There was a problem hiding this comment.
👍🏽👍🏽👍🏽
I've tried the spec alone on develop and also on ruby-3.0 branches, on both it failed, except for one time when it passed.
Then I've checked this fix on both branches, on both it worked. Just to be extra sure, I've rerun it 50 times, as I had the flaky pass before. On all the 100 runs, it passed (OK/green).
I checked the admin's newsletter templates page on ruby-3.0 and it worked too.
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
We noticed at #8452 that Webpacker is not thread safe which is hopefully the last blocker for the Ruby 3 upgrade.
This should fix Webpacker thread safety according to the discussion and instructions at:
rails/webpacker#2801
There is a further fix for determining the full expanded paths inspired by this commit at Shakapacker:
shakacode/shakapacker@f2dc437
📌 Related Issues
Testing
📋 Checklist
docs/.