Update ruby to 3.0 by alecslupu · Pull Request #8452 · decidim/decidim

alecslupu · 2021-10-31T18:03:47Z

🎩 What? Why?

Upgrade Decidim to Ruby 3.0.2

♥️ Thank you!

ferblape

🚀

ahukkanen

@alecslupu You asked me previously about the problem with the attributes of type Rails::Engine. These changes need to be reverted (or changed to **{} in Ruby 3) for these attributes to work correctly.

This is explained in the CHANGELOG notes if you search for Rails::Engine from there.

There is a limitation in the Ruby language that if the method has default values for the previous arguments and defines keyword arguments, the last argument will always receive a respond_to?(:to_hash) call to it which doesn't work for Rails::Engine (you can try it out in the Rails console by calling Rails::Engine.respond_to?(:to_hash)).

EDIT:
Actually in Ruby 3 we just need to pass the hash as an empty keyword argument list as **{}. I'll modify my comments below.

decidim-core/lib/decidim/component_manifest.rb

decidim-core/lib/decidim/participatory_space_context_manifest.rb

decidim-core/spec/lib/attribute_object/model_spec.rb

decidim-verifications/lib/decidim/verifications/workflow_manifest.rb

ahukkanen · 2022-03-18T11:49:40Z

@alecslupu Can you rebase this with develop please? 🙏

I'd like to get rid of the deprecation messages to review this properly.

.github/workflows/ci_api.yml

ahukkanen

I'm not sure what to do about these but I would rather try to push these changes to the upstream repositories of these gems.

The Origami gem seems stale at the moment, though...

decidim-elections/lib/gem_overrides/graphlient/client.rb

decidim-initiatives/lib/gem_overrides/origami/date.rb

andreslucena · 2022-04-27T12:01:52Z

If someone else can or cannot replicate this, let me know.

I can reproduce this.

Steps:

Sign in as admin
Go to http://localhost:3000/admin/newsletter_templates

The funny thing is that it only breaks in one of the templates, and it isn't consistent in which template it breaks.

ahukkanen · 2022-04-27T15:09:52Z

I can reproduce this.

Thanks @andreslucena for confirming!

I believe this has something to do with the version of Webpacker we are using not being thread safe.

If I do the following change at development_app/config/puma.rb:

# Comment this out:
# threads min_threads_count, max_threads_count
# Add this instead:
threads 1, 1

Then I cannot make this break anymore.

It has something to do webpacker trying to process the javascript_pack_tag or stylesheet_pack_tag concurrently in multiple threads.

alecslupu · 2022-04-27T18:33:05Z

I can reproduce this.

Thanks @andreslucena for confirming!

I believe this has something to do with the version of Webpacker we are using not being thread safe.

If I do the following change at development_app/config/puma.rb:
# Comment this out:
# threads min_threads_count, max_threads_count
# Add this instead:
threads 1, 1
Then I cannot make this break anymore.

It has something to do webpacker trying to process the javascript_pack_tag or stylesheet_pack_tag concurrently in multiple threads.

Wow, Nice catch.

It seems that I already had the number of threads set to 1, 1, and this was the reason i could not replicate it.

@ahukkanen, Webpacker hits us again >:) ... Maybe it would make sense to continue the discussion about the import maps or alternatives.

ahukkanen · 2022-04-28T11:58:37Z

The chdir issue seems to be Ruby 3 related, so we need to resolve this.

The reason why it hasn't failed "hard" with Ruby 2.x is this:
ruby/ruby#3591

They changed the conflicting chdir from warning to a RuntimeError in Ruby 3.

This is further explained here:
rails/webpacker#2801

I also found a commit in Shakapacker which fixes this issue (at least judging by the commit message):
shakacode/shakapacker@f2dc437

This fix seems to be similar to what is explained in that webpacker issue linked above.

ahukkanen · 2022-04-28T14:20:22Z

@ahukkanen, Webpacker hits us again >:) ... Maybe it would make sense to continue the discussion about the import maps or alternatives.

@alecslupu @andreslucena I am adding the proposed monkey patch in the related issue at #9203. Once we get that merged, we should be finally able to merge this one.

andreslucena · 2022-04-29T06:45:37Z

@alecslupu @andreslucena I am adding the proposed monkey patch in the related issue at #9203. Once we get that merged, we should be finally able to merge this one.

I've just reviewed and merged it.

ahukkanen

This is good to go now after we got that thread safety issue resolved.

Can you also give your review @andreslucena to indicate @alecslupu that this is ready to be merged and we can revert the lines that we need to revert before merging.

andreslucena

I've just give it a last spin locally and it's fine for me 👍🏽

andreslucena · 2022-05-02T14:07:02Z

@alecslupu you can revert the lines anytime you can

ahukkanen · 2022-05-02T15:32:57Z

@alecslupu Sorry there is still missing specs because of another recently merged PR: #8866.

The problem is on this line:

decidim/decidim-admin/app/views/decidim/admin/participatory_space_private_users_csv_imports/new.html.erb

Line 9 in d283907

I'll fix it in another PR shortly.

alecslupu · 2022-05-02T15:35:24Z

I was just looking on it ... and fixing from my end... but if you want to merge, to let it become Core, then i am okay with that

ahukkanen · 2022-05-02T15:39:09Z

I was just looking on it ... and fixing from my end... but if you want to merge, to let it become Core, then i am okay with that

Should be fixed by #9218.

ahukkanen · 2022-05-03T08:05:06Z

@alecslupu Can you merge with develop please? Let's see that the CI is green and then we can finally merge this. 🤞

alecslupu · 2022-05-03T09:14:48Z

@ahukkanen the pipeline is Green :)

ahukkanen · 2022-05-03T09:22:05Z

Enormous work here @alecslupu, many thanks to you and everyone involved! And thanks for the great patience with all the related issues and changes.

I've just merged with develop and let's see that the generators CI also passes after this.

alecslupu force-pushed the ruby-3.0 branch from 724cc59 to 4e5de96 Compare November 8, 2021 07:18

andreslucena mentioned this pull request Dec 20, 2021

Update ruby to 2.7.5 #8629

Merged

12 tasks

alecslupu force-pushed the ruby-3.0 branch 2 times, most recently from e45ea1c to 357f504 Compare January 3, 2022 15:06

andreslucena changed the title ~~Upgrade Decidim to Ruby 3.0~~ Update ruby to 3.0 Jan 4, 2022

alecslupu force-pushed the ruby-3.0 branch from 357f504 to 8273b67 Compare January 4, 2022 13:00

alecslupu requested review from andreslucena, ferblape and roxanaopr January 4, 2022 15:21

ferblape previously approved these changes Jan 5, 2022

View reviewed changes

alecslupu dismissed ferblape’s stale review via 72a4064 January 18, 2022 03:35

alecslupu force-pushed the ruby-3.0 branch 3 times, most recently from 4797a6b to d09ab45 Compare January 18, 2022 05:26

andreslucena mentioned this pull request Jan 24, 2022

Decidim "0.25.2" - Problem installing node.js with docker after the 16.9.1 update #8720

Closed

alecslupu force-pushed the ruby-3.0 branch from d09ab45 to fe89a75 Compare January 26, 2022 05:45

alecslupu force-pushed the ruby-3.0 branch from fe89a75 to 9e25c8a Compare February 3, 2022 07:43

andreslucena assigned ahukkanen Feb 23, 2022

alecslupu force-pushed the ruby-3.0 branch from 9e25c8a to 8daa1ad Compare February 23, 2022 11:47

ahukkanen requested changes Mar 12, 2022

View reviewed changes

alecslupu force-pushed the ruby-3.0 branch 3 times, most recently from dea01d7 to a9f7555 Compare March 14, 2022 06:58

alecslupu requested a review from ahukkanen March 14, 2022 10:21

ahukkanen reviewed Mar 18, 2022

View reviewed changes

.github/workflows/ci_api.yml Show resolved Hide resolved

ahukkanen reviewed Mar 18, 2022

View reviewed changes

decidim-elections/lib/gem_overrides/graphlient/client.rb Outdated Show resolved Hide resolved

decidim-initiatives/lib/gem_overrides/origami/date.rb Show resolved Hide resolved

alecslupu force-pushed the ruby-3.0 branch 2 times, most recently from e62f98b to e6e4a38 Compare March 22, 2022 21:01

alecslupu requested a review from ahukkanen March 22, 2022 22:25

ahukkanen mentioned this pull request Apr 28, 2022

Fix webpacker thread safety #9203

Merged

12 tasks

ahukkanen previously approved these changes Apr 29, 2022

View reviewed changes

andreslucena previously approved these changes May 2, 2022

View reviewed changes

alecslupu added 2 commits May 2, 2022 17:12

Merge branch 'develop' of github.com:decidim/decidim into ruby-3.0

5180ebc

Set the generator to use Decidim Official repo

588460a

alecslupu dismissed stale reviews from andreslucena and ahukkanen via 588460a May 2, 2022 14:14

alecslupu requested a review from ahukkanen May 2, 2022 14:20

ahukkanen mentioned this pull request May 2, 2022

Fix invalid translation call #9218

Merged

12 tasks

alecslupu added 2 commits May 3, 2022 11:24

Merge branch 'develop' of github.com:decidim/decidim into ruby-3.0

64ddbf5

Running linters

b27dc7e

ahukkanen approved these changes May 3, 2022

View reviewed changes

ahukkanen merged commit f402b6e into decidim:develop May 3, 2022

alecslupu deleted the ruby-3.0 branch May 3, 2022 09:40

ahukkanen mentioned this pull request May 10, 2022

Fix generators specs target branch #9284

Merged

12 tasks

andreslucena mentioned this pull request Oct 20, 2022

Bump versions on install docs #9916

Merged

alecslupu added this to the 0.27.0 milestone Jul 14, 2023

Uh oh!

Conversation

alecslupu commented Oct 31, 2021 • edited by andreslucena Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎩 What? Why?

Uh oh!

ferblape left a comment

Choose a reason for hiding this comment

Uh oh!

ahukkanen left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ahukkanen commented Mar 18, 2022

Uh oh!

Uh oh!

ahukkanen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

andreslucena commented Apr 27, 2022

Uh oh!

ahukkanen commented Apr 27, 2022

Uh oh!

alecslupu commented Apr 27, 2022

Uh oh!

ahukkanen commented Apr 28, 2022

Uh oh!

ahukkanen commented Apr 28, 2022

Uh oh!

andreslucena commented Apr 29, 2022

Uh oh!

ahukkanen left a comment

Choose a reason for hiding this comment

Uh oh!

andreslucena left a comment

Choose a reason for hiding this comment

Uh oh!

andreslucena commented May 2, 2022

Uh oh!

ahukkanen commented May 2, 2022

Uh oh!

alecslupu commented May 2, 2022

Uh oh!

ahukkanen commented May 2, 2022

Uh oh!

ahukkanen commented May 3, 2022

Uh oh!

alecslupu commented May 3, 2022

Uh oh!

ahukkanen commented May 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

alecslupu commented Oct 31, 2021 •

edited by andreslucena

Loading

ahukkanen left a comment •

edited

Loading